Re: [PATCH] ARM: imx6q: remove unused header includes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing <linux/phy.h> and <linux/micrel_phy.h> causes a build failure because the prerequisite commit 8392af7be78d is not present in the baseline, leaving PHY-related code intact.
--

commit a97dbfcf09e3d32d8bf22f55a25ab0c09018688e
Author: Heiner Kallweit <hkallweit1@gmail.com>

ARM: imx6q: remove unused header includes

This commit removes the includes for phy.h and micrel_phy.h in mach-imx6q.c.
The commit message indicates these headers are no longer used after a prior
commit.

> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
> index 7f62009257526..8aa76f42ab76e 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -8,9 +8,7 @@
>  #include <linux/irqchip.h>
>  #include <linux/of_platform.h>
>  #include <linux/pci.h>
> -#include <linux/phy.h>
>  #include <linux/regmap.h>
> -#include <linux/micrel_phy.h>

[Severity: Low]
Does this removal cause a build failure in the current tree? It appears that
the prerequisite commit 8392af7be78d is not present in this baseline, leaving
PHY-related code intact.

For instance, ksz9021rn_phy_fixup() relies on struct phy_device, phy_write(),
and MICREL_KSZ9021_EXTREG_CTRL defined in the removed headers:

arch/arm/mach-imx/mach-imx6q.c:ksz9021rn_phy_fixup() {
	if (IS_BUILTIN(CONFIG_PHYLIB)) {
		/* min rx data delay */
		phy_write(phydev, MICREL_KSZ9021_EXTREG_CTRL,
			0x8000 | MICREL_KSZ9021_RGMII_RX_DATA_PAD_SCEW);
		...
}

Additionally, imx6q_enet_phy_init() relies on phy_register_fixup_for_uid
and PHY constants that are no longer included:

arch/arm/mach-imx/mach-imx6q.c:imx6q_enet_phy_init() {
	if (IS_BUILTIN(CONFIG_PHYLIB)) {
		phy_register_fixup_for_uid(PHY_ID_KSZ9021, MICREL_PHY_ID_MASK,
				ksz9021rn_phy_fixup);
	}
}

Removing these headers unconditionally triggers a compile time regression due
to undeclared identifiers.

>  #include <linux/mfd/syscon.h>
>  #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
>  #include <asm/mach/arch.h>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/3cec5f38-e0d6-4d12-88d4-74cb0000a2f2@gmail.com?part=1