From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1FEBC88E53 for ; Fri, 11 Sep 2026 21:21:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QCAUGSAZrrSGkw1Ztm7lZzvllqLX0t+HnO8XZ3Qi4Gs=; b=DVvLwLDn5fjjx2 iii+IQQXZbRkVq3ivF1CUe3d6/OaVkIpV71iQvNMJi89h2TAcUKDO0l1ZHeC2o8MeH8MW43vTjS5c Wsn8aByng/c034OjPn1Rjc2OMO0gDTXZpBcMuZeaKdI04swNdYP5r3vc9JMsOHJwlHi1tNHh3L3Ya 5ogfSVC94d7MY57D6TAQ7aUrLrjZBsg3oedsCkcTGroNhIL8byuaJ1UxueqlYk4sCqCCD8mQmn0lT l+q/W1SdLWC0YjNU/DU9sLfNpsWNloCidPOvMGkVJ3tlzVyoi+R5O0OrP7CDk1JaJpuUqT0ORHjf1 U6tnmaUUMc64Tq3TmzVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x58gr-00000000AAp-14RE; Fri, 11 Sep 2026 21:21:45 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x58gp-00000000A8V-1xC7 for linux-i3c@lists.infradead.org; Fri, 11 Sep 2026 21:21:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B36EA439F7; Fri, 11 Sep 2026 21:21:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 535861F000FF; Fri, 11 Sep 2026 21:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789161702; bh=r4E8k96H7dpGkRg9V///RyiymeywzlTi8LMpRuYA+GQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VHzu+CC16J405OCwOpj0lnMId5mYykqyI+hOZY2paehAWj8o1kWn2PZZ8NmQ3s62G ah0w+3jvoLSNvMduxYsMiKYuqZ8S8Cr/0C3Tbn8DMx0F5nsOVtogDw6Db2M7OKozMg Qnd2v4Bd2sNO76bpoDqXMCPO5WbgOeE7dnDu9II1CHXdmmn++jzHoBvyeGASQO8H8r zJApgPcUQ5DqRR7QmqUb7rTDuB2zJgvBrvLNBhoW/FuD4+q+IQyKFTTLDkwXLp0spB +rjICf6zGGunCbyF2s5AkVUsXwt/+O7+kj86DMxRcC4ahztXdncqqkOVJZ6p/3uHpi 0ReyHfGzkx/Yw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] i3c: add i3cdev character device module for user-space access To: "Meagan Lloyd" Cc: linux-hwmon@vger.kernel.org, Frank.Li@kernel.org, linux-i3c@lists.infradead.org, "Alexandre Belloni" In-Reply-To: <20260911210935.1353126-4-meaganlloyd@linux.microsoft.com> References: <20260911210935.1353126-1-meaganlloyd@linux.microsoft.com> <20260911210935.1353126-4-meaganlloyd@linux.microsoft.com> Date: Fri, 11 Sep 2026 21:21:41 +0000 Message-Id: <20260911212142.535861F000FF@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gTWF4IFdyaXRlIExl bmd0aCAoTVdMKSBjaGVjayBpcyBieXBhc3NlZCBpbiBgaTNjZGV2X3dyaXRlYCBkdWUgdG8gdW5p bml0aWFsaXplZCBsZW5ndGggZmllbGQuCi0gW01lZGl1bV0gTWl4aW5nIGdvdG8tYmFzZWQgZXJy b3IgaGFuZGxpbmcgYW5kIGBzY29wZWRfZ3VhcmQoKWAgZGVjbGFyYXRpb25zIGluIHRoZSBzYW1l IGZ1bmN0aW9uIHZpb2xhdGVzIHRoZSBjbGVhbnVwIHN1YnN5c3RlbSBndWlkZWxpbmVzLgotIFtN ZWRpdW1dIE1lbW9yeSBhbmQgcmVmZXJlbmNlIGNvdW50IGxlYWsgb24gdGhlIGBkZXZfc2V0X25h bWUoKWAgZXJyb3IgcGF0aCBpbiBgaTNjZGV2X3Byb2JlKClgLgotIFtNZWRpdW1dIFVuLXJhdGVs aW1pdGVkIGtlcm5lbCBsb2dnaW5nIGluIGBwcmludF9pM2NfZXJyYCBhbGxvd3MgdW5wcml2aWxl Z2VkIHVzZXJzIHRvIGZsb29kIGRtZXNnLgotLQoKY29tbWl0IDY5MWEzMDM0MmVlY2FjMWI1YmY4 ODE4MWJmYWI0YWRlNDQzZjI5MjMKQXV0aG9yOiBNZWFnYW4gTGxveWQgPG1lYWdhbmxsb3lkQGxp bnV4Lm1pY3Jvc29mdC5jb20+ClN1YmplY3Q6IGkzYzogYWRkIGkzY2RldiBjaGFyYWN0ZXIgZGV2 aWNlIG1vZHVsZSBmb3IgdXNlci1zcGFjZSBhY2Nlc3MKClRoaXMgY29tbWl0IGludHJvZHVjZXMg YSBjaGFyYWN0ZXIgZGV2aWNlIGRyaXZlciBmb3IgSTNDIGRldmljZXMuIEl0IGFsbG93cwp1c2Vy LXNwYWNlIGFwcGxpY2F0aW9ucyB0byBwZXJmb3JtIGJhc2ljIFNEUiByZWFkcyBhbmQgd3JpdGVz IGJ5IGJpbmRpbmcKZGV2aWNlcyBtYW51YWxseSB2aWEgc3lzZnMgZHJpdmVyX292ZXJyaWRlLgoK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pM2MvaTNjZGV2LmMgYi9kcml2ZXJzL2kzYy9pM2NkZXYu Ywo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uZGEwZTY5MTBh NGY3Mgo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJzL2kzYy9pM2NkZXYuYwoKWyAuLi4g XQoKPiArc3RhdGljIHNzaXplX3QKPiAraTNjZGV2X3JlYWQoc3RydWN0IGZpbGUgKmZpbGUsIGNo YXIgX191c2VyICpidWYsIHNpemVfdCBjb3VudCwgbG9mZl90ICpmX3BvcykKPiArewoKWyAuLi4g XQoKPiArCXNjb3BlZF9ndWFyZChtdXRleCwgJmkzY2Rldi0+bG9jaykgewo+ICsJCS8qIC5yZW1v dmUgd2FzIGNhbGxlZCBzbyBkb24ndCBtZXNzIHdpdGggdGhlIGRldmljZSAqLwo+ICsJCWlmICgh aTNjZGV2LT5ib3VuZCkgewo+ICsJCQlyZXQgPSAtRU5YSU87Cj4gKwkJCWdvdG8gb3V0X2ZyZWVf a2J1ZjsKPiArCQl9Cj4gKwo+ICsJCXJldCA9IGkzY19kZXZpY2VfZG9feGZlcnMoaTNjLCAmeGZl ciwgMSwgSTNDX1NEUik7Cj4gKwkJaWYgKHJldCkKPiArCQkJZ290byBvdXRfZnJlZV9rYnVmOwo+ ICsJfQoKW1NldmVyaXR5OiBNZWRpdW1dCkRvZXMgdGhpcyBtaXggZ290by1iYXNlZCBlcnJvciBo YW5kbGluZyB3aXRoIHNjb3BlZF9ndWFyZCgpIGluIHRoZSBzYW1lCmZ1bmN0aW9uPwoKVGhlIFZG Uy9jbGVhbnVwIGd1aWRlbGluZXMgaW5kaWNhdGUgdGhhdCBtaXhpbmcgZ290by1iYXNlZCBlcnJv ciBsYWJlbHMgd2l0aApzY29wZS1iYXNlZCBjbGVhbnVwcyBsaWtlIHNjb3BlZF9ndWFyZCgpIGNy ZWF0ZXMgY29uZnVzaW5nIG93bmVyc2hpcCBzZW1hbnRpY3MKYW5kIGluY3JlYXNlcyB0aGUgcmlz ayBvZiBkb3VibGUtZnJlZSBvciByZXNvdXJjZSBsZWFrcy4gU2luY2UgdGhlIGZ1bmN0aW9uCnVz ZXMgYSBnb3RvIGxhYmVsIGZvciBmcmVlaW5nIHRoZSBtZW1vcnkgYnVmZmVyIG91dF9mcmVlX2ti dWYsIGNvdWxkIHdlCmVpdGhlciBjb252ZXJ0IHRoZSBidWZmZXIgdG8gdXNlIGEgc2NvcGUtYmFz ZWQgX19mcmVlKCkgb3IgdXNlIHRyYWRpdGlvbmFsCm11dGV4IGxvY2svdW5sb2NrIG9wZXJhdGlv bnM/CgpbIC4uLiBdCgo+ICtzdGF0aWMgc3NpemVfdAo+ICtpM2NkZXZfd3JpdGUoc3RydWN0IGZp bGUgKmZpbGUsIGNvbnN0IGNoYXIgX191c2VyICpidWYsIHNpemVfdCBjb3VudCwKPiArCSAgICAg bG9mZl90ICpmX3BvcykKPiArewo+ICsJc3RydWN0IGkzY2Rldl9kYXRhICppM2NkZXYgPSBmaWxl LT5wcml2YXRlX2RhdGE7Cj4gKwlzdHJ1Y3QgaTNjX2RldmljZSAqaTNjID0gaTNjZGV2LT5pM2M7 Cj4gKwlzdHJ1Y3QgaTNjX3hmZXIgeGZlciA9IHsKPiArCQkucm53ID0gSTNDX1dSSVRFCj4gKwl9 Owo+ICsJc2l6ZV90IGxlbjsKPiArCWNoYXIgKnRtcDsKPiArCWludCByZXQ7Cj4gKwo+ICsJaWYg KCFpM2NkZXYtPmJvdW5kKQo+ICsJCXJldHVybiAtRU5YSU87Cj4gKwo+ICsJLyogRmlsZSBzeXN0 ZW0gb3BlcmF0aW9uIG9mIDAgYnl0ZXMgaXMgZWZmZWN0aXZlbHkgYSB2YWxpZCwgbm8tb3AgKi8K PiArCWlmICghY291bnQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJaWYgKGV4Y2VlZHNfbXdsKGkz Y2RldiwgJnhmZXIpKQo+ICsJCXJldHVybiAtRU5YSU87Cj4gKwo+ICsJLyogQ2xhbXAgdHJhbnNm ZXIgbGVuZ3RoIHdpdGhpbiBkcml2ZXIgbGltaXRzICovCj4gKwlsZW4gPSBtaW4oY291bnQsIE1B WF9UT1RBTF9EQVRBX0JZVEVTKTsKPiArCXhmZXIubGVuID0gbGVuOwoKW1NldmVyaXR5OiBNZWRp dW1dCklzIHRoZSBNYXggV3JpdGUgTGVuZ3RoIChNV0wpIGNoZWNrIGJ5cGFzc2VkIGhlcmUgZHVl IHRvIGFuIHVuaW5pdGlhbGl6ZWQKbGVuZ3RoIGZpZWxkPwoKQXQgdGhlIHBvaW50IHdoZXJlIGV4 Y2VlZHNfbXdsKCkgaXMgY2FsbGVkLCB4ZmVyLmxlbiBpcyAwIGJlY2F1c2Ugb25seSAucm53Cndh cyBpbml0aWFsaXplZCBpbiB0aGUgc3RydWN0IGRlY2xhcmF0aW9uLiBUaGUgYWN0dWFsIHhmZXIu bGVuIGlzIGFzc2lnbmVkCmFmdGVyIHRoZSBjaGVjaywgbWVhbmluZyB0aGUgTVdMIHZhbGlkYXRp b24gd2lsbCBhbHdheXMgcGFzcyByZWdhcmRsZXNzIG9mIHRoZQpyZXF1ZXN0ZWQgc2l6ZS4gVGhp cyBjb3VsZCBhbGxvdyBoYXJkd2FyZSB0byByZWNlaXZlIHdyaXRlcyBleGNlZWRpbmcgaXRzCnN1 cHBvcnRlZCBtYXhpbXVtIGxlbmd0aC4gU2hvdWxkIHRoZSBsZW5ndGggY2xhbXAgYW5kIGFzc2ln bm1lbnQgaGFwcGVuIGJlZm9yZQp0aGUgdmFsaWRhdGlvbiBjaGVjaz8KClsgLi4uIF0KCj4gKwlz Y29wZWRfZ3VhcmQobXV0ZXgsICZpM2NkZXYtPmxvY2spIHsKPiArCQkvKiAucmVtb3ZlIHdhcyBj YWxsZWQgc28gZG9uJ3QgbWVzcyB3aXRoIHRoZSBkZXZpY2UgKi8KPiArCQlpZiAoIWkzY2Rldi0+ Ym91bmQpIHsKPiArCQkJcmV0ID0gLUVOWElPOwo+ICsJCQlnb3RvIG91dF9mcmVlX2tidWY7Cj4g KwkJfQo+ICsKPiArCQlyZXQgPSBpM2NfZGV2aWNlX2RvX3hmZXJzKGkzYywgJnhmZXIsIDEsIEkz Q19TRFIpOwo+ICsJCWlmIChyZXQpCj4gKwkJCWdvdG8gb3V0X2ZyZWVfa2J1ZjsKPiArCX0KCltT ZXZlcml0eTogTWVkaXVtXQpTaW1pbGFyIHRvIGkzY2Rldl9yZWFkKCksIGRvZXMgdGhpcyBtaXgg Z290by1iYXNlZCBlcnJvciBoYW5kbGluZyB3aXRoCnNjb3BlZF9ndWFyZCgpIGluIHRoZSB3cml0 ZSBwYXRoPwoKWyAuLi4gXQoKPiArc3RhdGljIHZvaWQgcHJpbnRfaTNjX2VycihzdHJ1Y3QgaTNj ZGV2X2RhdGEgKmkzY2RldiwKPiArCQkJICBzdHJ1Y3QgaTNjZGV2X3hmZXJzICptZXRhZGF0YSwK PiArCQkJICBzdHJ1Y3QgaTNjX3hmZXIgKmkzY194ZmVycykKPiArewo+ICsJZm9yIChpbnQgaSA9 IDA7IGkgPCBtZXRhZGF0YS0+bnhmZXJzOyBpKyspIHsKPiArCQkvKiBWYWxpZCBlcnJvcnMsIGUu Zy4gTTAgKG5vdyBjYWxsZWQgQzApIHN0YXJ0IGF0IDEgKi8KPiArCQlpZiAoaTNjX3hmZXJzW2ld LmVyciA+IDApIHsKPiArCQkJZGV2X3dhcm4oJmkzY2Rldi0+ZGV2LAo+ICsJCQkJICJJM0MgZXJy b3IgZW5jb3VudGVyZWQ6IEMldVxuIiwKPiArCQkJCSBpM2NfeGZlcnNbaV0uZXJyIC0gMSk7Cj4g KwkJCXJldHVybjsKPiArCQl9Cj4gKwl9Cj4gK30KCltTZXZlcml0eTogTWVkaXVtXQpDb3VsZCB0 aGlzIHVuLXJhdGVsaW1pdGVkIGtlcm5lbCBsb2dnaW5nIGFsbG93IHVucHJpdmlsZWdlZCB1c2Vy cyB0byBmbG9vZAp0aGUgZG1lc2cgbG9nPwoKU2luY2UgdGhpcyBlcnJvciBpcyB0cmlnZ2VyZWQg ZGlyZWN0bHkgYnkgdXNlci1zdXBwbGllZCB0cmFuc2ZlcnMgdmlhIHRoZQppb2N0bCBpbnRlcmZh Y2UsIGEgdXNlci1zcGFjZSBhcHBsaWNhdGlvbiBjb3VsZCByZXBlYXRlZGx5IHRyaWdnZXIgaGFy ZHdhcmUKZXJyb3JzIHRvIGludGVudGlvbmFsbHkgc3BhbSB0aGUga2VybmVsIGxvZ3MuIENvdWxk IHdlIHVzZSBhIHJhdGUtbGltaXRlZAp2YXJpYW50IGxpa2UgZGV2X3dhcm5fcmF0ZWxpbWl0ZWQo KSBoZXJlIHRvIHByZXZlbnQgYSBwb3RlbnRpYWwgbG9jYWwgRG9TPwoKWyAuLi4gXQoKPiArc3Rh dGljIGludAo+ICtpM2NkZXZfaW9jdGxfZG9feGZlcnMoc3RydWN0IGkzY2Rldl9kYXRhICppM2Nk ZXYsCj4gKwkJICAgICAgc3RydWN0IGkzY2Rldl94ZmVycyBfX3VzZXIgKnV4ZmVycykKPiArewoK WyAuLi4gXQoKPiArCXNjb3BlZF9ndWFyZChtdXRleCwgJmkzY2Rldi0+bG9jaykgewo+ICsJCS8q IC5yZW1vdmUgd2FzIGNhbGxlZCBzbyBkb24ndCBtZXNzIHdpdGggdGhlIGRldmljZSAqLwo+ICsJ CWlmICghaTNjZGV2LT5ib3VuZCkgewo+ICsJCQlyZXQgPSAtRU5YSU87Cj4gKwkJCWdvdG8gb3V0 X2ZyZWVfaTNjX3hmZXJzOwo+ICsJCX0KPiArCQlyZXQgPSBpM2NfZGV2aWNlX2RvX3hmZXJzKGkz YywgaTNjX3hmZXJzLAo+ICsJCQkJCSAgbWV0YWRhdGEubnhmZXJzLCBJM0NfU0RSKTsKPiArCQlp ZiAocmV0KSB7Cj4gKwkJCXByaW50X2kzY19lcnIoaTNjZGV2LCAmbWV0YWRhdGEsIGkzY194ZmVy cyk7Cj4gKwkJCWdvdG8gb3V0X2ZyZWVfaTNjX3hmZXJzOwo+ICsJCX0KPiArCX0KCltTZXZlcml0 eTogTWVkaXVtXQpBcyBpbiB0aGUgcmVhZC93cml0ZSBwYXRocywgZG9lcyB0aGlzIGFsc28gaW1w cm9wZXJseSBtaXggc2NvcGVkX2d1YXJkKCkKd2l0aCBnb3RvIGxhYmVscyBpbiB0aGUgaW9jdGwg aGFuZGxlcj8KClsgLi4uIF0KCj4gK3N0YXRpYyBpbnQgaTNjZGV2X3Byb2JlKHN0cnVjdCBpM2Nf ZGV2aWNlICppM2MpCj4gK3sKClsgLi4uIF0KCj4gKwlpM2NkZXYtPmRldi5wYXJlbnQgPSBpM2Nf ZGV2aWNlX2RldjsKPiArCWkzY2Rldi0+ZGV2LmRldnQgPSBpM2NkZXYtPmRldnQ7Cj4gKwlpM2Nk ZXYtPmRldi5jbGFzcyA9ICZpM2NkZXZfY2xhc3M7Cj4gKwlpM2NkZXYtPmRldi5yZWxlYXNlID0g ZnJlZV9pM2NkZXZfZGF0YTsKPiArCXJldCA9IGRldl9zZXRfbmFtZSgmaTNjZGV2LT5kZXYsIFNZ U0ZTX0ZPUk1BVCwgTUlOT1IoaTNjZGV2LT5kZXZ0KSk7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8g ZXJyb3JfZnJlZV9pZGE7CgpbU2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyB0aGlzIGVycm9yIHBhdGgg bGVhayB0aGUgaTNjZGV2IG1lbW9yeSBzdHJ1Y3R1cmUgYW5kIGxlYXZlIGFuCnVuYmFsYW5jZWQg cmVmZXJlbmNlIGNvdW50IG9uIHRoZSB1bmRlcmx5aW5nIEkzQyBkZXZpY2U/CgpJZiBkZXZfc2V0 X25hbWUoKSBmYWlscywgZXhlY3V0aW9uIGp1bXBzIGRpcmVjdGx5IHRvIGVycm9yX2ZyZWVfaWRh LCBza2lwcGluZwp0aGUgcmVsZWFzZSBvZiBpM2NkZXYgbWVtb3J5IGFuZCB0aGUgZGV2aWNlIHJl ZmVyZW5jZSBhY3F1aXJlZCBlYXJsaWVyIGluCnByb2JlLiBTaG91bGQgdGhpcyBpbnN0ZWFkIGNh bGwgcHV0X2RldmljZSgmaTNjZGV2LT5kZXYpIHNvIHRoYXQKZnJlZV9pM2NkZXZfZGF0YSBpcyBl eGVjdXRlZCB0byBoYW5kbGUgdGhlIGNsZWFudXAgcHJvcGVybHk/CgpbIC4uLiBdCgo+ICsJc2Nv cGVkX2d1YXJkKG11dGV4LCAmaTNjZGV2LT5sb2NrKSB7Cj4gKwkJcmV0ID0gY2Rldl9kZXZpY2Vf YWRkKCZpM2NkZXYtPmNkZXYsICZpM2NkZXYtPmRldik7Cj4gKwkJaWYgKHJldCkKPiArCQkJZ290 byBlcnJvcl9jbGVhbnVwOwo+ICsKPiArCQlpM2NkZXYtPmJvdW5kID0gdHJ1ZTsKPiArCX0KCltT ZXZlcml0eTogTWVkaXVtXQpEb2VzIHRoaXMgc2VxdWVuY2UgbWl4IHNjb3BlZF9ndWFyZCgpIHdp dGggYSBnb3RvIGVycm9yIGNsZWFudXAgbGFiZWw/CgpBcyB3aXRoIHRoZSBvdGhlciBmdW5jdGlv bnMgaW4gdGhpcyBwYXRjaCwgdGhpcyBtaXhlcyBzY29wZWQgY2xlYW51cCB3aXRoCmdvdG8gc3Rh dGVtZW50cywgd2hpY2ggZ29lcyBhZ2FpbnN0IHRoZSBWRlMvY2xlYW51cCBndWlkZWxpbmVzLgoK LS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8y MDI2MDkxMTIxMDkzNS4xMzUzMTI2LTEtbWVhZ2FubGxveWRAbGludXgubWljcm9zb2Z0LmNvbT9w YXJ0PTMKCi0tIApsaW51eC1pM2MgbWFpbGluZyBsaXN0CmxpbnV4LWkzY0BsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt aTNjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1DE94BA1FC for ; Fri, 11 Sep 2026 21:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789161704; cv=none; b=fLxc2LbDOx5m0idQnmzT9o1KHtYm/StgRtrPdeptxeUNNYvAZqSahaPmNDTNelHdhORF9o0Ag9lF4TBFT5FZYxdzLFj8UhzoFkruvLtbkK972ZqNYVs9ZZqGqqqfp/Z7nOLvN9mC2PcjLcfvPenrAWFDXnEspbk6zszEX6vU/5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789161704; c=relaxed/simple; bh=MvzV/Tv6v0vMrEkQEhaJjBQGaQkETc0b36m6FYYas0A=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=ILGdCao7Kj8wwiXE/CCmvmpyRcSk87rttNkku9iwyfawRrN9V1/SEGiaBlHuUaUl3Ztd9oduBbgQgkXEbYCPrgKhOHs7T+1Us6d5n4jpAMb62NFBvmPeV93Pg+qsFuFrU3+plWdWi9xYiwc/lQcqYoxaPLufrOgoLxvinOUCmHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VHzu+CC1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VHzu+CC1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 535861F000FF; Fri, 11 Sep 2026 21:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789161702; bh=r4E8k96H7dpGkRg9V///RyiymeywzlTi8LMpRuYA+GQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VHzu+CC16J405OCwOpj0lnMId5mYykqyI+hOZY2paehAWj8o1kWn2PZZ8NmQ3s62G ah0w+3jvoLSNvMduxYsMiKYuqZ8S8Cr/0C3Tbn8DMx0F5nsOVtogDw6Db2M7OKozMg Qnd2v4Bd2sNO76bpoDqXMCPO5WbgOeE7dnDu9II1CHXdmmn++jzHoBvyeGASQO8H8r zJApgPcUQ5DqRR7QmqUb7rTDuB2zJgvBrvLNBhoW/FuD4+q+IQyKFTTLDkwXLp0spB +rjICf6zGGunCbyF2s5AkVUsXwt/+O7+kj86DMxRcC4ahztXdncqqkOVJZ6p/3uHpi 0ReyHfGzkx/Yw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] i3c: add i3cdev character device module for user-space access Reply-To: sashiko-reviews@lists.linux.dev To: "Meagan Lloyd" Cc: linux-hwmon@vger.kernel.org, Frank.Li@kernel.org, linux-i3c@lists.infradead.org, "Alexandre Belloni" In-Reply-To: <20260911210935.1353126-4-meaganlloyd@linux.microsoft.com> References: <20260911210935.1353126-1-meaganlloyd@linux.microsoft.com> <20260911210935.1353126-4-meaganlloyd@linux.microsoft.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 11 Sep 2026 21:21:41 +0000 Message-Id: <20260911212142.535861F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [Medium] Max Write Length (MWL) check is bypassed in `i3cdev_write` due t= o uninitialized length field. - [Medium] Mixing goto-based error handling and `scoped_guard()` declaratio= ns in the same function violates the cleanup subsystem guidelines. - [Medium] Memory and reference count leak on the `dev_set_name()` error pa= th in `i3cdev_probe()`. - [Medium] Un-ratelimited kernel logging in `print_i3c_err` allows unprivil= eged users to flood dmesg. -- commit 691a30342eecac1b5bf88181bfab4ade443f2923 Author: Meagan Lloyd Subject: i3c: add i3cdev character device module for user-space access This commit introduces a character device driver for I3C devices. It allows user-space applications to perform basic SDR reads and writes by binding devices manually via sysfs driver_override. > diff --git a/drivers/i3c/i3cdev.c b/drivers/i3c/i3cdev.c > new file mode 100644 > index 0000000000000..da0e6910a4f72 > --- /dev/null > +++ b/drivers/i3c/i3cdev.c [ ... ] > +static ssize_t > +i3cdev_read(struct file *file, char __user *buf, size_t count, loff_t *f= _pos) > +{ [ ... ] > + scoped_guard(mutex, &i3cdev->lock) { > + /* .remove was called so don't mess with the device */ > + if (!i3cdev->bound) { > + ret =3D -ENXIO; > + goto out_free_kbuf; > + } > + > + ret =3D i3c_device_do_xfers(i3c, &xfer, 1, I3C_SDR); > + if (ret) > + goto out_free_kbuf; > + } [Severity: Medium] Does this mix goto-based error handling with scoped_guard() in the same function? The VFS/cleanup guidelines indicate that mixing goto-based error labels with scope-based cleanups like scoped_guard() creates confusing ownership semant= ics and increases the risk of double-free or resource leaks. Since the function uses a goto label for freeing the memory buffer out_free_kbuf, could we either convert the buffer to use a scope-based __free() or use traditional mutex lock/unlock operations? [ ... ] > +static ssize_t > +i3cdev_write(struct file *file, const char __user *buf, size_t count, > + loff_t *f_pos) > +{ > + struct i3cdev_data *i3cdev =3D file->private_data; > + struct i3c_device *i3c =3D i3cdev->i3c; > + struct i3c_xfer xfer =3D { > + .rnw =3D I3C_WRITE > + }; > + size_t len; > + char *tmp; > + int ret; > + > + if (!i3cdev->bound) > + return -ENXIO; > + > + /* File system operation of 0 bytes is effectively a valid, no-op */ > + if (!count) > + return 0; > + > + if (exceeds_mwl(i3cdev, &xfer)) > + return -ENXIO; > + > + /* Clamp transfer length within driver limits */ > + len =3D min(count, MAX_TOTAL_DATA_BYTES); > + xfer.len =3D len; [Severity: Medium] Is the Max Write Length (MWL) check bypassed here due to an uninitialized length field? At the point where exceeds_mwl() is called, xfer.len is 0 because only .rnw was initialized in the struct declaration. The actual xfer.len is assigned after the check, meaning the MWL validation will always pass regardless of = the requested size. This could allow hardware to receive writes exceeding its supported maximum length. Should the length clamp and assignment happen bef= ore the validation check? [ ... ] > + scoped_guard(mutex, &i3cdev->lock) { > + /* .remove was called so don't mess with the device */ > + if (!i3cdev->bound) { > + ret =3D -ENXIO; > + goto out_free_kbuf; > + } > + > + ret =3D i3c_device_do_xfers(i3c, &xfer, 1, I3C_SDR); > + if (ret) > + goto out_free_kbuf; > + } [Severity: Medium] Similar to i3cdev_read(), does this mix goto-based error handling with scoped_guard() in the write path? [ ... ] > +static void print_i3c_err(struct i3cdev_data *i3cdev, > + struct i3cdev_xfers *metadata, > + struct i3c_xfer *i3c_xfers) > +{ > + for (int i =3D 0; i < metadata->nxfers; i++) { > + /* Valid errors, e.g. M0 (now called C0) start at 1 */ > + if (i3c_xfers[i].err > 0) { > + dev_warn(&i3cdev->dev, > + "I3C error encountered: C%u\n", > + i3c_xfers[i].err - 1); > + return; > + } > + } > +} [Severity: Medium] Could this un-ratelimited kernel logging allow unprivileged users to flood the dmesg log? Since this error is triggered directly by user-supplied transfers via the ioctl interface, a user-space application could repeatedly trigger hardware errors to intentionally spam the kernel logs. Could we use a rate-limited variant like dev_warn_ratelimited() here to prevent a potential local DoS? [ ... ] > +static int > +i3cdev_ioctl_do_xfers(struct i3cdev_data *i3cdev, > + struct i3cdev_xfers __user *uxfers) > +{ [ ... ] > + scoped_guard(mutex, &i3cdev->lock) { > + /* .remove was called so don't mess with the device */ > + if (!i3cdev->bound) { > + ret =3D -ENXIO; > + goto out_free_i3c_xfers; > + } > + ret =3D i3c_device_do_xfers(i3c, i3c_xfers, > + metadata.nxfers, I3C_SDR); > + if (ret) { > + print_i3c_err(i3cdev, &metadata, i3c_xfers); > + goto out_free_i3c_xfers; > + } > + } [Severity: Medium] As in the read/write paths, does this also improperly mix scoped_guard() with goto labels in the ioctl handler? [ ... ] > +static int i3cdev_probe(struct i3c_device *i3c) > +{ [ ... ] > + i3cdev->dev.parent =3D i3c_device_dev; > + i3cdev->dev.devt =3D i3cdev->devt; > + i3cdev->dev.class =3D &i3cdev_class; > + i3cdev->dev.release =3D free_i3cdev_data; > + ret =3D dev_set_name(&i3cdev->dev, SYSFS_FORMAT, MINOR(i3cdev->devt)); > + if (ret) > + goto error_free_ida; [Severity: Medium] Does this error path leak the i3cdev memory structure and leave an unbalanced reference count on the underlying I3C device? If dev_set_name() fails, execution jumps directly to error_free_ida, skippi= ng the release of i3cdev memory and the device reference acquired earlier in probe. Should this instead call put_device(&i3cdev->dev) so that free_i3cdev_data is executed to handle the cleanup properly? [ ... ] > + scoped_guard(mutex, &i3cdev->lock) { > + ret =3D cdev_device_add(&i3cdev->cdev, &i3cdev->dev); > + if (ret) > + goto error_cleanup; > + > + i3cdev->bound =3D true; > + } [Severity: Medium] Does this sequence mix scoped_guard() with a goto error cleanup label? As with the other functions in this patch, this mixes scoped cleanup with goto statements, which goes against the VFS/cleanup guidelines. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260911210935.1353= 126-1-meaganlloyd@linux.microsoft.com?part=3D3