From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83642357CE0 for ; Fri, 11 Sep 2026 22:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789164022; cv=none; b=rJlGrrZARLlotJGWho66o82D1zzROCRYpOdzjdJdOLSi6ajVA6vOKUrFvtGMKBCSYn7RcDWtD7SsK0ILpIZj5b2emSNaLbX5Fz9p39YM5KmrMLMsE6QNcKRXV/ffbLER5s1I3It6gvcpu3Ru+B713mo8xNeei3grJ2AOYVmheIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789164022; c=relaxed/simple; bh=aZe+Buxts3YECMKdwDYo5Yg87/d4z8fNsUMSyu/czJo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U7LySTmgH7t9zDq4oNO2Z1o1NZXwNLpqYEFWIpRQYuJyOMHqBIv0cSpcOtKY3yAIvtGd3yu4RYpH+N2KhtCxIEBdlokgeurqApb9VxlJm4qoB/eTrsd4vO9vWaI0hsWbLL6R6Yum2Qihhii0dJNppNTULiDW7CwZhEqEJEevmvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VxC/4Coo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VxC/4Coo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B4811F00898; Fri, 11 Sep 2026 22:00:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789164021; bh=ZV7peg1AqpD89/O1QXp5FYDJKrq4+uwxM7ax4aNAx/Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VxC/4CooGco80aYwJ7PqMvQ6t69J6JtvPcIREFs+dau63d6jBygsVaWaBrBsyW8A/ 6m8lgeHBQHsp1mNRQleH8eKAn7yUASRtvydRC94vmzEm/uDio3SZTdBH2wGc6+3uPO vEQc6ZXDQPo01zGfUTcFoMBHrjF71XcE6we7natK5mSI+6gf5V84yv54mS7J3S4v6E cDk1nPiIn9hwX52uVCmrc5Urh85ZCVkgA6Fwp8xb/7Bhu0kO+ldCnYmmKROXgzdTkx Jyb3F2FI5sMwpKGrmJ8hi9OUf64qAsw0p0v+rx45coX8Yf923H7TEdEDdGyMltnrmp Y6PL/nks9dsCA== From: Sasha Levin To: stable@vger.kernel.org Cc: Chao Yu , stable@kernel.org, Daeho Jeong , Jaegeuk Kim , Sasha Levin Subject: [PATCH 6.18.y 2/2] f2fs: fix to reclaim space in f2fs_allocate_pinning_section() Date: Fri, 11 Sep 2026 18:00:18 -0400 Message-ID: <20260911220018.1623522-2-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911220018.1623522-1-sashal@kernel.org> References: <2026090956-broiler-charting-76e8@gregkh> <20260911220018.1623522-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Chao Yu [ Upstream commit fa487f56efba6344aef67d871688f0908fe08af3 ] It needs to trigger checkpoint to free space reclaimed by f2fs_gc_range(), otherwise, fallocate() on pinfile will fail easily even there is slash space in conventional zone. [Testcase] nullblk_create.sh 512 2 1024 1024 mkfs.f2fs /dev/nullb0 -f -m mount /dev/nullb0 /mnt/f2fs/ touch /mnt/f2fs/pinfile f2fs_io pinfile set /mnt/f2fs/pinfile mkdir /mnt/f2fs/dir/ for((i=0;i<3934;i++)) do { dd if=/dev/zero of=/mnt/f2fs/dir/$i bs=1M count=1;} done sync for((i=0;i<3934;i+=2)) do { rm /mnt/f2fs/dir/$i;} done for((i=0;i<1950;i++)) do { rm /mnt/f2fs/dir/$i;} done sync f2fs_io fallocate 0 0 $((1024*1024*1024)) /mnt/f2fs/pinfile sync stat /mnt/f2fs/pinfile f2fs_io fiemap 0 $((1024*1024*1024)) /mnt/f2fs/pinfile [Before] fallocate failed: Resource temporarily unavailable File: /mnt/f2fs/pinfile Size: 109051904 Blocks: 213208 IO Block: 4096 regular file Device: 250,0 Inode: 4 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2026-08-12 20:04:02.264000000 +0800 Modify: 2026-08-12 20:04:26.784000000 +0800 Change: 2026-08-12 20:04:26.784000000 +0800 Birth: - root@localhost:~# root@localhost:~# root@localhost:~# root@localhost:~# f2fs_io fiemap 0 $((1024*1024*1024)) /mnt/f2fs/pinfile Fiemap: offset = 0 len = 1073741824 logical addr. physical addr. length flags 0 0000000000000000 0000000002e00000 0000000000200000 00001000 1 0000000000200000 000000002dc00000 0000000000400000 00001000 2 0000000000600000 000000002e400000 0000000000600000 00001000 3 0000000000c00000 000000007a400000 0000000005c00000 00001001 [After] File: /mnt/f2fs/pinfile Size: 1073741824 Blocks: 2099216 IO Block: 4096 regular file Device: 250,0 Inode: 4 Links: 1 Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root) Access: 2026-08-12 19:47:49.428000000 +0800 Modify: 2026-08-12 19:49:06.808000000 +0800 Change: 2026-08-12 19:49:06.808000000 +0800 Birth: - Fiemap: offset = 0 len = 1073741824 logical addr. physical addr. length flags 0 0000000000000000 0000000002e00000 0000000000200000 00001000 1 0000000000200000 000000003aa00000 0000000000400000 00001000 2 0000000000600000 000000003b400000 0000000000200000 00001000 3 0000000000800000 000000007a200000 0000000005e00000 00001000 4 0000000006600000 0000000002800000 0000000000200000 00001000 5 0000000006800000 0000000003200000 0000000000400000 00001000 6 0000000006c00000 0000000003000000 0000000000200000 00001000 7 0000000006e00000 0000000003600000 0000000037200000 00001000 8 000000003e000000 000000003b200000 0000000000200000 00001000 9 000000003e200000 000000003a800000 0000000000200000 00001000 10 000000003e400000 000000003ae00000 0000000000400000 00001000 11 000000003e800000 000000003b600000 0000000001800000 00001001 Cc: stable@kernel.org Fixes: 9703d69d9d15 ("f2fs: support file pinning for zoned devices") Cc: Daeho Jeong Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim [ adjusted context to retain f2fs_up_write() instead of f2fs_up_write_trace() ] Signed-off-by: Sasha Levin --- fs/f2fs/segment.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 5e2789cd96b5e..8e6bea0a1d64d 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -3388,10 +3388,13 @@ int f2fs_allocate_pinning_section(struct f2fs_sb_info *sbi) err = f2fs_gc_range(sbi, 0, sbi->first_seq_zone_segno - 1, true, ZONED_PIN_SEC_REQUIRED_COUNT); f2fs_up_write(&sbi->gc_lock); - - gc_required = false; - if (!err) + if (err) + return err; + err = f2fs_sync_fs(sbi->sb, 1); + if (!err) { + gc_required = false; goto retry; + } } return err; -- 2.53.0