From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3AA25867FD for ; Fri, 11 Sep 2026 19:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789156782; cv=none; b=JKJkBYve2WKZVnzAkBKm1S74r4bf5BHDEQ8TklW3N+eDyHB5a6C7z7zjMySnVg3unXx0W99WQnyA5Kgm2Tit9kga0hjieyU8KN6xhWlb3BmReOHsK0bubBQnvPZ2LMvffcDvBOviFhagYHbE/MustIn35sNMfwXV002017gujdA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789156782; c=relaxed/simple; bh=6r38gsoatbaTjZOSMjIaUI0mqMc0LJDZbG7QJqlFJXg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sj6jCGBk2uI5YG7YnAaBN5uTEo873u2SKch+H1HHniAdya/nFaYxACNhlweRMTIZ1RLlOR9SnSfF3MnTNMTI0PA8JqyLst0ZoGtMhGtLI4PVdfj+4JcnunzeOgM79P5/5Q+qyR0X2TLljUMonvuCsm9Z649ZuepWhtK1f4iUJB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Hpv0vo1h; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Hpv0vo1h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D3661F0089A; Fri, 11 Sep 2026 19:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789156777; bh=f4CqrYrrjfHKKiSkQGq1/3ovziwLbLl24cBrkTq8UeY=; h=From:To:Cc:Subject:Date:Reply-To; b=Hpv0vo1hKhvIaaxM3OtzfZaASh7ZzPjS9Ohu+tYMYmFSmWPMQN1s/l7xJkNE/LDdG CWDr+lleAzpl631L1sTx7OyK1zJJMep/YAam9QRj6rUh1P3FyfnS93jLgk9WarBcB0 FBvz7+XSL3pfF3QEEG27WPpDyJTo0o7AZy7ymY4M= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2026-89596: forcedeth: fix off-by-one when saving/restoring non-PCI config space Date: Fri, 11 Sep 2026 21:44:45 +0200 Message-ID: <2026091131-CVE-2026-89596-4e2f@gregkh> X-Mailer: git-send-email 2.55.0 Reply-To: , Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=5146; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=eeVNtUWugpV1suwAW+YBPrcJLQwozG8DqlEmKd88fgQ=; b=owGbwMvMwCRo6H6F97bub03G02pJDFlLIrNvHn08LerxptvJs4+rz2XYVSdws93903SxpZK9v r16H3dc6IhlYRBkYpAVU2T5so3n6P6KQ4pehranYeawMoEMYeDiFICJTJFkmJ+dHn1ZKG/a0n0G v2u8Tk9J+ZJwayXDgr5tqm8+C5q898sI6k6Y4D3PZOe/+wA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit From: Greg Kroah-Hartman Description =========== In the Linux kernel, the following vulnerability has been resolved: forcedeth: fix off-by-one when saving/restoring non-PCI config space nv_suspend() and nv_resume() walk the non-PCI configuration space with for (i = 0; i <= np->register_size/sizeof(u32); i++) which runs one iteration too many. saved_config_space is declared as u32 saved_config_space[NV_PCI_REGSZ_MAX/4]; and NV_PCI_REGSZ_VER3 is equal to NV_PCI_REGSZ_MAX (0x604), so on a VER3 device register_size/sizeof(u32) is exactly the array length and the last iteration addresses one element past the end. The element it lands on is np->name_rx[0..3]: saved_config_space[] is followed immediately by char name_rx[IFNAMSIZ + 3], and char needs no padding. Nothing observable is corrupted by that, because nv_request_irq() rewrites name_rx with sprintf() before it is ever passed to request_irq(). The bug is the out-of-bounds access itself, which UBSAN reports and which CONFIG_UBSAN_TRAP=y turns into a trap that aborts the running kernel code, plus an MMIO read and, on resume, an MMIO writel() to base + 0x604, one dword past the range the driver mapped: np->base = ioremap(addr, np->register_size); VER1 and VER2 devices stay inside the array, but they too get the stray read and the stray write one dword past their own window. Caught by UBSAN on an Apple Macmini3,1 (MCP79) during a deep S3 cycle. The splat below is trimmed: the build path in the file name, the CPU and taint lines, the Workqueue line, the "?" hint frames, and the frames below device_suspend are all cut. The kernel was tainted, with an out-of-tree nouveau and CPU_OUT_OF_SPEC; forcedeth itself was the stock module. UBSAN: array-index-out-of-bounds in drivers/net/ethernet/nvidia/forcedeth.c:6225:25 index 385 is out of range for type 'u32 [385]' Call Trace: dump_stack_lvl+0x5d/0x80 ubsan_epilogue+0x5/0x2b __ubsan_handle_out_of_bounds.cold+0x54/0x59 __this_module+0xe398c/0xe9010 [forcedeth] pci_pm_suspend+0x80/0x170 dpm_run_callback+0x51/0x160 device_suspend+0x1a2/0x4a0 ... Both loops are hit. UBSAN reports each source location only once per module load (__ubsan_handle_out_of_bounds() calls suppress_report(), which does test_and_set_bit(REPORTED_BIT, ...) on the struct source_location), so the two splats land in the first S3 cycle after the module is loaded and later cycles are silent even though the access still runs off the end every time. In that first cycle line 6225 is reported from pci_pm_suspend and line 6240 from pci_pm_resume. The same off-by-one was fixed in nv_get_regs() by commit ba9aa134287f ("forcedeth: fix buffer overflow") in 2012; these two loops were missed. The suspend and resume side was reported on LKML in September 2013 by Marc Weber, with the same analysis and the same one-character fix, but the patch was attached rather than sent inline and the thread ended there. Use < instead of <=, which saves and restores exactly register_size bytes. The Linux kernel CVE team has assigned CVE-2026-89596 to this issue. Affected and fixed versions =========================== Issue introduced in 2.6.27 with commit 1a1ca86158eee303af5270338695f90bc7ae02b3 and fixed in 6.12.109 with commit 9379f8527ca60d92715c90b32f1b477de9ec32cb Issue introduced in 2.6.27 with commit 1a1ca86158eee303af5270338695f90bc7ae02b3 and fixed in 6.18.50 with commit 0c3f4544ff3873594c8af1b907b4ac4e6d5ce005 Issue introduced in 2.6.27 with commit 1a1ca86158eee303af5270338695f90bc7ae02b3 and fixed in 7.2.4 with commit c4f196bfeedd71e56aba4b63bd8f919edb2f7056 Issue introduced in 2.6.27 with commit 1a1ca86158eee303af5270338695f90bc7ae02b3 and fixed in 7.3-rc1 with commit 9393f1d656a79693e0c123ff7bc7c5c0f708046d Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2026-89596 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/net/ethernet/nvidia/forcedeth.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/9379f8527ca60d92715c90b32f1b477de9ec32cb https://git.kernel.org/stable/c/0c3f4544ff3873594c8af1b907b4ac4e6d5ce005 https://git.kernel.org/stable/c/c4f196bfeedd71e56aba4b63bd8f919edb2f7056 https://git.kernel.org/stable/c/9393f1d656a79693e0c123ff7bc7c5c0f708046d