From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 201B325A640 for ; Sat, 12 Sep 2026 02:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789178750; cv=none; b=B/P8aB59Fai1qnoi5BuMFG7QZZFikHKm7n/f24W+x0uh4Xxz4mpOaVeAJuHCZnbsVCED1yjy9gFX/pGj5E/cMNWHcszdWmX1qbS5nBDPYrtwMK2kE0TVbyxeON4g11PTORx9dQd9Ksy8/fNYxds0CqHp1rpCvtf8Mco6M8+Usn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789178750; c=relaxed/simple; bh=JwjEdlVYzQzW1NZBGzLmjP3ZT14kyOlQ1eLNAfmIxfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=In0cRW7qBG63igU7ghDb+2h91nrAsFpzqia+7EenePPPhRo5mRqS8Ih6LMCXYR1mTj2/0hYwD+crNXNej2Wyu+xWyfU7vI09DJH6umdbTJ6NC6wQ/5+U9nGA5ksu3LbIFKkbhjbB0VDlfW2w9wje1beXhovpqjq2rqDy2X+sz0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jgDpnChj; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jgDpnChj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF7521F000FF; Sat, 12 Sep 2026 02:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789178748; bh=ZD8WRV03JbnR9tAbpvHNEi470H6SJq+/Pa4IMFur6iE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jgDpnChjlA73fSIjCVcz2hXSkwokA/LHmu0Sbdm5sqsLtUOdhaFk65We56gSd4PhN 3P4HjNtbXsAPkVz1s0/AOqrJoz592X6H2wyVQU96zy3tIPpwjNVwjRDD7cASUTCrb1 ZQJinBzsu/9GueOBPwLf8rfxlVxf9vcxRzFmmyTEobHXIeE0in9tVVAJUWzMe7MQwE EYcy0TYiXvDaGd+63l2H7kIas/eDxfBVHVV9f9dfdpzznsy8ug8oULJ/VPSVE8wJB7 rkCe2bA4lQ5pEIJcyl/xTrlhwCBI49L1SwXOCLXq8GjHw6rrRwssji1XnXOG57V0/d CazMt4b4TSxCQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Daeho Jeong , Sunmin Jeong , Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 7.2.y] f2fs: accurately adjust free_sections during free_segment_range Date: Fri, 11 Sep 2026 22:05:46 -0400 Message-ID: <20260912020546.1948109-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090935-shortness-sheep-ddfc@gregkh> References: <2026090935-shortness-sheep-ddfc@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daeho Jeong [ Upstream commit 8c963d1738fdca400082ff5f9d99e083de4f4e70 ] In free_segment_range(), MAIN_SECS(sbi) is temporarily reduced by `secs` to restrict block allocation to the safe remaining main area while valid blocks in the truncated range are evacuated by GC. However, FREE_I(sbi)->free_sections tracks the total number of free sections across the whole filesystem. If any sections within the truncated range were already free upon entering free_segment_range(), failing to deduct them from free_sections causes the filesystem to overestimate available free sections in the active, reduced main area. This leads to inconsistent free section accounting during GC data migration and can trigger unexpected allocation failures or assertion errors when space is tight. Fix this by calculating the number of already-free sections in the truncated range, deducting them from free_sections upon entering free_segment_range(), and restoring them on exit. Fixes: b4b10061ef98 ("f2fs: refactor resize_fs to avoid meta updates in progress") Cc: stable@vger.kernel.org Signed-off-by: Daeho Jeong Signed-off-by: Sunmin Jeong Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim [ retained gc_mode and gc_type declarations needed by the older inline GC reset logic. ] Signed-off-by: Sasha Levin --- fs/f2fs/gc.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 1eda818619747..750cf46721c13 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -2194,8 +2194,9 @@ int f2fs_gc_range(struct f2fs_sb_info *sbi, static int free_segment_range(struct f2fs_sb_info *sbi, unsigned int secs, bool dry_run) { - unsigned int next_inuse, start, end; + unsigned int secno, next_inuse, start, end, end_secno; struct cp_control cpc = { CP_RESIZE, 0, 0, 0 }; + unsigned int freed_secs = 0; int gc_mode, gc_type; int err = 0; int type; @@ -2204,6 +2205,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi, MAIN_SECS(sbi) -= secs; start = MAIN_SECS(sbi) * SEGS_PER_SEC(sbi); end = MAIN_SEGS(sbi) - 1; + end_secno = GET_SEC_FROM_SEG(sbi, end); mutex_lock(&DIRTY_I(sbi)->seglist_lock); for (gc_mode = 0; gc_mode < MAX_GC_POLICY; gc_mode++) @@ -2215,6 +2217,14 @@ static int free_segment_range(struct f2fs_sb_info *sbi, sbi->next_victim_seg[gc_type] = NULL_SEGNO; mutex_unlock(&DIRTY_I(sbi)->seglist_lock); + spin_lock(&FREE_I(sbi)->segmap_lock); + for (secno = MAIN_SECS(sbi); secno <= end_secno; secno++) { + if (!test_bit(secno, FREE_I(sbi)->free_secmap)) + freed_secs++; + } + FREE_I(sbi)->free_sections -= freed_secs; + spin_unlock(&FREE_I(sbi)->segmap_lock); + /* Move out cursegs from the target range */ for (type = CURSEG_HOT_DATA; type < NR_CURSEG_TYPE; type++) { err = f2fs_allocate_segment_for_resize(sbi, type, start, end); @@ -2239,6 +2249,9 @@ static int free_segment_range(struct f2fs_sb_info *sbi, f2fs_bug_on(sbi, 1); } out: + spin_lock(&FREE_I(sbi)->segmap_lock); + FREE_I(sbi)->free_sections += freed_secs; + spin_unlock(&FREE_I(sbi)->segmap_lock); MAIN_SECS(sbi) += secs; return err; } -- 2.53.0