Re: [PATCH] perf thread_map: Deduplicate numerically equivalent PID and TID strings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing explicit inclusion of <stdio.h> for snprintf.
--

commit b1526ce24c053489c0a3385a95c4492a0906a746
Author: Hui Su <sh_def@163.com>

perf thread_map: Deduplicate numerically equivalent PID and TID strings

This commit replaces the ineffective prev_pid and prev_tid checks with an
intlist seen-set to correctly deduplicate numerically equivalent PID and TID
strings. It also adds new test cases to verify this behavior.

> diff --git a/tools/perf/tests/thread-map.c b/tools/perf/tests/thread-map.c
> index 877868107455e..0299c8fd0a6a9 100644
> --- a/tools/perf/tests/thread-map.c
> +++ b/tools/perf/tests/thread-map.c
> @@ -56,6 +56,39 @@ static int test__thread_map(struct test_suite *test __maybe_unused, int subtest

[ ... ]

> +	/* test numeric deduplication of PIDs */
> +	{
> +		struct perf_thread_map *base, *dup;
> +		char pid_str[64];
> +
> +		base = thread_map__new_by_pid(getpid());
> +		TEST_ASSERT_VAL("failed to alloc baseline map", base);
> +
> +		snprintf(pid_str, sizeof(pid_str), "%d,0%d", getpid(), getpid());

[Severity: Low]
Does test__thread_map() in tools/perf/tests/thread-map.c need an explicit
include of <stdio.h> for snprintf?

The global review guidelines mandate explicit inclusion of POSIX standard
headers for all libc functions to ensure musl libc compatibility, preventing
reliance on implicit inclusion. Since this introduces a new call to snprintf,
strict libc implementations like musl may fail to compile without the direct
header inclusion.

> +
> +		dup = thread_map__new_str(pid_str, NULL, false);
> +		TEST_ASSERT_VAL("failed to alloc duplicate pid map", dup);
> +		TEST_ASSERT_VAL("wrong nr for duplicate PIDs",
> +				dup->nr == base->nr);
> +
> +		perf_thread_map__put(dup);
> +		perf_thread_map__put(base);
> +	}
> +
>  	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260912031112.1814574-2-sh_def@163.com?part=1