From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27106367B65; Sat, 12 Sep 2026 19:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242077; cv=none; b=u9dA3yUNAqceSNvY2zuCK9i7k/KUJCr/MfnXz5g4mcsCz4UW6NE0r/eXy4W/5g2X95cuZPHM1k/6cUtHV9f6za+ha8MfRRyD5ixKjTWC1Ex/0I9spoRQuBNSMwk/NLXzoreOAd9XL8U/sauQZ/iyoAhp8wJdQhu2giHMliZZ270= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242077; c=relaxed/simple; bh=k44hIu+9n6OxmHZnfDUoRqzIC40Nv7L0Ig2xKN/TDN4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n0bFL8kIxO9fing2Aev3k3HD8kznwEczraWQh27APBVg7VtPtDr8i+0ApaRwJ/soLYE+OvussoOye1fU9zhkdvQP4bO/O7CjpKTilOCHIaR7fN6XX0D7El/iv7ixLjegnhK1cw65wvX+TIwj4qZAbz46xGRf1BRaoSmNjwgRcD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Oo4JFhmI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Oo4JFhmI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 392121F00893; Sat, 12 Sep 2026 19:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242075; bh=N+HT8ENuH+Y3yJHhA+rEdi8HIqGt93Lz/4Q1SbG/0ic=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Oo4JFhmI7e1n1nCkptl2sr6ePWfBeuwrdM6L2onIdzO4Vm0g0K0AhXz5X0UwZ7rG3 tU6KLpWt9TdpfaeYuvF9GqKBSDgVLQtbBLnoqOtPMRSE8auAKY2n6qyuU6LcccXPWi JZrRSAey2rKyfcjrVEDFGgib/epQ6htI2DFHiawY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+a11c46f37ee083a73deb@syzkaller.appspotmail.com, Fedor Pchelkin , Diego Fernando Mancera Gomez , Hans Verkuil Subject: [PATCH 5.10 276/798] media: em28xx: defer audio-only extension registration Date: Sat, 12 Sep 2026 08:58:24 +0200 Message-ID: <20260912065523.483737003@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Diego Fernando Mancera Gomez commit 95f76f51937fdfb0fc1e14cae606b1ef574a56f3 upstream. The audio-only path registers extensions while probing the primary device. For a dual-TS board, this happens before dev_next is created. The duplicate device inherits is_audio_only and is then independently inserted into em28xx_devlist. The list is intended to contain only primary devices: extension operations reach the secondary device through dev_next. The independently linked secondary can be freed during disconnect while its list node remains reachable, resulting in a use-after-free. Defer audio-only extension registration to the module-request work item. It runs only after probing has completed construction of the optional secondary device, so only the primary is registered and extension callbacks reach the secondary through dev_next. Fixes: 4a089668ef22 ("media: em28xx-cards: rework the em28xx probing code") Cc: stable@vger.kernel.org Reported-by: syzbot+a11c46f37ee083a73deb@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/66ec3c83.050a0220.29194.002f.GAE@google.com/T/ Suggested-by: Fedor Pchelkin Signed-off-by: Diego Fernando Mancera Gomez Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/em28xx/em28xx-cards.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/media/usb/em28xx/em28xx-cards.c +++ b/drivers/media/usb/em28xx/em28xx-cards.c @@ -3351,6 +3351,7 @@ static void request_module_async(struct * intf. Don't register extensions twice on those devices. */ if (dev->is_audio_only) { + em28xx_init_extension(dev); #if defined(CONFIG_MODULES) && defined(MODULE) request_module("em28xx-alsa"); #endif @@ -3579,8 +3580,6 @@ static int em28xx_init_dev(struct em28xx retval = -ENODEV; goto err_deinit_media; } - em28xx_init_extension(dev); - return 0; }