From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61C7833F59A; Sat, 12 Sep 2026 13:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789220038; cv=none; b=brX3xrlguFuuslS0a57XD/TV6oh5Zc/Fe9CnLw1Cupa0D7EopsM2MI4ZJUaiOpITFmhTUWD1qqMlUkN0IctMc+7qzyOlMZ+8vm+vFgrAoKjNldYPV1wTcSqh9CWz2LaAB/ZY0LaaiAFBolSRNnzXiSItZ/86+kiP+RVgUoBezj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789220038; c=relaxed/simple; bh=L//F/OjVPki6o8xx/T7xjYPO/YvkDiHnNRQhQxRB+Fg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SJ9AibrU5Q/dVPdcqv4XUs8KNSz3QJ+7WKF/nstBt4isDPdNMazDccWwqJckl3hoyryyZN+Siz/Oq+IjJFu/UzEQKKHCEFfIBu5kRkPuajAoOpcpJ+9MCt3ZolSLVgInKgtwpvn4Pxvz52eCtSBnBgjStywSriDuFncQxGX3aKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=luLakxHU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="luLakxHU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D88561F000FF; Sat, 12 Sep 2026 13:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789220037; bh=L6VjeIYn0H5hLLklK/cUoIt+yG/ZU0KR+YE4G2tf4N4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=luLakxHU7UIj8HIUx7Yj4o4xE8vOdC6uorsXi6py5RytDLufmj/quLC3kzyrIrX8W QtFsqnHeWcu2hmVVzqmrA6RHsWFkWVTNRTpWK7jYZUYj+45ZMmeFukwamK23erLE98 qIO4IFRg+gzPUZjzbWSw/8cMHIhSCHWFBddhedfk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yichong Chen , Tyler Hicks Subject: [PATCH 6.6 0095/1424] ecryptfs: hold msg ctx list lock when cleaning daemon queue Date: Sat, 12 Sep 2026 08:42:07 +0200 Message-ID: <20260912065609.433784796@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yichong Chen commit 779972513c2fa8c7938e54976f686091dafff22f upstream. ecryptfs_exorcise_daemon() drops queued messages from a dying daemon without holding ecryptfs_msg_ctx_lists_mux, but ecryptfs_msg_ctx_alloc_to_free() requires that lock. Take the list lock while moving the queued contexts back to the free list to avoid racing with other global msg ctx list users. Fixes: f66e883eb618 ("eCryptfs: integrate eCryptfs device handle into the module.") Cc: Signed-off-by: Yichong Chen Signed-off-by: Tyler Hicks Signed-off-by: Greg Kroah-Hartman --- fs/ecryptfs/messaging.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/ecryptfs/messaging.c +++ b/fs/ecryptfs/messaging.c @@ -165,6 +165,7 @@ int ecryptfs_exorcise_daemon(struct ecry mutex_unlock(&daemon->mux); goto out; } + mutex_lock(&ecryptfs_msg_ctx_lists_mux); list_for_each_entry_safe(msg_ctx, msg_ctx_tmp, &daemon->msg_ctx_out_queue, daemon_out_list) { list_del(&msg_ctx->daemon_out_list); @@ -173,6 +174,7 @@ int ecryptfs_exorcise_daemon(struct ecry "the out queue of a dying daemon\n", __func__); ecryptfs_msg_ctx_alloc_to_free(msg_ctx); } + mutex_unlock(&ecryptfs_msg_ctx_lists_mux); hlist_del(&daemon->euid_chain); mutex_unlock(&daemon->mux); kfree_sensitive(daemon);