From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 084043BE175; Sat, 12 Sep 2026 07:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789196894; cv=none; b=r958WxQ8AhR1n4asdE8y/YctYYFwP0vDgiJw+im7Rne+Qjdb1pAw1mYVAXak9FOuWLLtWRN8ExbdbXP8oJc0GWepRKtw0V+x4Z9QBLhkF/YUYir5XWlnopg7SzwQ2vL/QHhcbnzsw3lb6oPBnjF16snVsdd9m+Xf3Ag7J7NWlPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789196894; c=relaxed/simple; bh=6GYED1SETADOgmcDz6iE/PTfMxyCd7NXH7DKj21LL6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ubvkCE9NuQCMEO66H140p42PlPfm2NkgRS8BJhke/7qipd5Pn9Bgy5nDLrLqsZOKc3PhSa2O+y3jgSC8zZjJkm3IZqhUxg6U8wtU0oUGEWID4i965HZiOMhowKI73oySSSyGEKybkiLsU9kXr59tHsEVYi91VywxdMtfxf44BiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FnyQX2cx; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FnyQX2cx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAE0A1F000FF; Sat, 12 Sep 2026 07:08:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789196892; bh=PyVxryiK0a836V3wUv6EWiALyfx3NqK5UljYynvwI0o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FnyQX2cxYYHqWEUSwn8M5EIjj23w4e7gWWAfXqGomfypPe65c4ueo9gN9zJD94KJi +GqboX4J/yBaK2Ua+uiKRDn5zLTkDvPx+8oJ+Oxx7HZYIME4WpsJx70CVRVp7mraa3 T3ORx7yH1XAyv8HTM6U1EdAf1Wpfsyj6PRjzPs1I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Konstantin Andreev , Casey Schaufler , Sasha Levin Subject: [PATCH 7.2 0059/1815] smack: restrict smackfs/{direct,mapped} values to 0-255 Date: Sat, 12 Sep 2026 08:30:09 +0200 Message-ID: <20260912065650.398352903@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065648.999753832@linuxfoundation.org> References: <20260912065648.999753832@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Konstantin Andreev [ Upstream commit a7c44fd9f80e37763acf9cd3c87a58058d206427 ] Both smackfs/direct and smackfs/mapped incorrectly accept the full range of integer values. For example: # cd /sys/fs/smackfs/ # cat direct ; echo 250 # cat cipso2 @ 250/2 _ 250/2,4,5,6,7,8 * 250/3,5,7 ^ 250/2,4,5,6,7 ? 250/3,4,5,6,7,8 # echo -1234 >direct ; cat direct ; echo -1234 # cat cipso2 @ -1234/2 _ -1234/2,4,5,6,7,8 * -1234/3,5,7 ^ -1234/2,4,5,6,7 ? -1234/3,4,5,6,7,8 # I noticed two things regarding this: 1) sensitivity levels are truncated to 8 bits when labeling outgoing packets (0x2e = 46 for the -1234 example above) 2) the reverse process fails: incoming packets with sensitivity level 46 do not match these smackfs/cipso2 entries. Even observation (1) on its own warrants a fix. This patch restricts smackfs/direct and smackfs/mapped accepted values to the 0-255 range. Fixes: e114e473771c ("Smack: Simplified Mandatory Access Control Kernel") Signed-off-by: Konstantin Andreev Signed-off-by: Casey Schaufler Signed-off-by: Sasha Levin --- security/smack/smack.h | 2 +- security/smack/smackfs.c | 26 ++++++++++++++------------ 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/security/smack/smack.h b/security/smack/smack.h index 6febc2ecdfe84..fe6a498200143 100644 --- a/security/smack/smack.h +++ b/security/smack/smack.h @@ -317,7 +317,7 @@ int smack_populate_secattr(struct smack_known *skp); * Shared data. */ extern int smack_enabled __initdata; -extern int smack_cipso_auto_level[2]; +extern u8 smack_cipso_auto_level[2]; #define smack_cipso_direct (+smack_cipso_auto_level[0]) #define smack_cipso_mapped (+smack_cipso_auto_level[1]) extern struct smack_known *smack_net_ambient; diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 946405645d5ad..c7eae7c6427ff 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -94,7 +94,7 @@ struct smack_known *smack_net_ambient; * secid is contained directly in the category set. * It can be reset via smackfs/mapped */ -int smack_cipso_auto_level[2] = { +u8 smack_cipso_auto_level[2] = { SMACK_CIPSO_DIRECT_DEFAULT, SMACK_CIPSO_MAPPED_DEFAULT, }; @@ -1641,17 +1641,15 @@ static const struct file_operations smk_doi_ops = { static ssize_t smk_read_cipso_auto_level(struct file *filp, char __user *buf, size_t count, loff_t *ppos) { - char temp[80]; - ssize_t rc; + char temp[sizeof "255"]; + int n; if (*ppos != 0) return 0; - sprintf(temp, "%d", smack_cipso_auto_level[ - smk_cipso_auto_level_idx(filp)]); - rc = simple_read_from_buffer(buf, count, ppos, temp, strlen(temp)); - - return rc; + n = sprintf(temp, "%u", (unsigned int)smack_cipso_auto_level[ + smk_cipso_auto_level_idx(filp)]); + return simple_read_from_buffer(buf, count, ppos, temp, n); } /** @@ -1667,13 +1665,16 @@ static ssize_t smk_write_cipso_auto_level(struct file *filp, const char __user *buf, size_t count, loff_t *ppos) { - struct smack_known *skp; - int i, ret, idx, old_lvl; + int ret, idx; + u8 i, old_lvl; if (!smack_privileged(CAP_MAC_ADMIN)) return -EPERM; - - ret = kstrtos32_from_user(buf, count, 10, &i); + /* + * draft-ietf-cipso-ipsecurity-01 (CIPSO 2.2), 3.4.2.4: + * "Sensitivity Level is 1 octet in length. Its value is from 0 to 255" + */ + ret = kstrtou8_from_user(buf, count, 10, &i); if (unlikely(ret)) return ret; @@ -1686,6 +1687,7 @@ smk_write_cipso_auto_level(struct file *filp, const char __user *buf, old_lvl = smack_cipso_auto_level[idx]; if (old_lvl != i) { + struct smack_known *skp; mutex_lock(&smack_known_lock); list_for_each_entry_rcu(skp, &smack_known_list, list) if (skp->smk_netlabel.attr.mls.lvl == -- 2.53.0