Re: [PATCH v50 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Mismatch between the commit message and the actual SRAM node labeled in the device tree.
--

commit 6e41c69d46e1780283726744191a5e95f15d0970
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave (ELE) secure-enclave node to the
i.MX8ULP SoC dtsi. It includes a label for the SRAM node referenced by
the enclave and keeps the enclave node disabled by default.

> Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC
> dtsi, together with a label for sram@2201f000 that the node references.

[Severity: Medium]
Is the SRAM address in the commit message accurate? The commit message states
that a label is being added for sram@2201f000, but the actual code change
applies the sram0 label to the node at sram@22010000 instead.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
[ ... ]
> @@ -154,7 +154,7 @@ sosc: clock-sosc {
>  		#clock-cells = <0>;
>  	};
>  
> -	sram@22010000 {
> +	sram0: sram@22010000 {
>  		compatible = "mmio-sram";
>  		reg = <0x0 0x22010000 0x0 0x10000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-imx-se-if-v50-0-80834ef510d3@nxp.com?part=6