From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F3CA2DC321 for ; Sat, 12 Sep 2026 14:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789223027; cv=none; b=WeWpHjkmJs89DJR5fEDTDS/kvUQpDxoL8rKCtqgV/3AmlJyQCjAO4Gnwo8PG7lwyCAnCMfpQUlpNsXK8ZmyOTi+CvEDmr/uF5IDgVsQPcyWYTKGGPNo6S4UpJ9u5H9EHcB+wBWnN6NZKQUPqik4yqUQ2JCMwz95ftOCOk+pfO+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789223027; c=relaxed/simple; bh=VfA47a79+f1af2gISh5Xdk/X6jth3MAkD0RvDbZp7eI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Nip3Oil3MCPIY5/ywk9t8KR7bLfQConHV8u0GBv2yMR6qBeAGCEKY9JYtpM300sYAU89QMQkM7jlUNNndPk3OFVUqEPzYX18LIVQxLWZ+mp0jZZMYtXPjGyS1fS3FQKW/ty82jUzI26iKCjcrzu7yeCEd/S5GYkJPuLPH7HZ5Qk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ds8iXXF6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ds8iXXF6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DC511F000FF; Sat, 12 Sep 2026 14:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789223026; bh=SlhlWNLLJM9mVRmoPIFHbyrXTEZY6Q0bsj5Mb9WF4ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ds8iXXF6i9yodVqJyJmnBqlA8nELwIL5aL2atSoNUsYZAaNepVAhZcehURj1C/8Tv mRRKO2QLRhwZ4mOflm72NP9xDEBp/uHBzjF7N+bRiEQ84cqMKKhOYfpTwVcaYgQGyV wvsQwq+iJ8VVUZgeyINj47dU6qqYJYHOCVWgs3wVZKPwuQ8+TbLcIaoAXkrmKGFPZO QM5XfCN2Na85OxHhN+/57xGjfL6iGk48qlINp47pU+g5yb3CMkCcRfMUnsdIC/S6Hb ZDwWD8gb5ZuZGaC8u1SUp7w7vM4/gunH1Ygk1itrjUjV+g1VtIjTuv60B/APcehAT5 J/fdPkFTdP7wQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Daeho Jeong , Sunmin Jeong , Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 5.10.y] f2fs: accurately adjust free_sections during free_segment_range Date: Sat, 12 Sep 2026 10:23:44 -0400 Message-ID: <20260912142344.2926672-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090938-stress-gallery-d468@gregkh> References: <2026090938-stress-gallery-d468@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Daeho Jeong [ Upstream commit 8c963d1738fdca400082ff5f9d99e083de4f4e70 ] In free_segment_range(), MAIN_SECS(sbi) is temporarily reduced by `secs` to restrict block allocation to the safe remaining main area while valid blocks in the truncated range are evacuated by GC. However, FREE_I(sbi)->free_sections tracks the total number of free sections across the whole filesystem. If any sections within the truncated range were already free upon entering free_segment_range(), failing to deduct them from free_sections causes the filesystem to overestimate available free sections in the active, reduced main area. This leads to inconsistent free section accounting during GC data migration and can trigger unexpected allocation failures or assertion errors when space is tight. Fix this by calculating the number of already-free sections in the truncated range, deducting them from free_sections upon entering free_segment_range(), and restoring them on exit. Fixes: b4b10061ef98 ("f2fs: refactor resize_fs to avoid meta updates in progress") Cc: stable@vger.kernel.org Signed-off-by: Daeho Jeong Signed-off-by: Sunmin Jeong Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim [ adapted the changes to free_segment_range()’s inline GC logic because the newer helper functions are absent. ] Signed-off-by: Sasha Levin --- fs/f2fs/gc.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 379839f5b4b74..1831970b929c2 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1855,8 +1855,9 @@ void f2fs_build_gc_manager(struct f2fs_sb_info *sbi) static int free_segment_range(struct f2fs_sb_info *sbi, unsigned int secs, bool gc_only) { - unsigned int segno, next_inuse, start, end; + unsigned int segno, secno, next_inuse, start, end, end_secno; struct cp_control cpc = { CP_RESIZE, 0, 0, 0 }; + unsigned int freed_secs = 0; int gc_mode, gc_type; int err = 0; int type; @@ -1865,6 +1866,7 @@ static int free_segment_range(struct f2fs_sb_info *sbi, MAIN_SECS(sbi) -= secs; start = MAIN_SECS(sbi) * sbi->segs_per_sec; end = MAIN_SEGS(sbi) - 1; + end_secno = GET_SEC_FROM_SEG(sbi, end); mutex_lock(&DIRTY_I(sbi)->seglist_lock); for (gc_mode = 0; gc_mode < MAX_GC_POLICY; gc_mode++) @@ -1876,6 +1878,14 @@ static int free_segment_range(struct f2fs_sb_info *sbi, sbi->next_victim_seg[gc_type] = NULL_SEGNO; mutex_unlock(&DIRTY_I(sbi)->seglist_lock); + spin_lock(&FREE_I(sbi)->segmap_lock); + for (secno = MAIN_SECS(sbi); secno <= end_secno; secno++) { + if (!test_bit(secno, FREE_I(sbi)->free_secmap)) + freed_secs++; + } + FREE_I(sbi)->free_sections -= freed_secs; + spin_unlock(&FREE_I(sbi)->segmap_lock); + /* Move out cursegs from the target range */ for (type = CURSEG_HOT_DATA; type < NR_CURSEG_PERSIST_TYPE; type++) f2fs_allocate_segment_for_resize(sbi, type, start, end); @@ -1913,6 +1923,9 @@ static int free_segment_range(struct f2fs_sb_info *sbi, f2fs_bug_on(sbi, 1); } out: + spin_lock(&FREE_I(sbi)->segmap_lock); + FREE_I(sbi)->free_sections += freed_secs; + spin_unlock(&FREE_I(sbi)->segmap_lock); MAIN_SECS(sbi) += secs; return err; } -- 2.53.0