From: Tom Rini <trini@konsulko.com>
To: Carlo Caione <ccaione@baylibre.com>
Cc: u-boot@lists.u-boot-project.org,
uboot-stm32@st-md-mailman.stormreply.com,
"Peng Fan" <peng.fan@nxp.com>,
"Jaehoon Chung" <jh80.chung@samsung.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Bastien Curutchet" <bastien.curutchet@bootlin.com>,
"Alexey Charkov" <alchark@gmail.com>,
"Johan Jonker" <jbx6244@gmail.com>,
"Richard Genoud" <richard.genoud@bootlin.com>,
"João Marcos Costa" <joaomarcos.costa@bootlin.com>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"David Lechner" <dlechner@baylibre.com>,
"Julien Stephan" <jstephan@baylibre.com>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>
Subject: Re: [PATCH v2 2/2] spl: mmc: support dynamic selection in raw partition mode
Date: Sat, 12 Sep 2026 08:41:47 -0600 [thread overview]
Message-ID: <20260912144147.GW1764417@bill-the-cat> (raw)
In-Reply-To: <aqUtjQx0haoqjaNq@macbook>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Sat, Sep 12, 2026 at 12:51:42PM +0200, Carlo Caione wrote:
> On Fri, Sep 11, 2026 at 11:41:22 +0100, Tom Rini wrote:
> > On Fri, Sep 11, 2026 at 02:05:59PM +0200, Carlo Caione wrote:
>
> [...]
> > This is better than v1. Did you look in to my suggestion about turning
> > this in to a choice between hard-coded number, hard-coded type and this
> > new dynamic option? I do wonder if that would let us get rid of a lot of
> > the if/else nesting we have in these functions. Thanks!
>
> I'll try but I do not promise anything :) The problem is that it is VERY
> easy to break things when touching this code and relatek Kconfigs so I'm
> basically tiptoeing around it for now, but let me try.
It is tricky, thanks for trying.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-09-12 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 12:05 [PATCH v2 0/2] Support board-selected raw partitions Carlo Caione
2026-09-11 12:05 ` [PATCH v2 1/2] spl: mmc: select the boot partition after device initialization Carlo Caione
2026-09-11 12:05 ` [PATCH v2 2/2] spl: mmc: support dynamic selection in raw partition mode Carlo Caione
2026-09-11 17:41 ` Tom Rini
2026-09-12 10:51 ` Carlo Caione
2026-09-12 14:41 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912144147.GW1764417@bill-the-cat \
--to=trini@konsulko.com \
--cc=alchark@gmail.com \
--cc=bastien.curutchet@bootlin.com \
--cc=ccaione@baylibre.com \
--cc=dlechner@baylibre.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jbx6244@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=joaomarcos.costa@bootlin.com \
--cc=jstephan@baylibre.com \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=richard.genoud@bootlin.com \
--cc=u-boot@lists.u-boot-project.org \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.