Re: [PATCH bpf-next v4 09/15] bpf: Prepare kfunc arguments for the JIT from an ABI description

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment does not follow the required BPF subsystem style.
--

commit 68032f34d921b02fbe1d286d103a8c0c09435a42
Author: Yonghong Song <yonghong.song@linux.dev>

bpf: Prepare kfunc arguments for the JIT from an ABI description

This commit introduces bpf_jit_arg_abi to describe BPF calling
conventions based on architecture-specific rules. It replaces open-coded
argument placement with a generalized approach used by bpf_jit_place_args()
and bpf_jit_plan_arg_moves().

> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index d0066d744ceb9..2a5fa346aadaa 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h

[ ... ]

> @@ -993,6 +993,13 @@ static_assert(__BPF_RET_TYPE_MAX <= BPF_BASE_TYPE_LIMIT);
>   */
>  #define MAX_BPF_FUNC_REG_ARGS 5
>  
> +/* A by-value argument takes two eightbytes at most, so the maximum number of
> + * argument slots of any function is 2 * MAX_BPF_FUNC_ARGS. A local array may
> + * need that size for processing, although eventually the maximum slots will
> + * be capped at MAX_BPF_FUNC_ARGS.
> + */
> +#define MAX_BPF_FUNC_ARG_SLOTS (2 * MAX_BPF_FUNC_ARGS)

[Severity: Low]
This isn't a bug, but does the multi-line comment block above
MAX_BPF_FUNC_ARG_SLOTS follow the required BPF subsystem style? The BPF
subsystem guidelines specify that multi-line comments must have the
opening /* on its own line.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260912195156.980886-1-yonghong.song@linux.dev?part=9