From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: "Oliver Hartkopp" <socketcan@hartkopp.net>,
conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Vincent Mailhol" <mailhol@kernel.org>,
linux-can@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: can: m_can: add ti,am62-mcan compatible
Date: Sat, 12 Sep 2026 21:37:12 +0000 [thread overview]
Message-ID: <20260912213712.96E611F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260912-temp-v5-1-2e3201c02109@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect YAML indentation for the `items` sequence violates the kernel's yamllint rules, breaking `make dt_binding_check`.
--
commit ce14f1f5cb441a60c48d5a3b96ea09ddcd2c9e74
Author: Kendall Willis <k-willis@ti.com>
dt-bindings: can: m_can: add ti,am62-mcan compatible
This commit adds the ti,am62-mcan compatible string to the Bosch M_CAN
device tree bindings. It updates the schema to allow the new TI compatible
as a fallback to the generic Bosch compatible.
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -16,7 +16,11 @@ allOf:
>
> properties:
> compatible:
> - const: bosch,m_can
> + oneOf:
> + - const: bosch,m_can
> + - items:
> + - const: ti,am62-mcan
> + - const: bosch,m_can
[Severity: Low]
Does this indentation in properties.compatible violate the yamllint rules
for device tree bindings?
The configuration in Documentation/devicetree/bindings/.yamllint enforces
an indent-sequences rule with a 2-space indentation requirement. It looks
like the sequence items under the items keyword are placed at 8 spaces,
which matches the column start of the items keyword rather than being
indented to 10 spaces.
Could this formatting violation cause make dt_binding_check to fail during
the build?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-temp-v5-0-2e3201c02109@ti.com?part=1
next prev parent reply other threads:[~2026-09-12 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 21:26 [PATCH v5 0/2] can: m_can: introduce ti,am62-mcan compatible for out-of-band wakeup Kendall Willis
2026-09-12 21:26 ` [PATCH v5 1/2] dt-bindings: can: m_can: add ti,am62-mcan compatible Kendall Willis
2026-09-12 21:37 ` sashiko-bot [this message]
2026-09-13 7:54 ` Krzysztof Kozlowski
2026-09-12 21:26 ` [PATCH v5 2/2] can: m_can: add ti,am62-mcan compatible with out-of-band wakeup support Kendall Willis
2026-09-12 21:35 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912213712.96E611F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=k-willis@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.