From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 100C03314B7 for ; Sat, 12 Sep 2026 14:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789223662; cv=none; b=qnE44kgucUW19vcqhOjcXPA5fiyrQRu8ErwKR5LnvfQVPIJkCmOBsVSthm+o200T/rtWRa3bqwt7B6jybx/AKt0kNLpOr5NE4wO0BEOEDnsrg9pDkqoElC+DmW4wWstTCQ6+1bK/0CcLdwOqjc2S2OwHHxwRIVGtrNYvQC0TIHc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789223662; c=relaxed/simple; bh=tpkly/DPuHlveQsTWd+SoBYT98W/Yh8nOuDIcELP0e8=; h=Date:From:To:Cc:Subject:Message-ID; b=bffLXpPzj8T9ODpmisoJgVSfWCk7goZi2S8PZRYURId28vzf8EJMLAe9q/9FNgajmp3jGocXLVK305fMogzCHrV20NVN+JzfV8uZ2/SpQsB+lVx55dzQZYpdnMci9G3Uo/hhF0uDR40PUueKL1rJzaHkrJhOX9yHMfN9EF6gU+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jAb3K3ZW; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jAb3K3ZW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789223660; x=1820759660; h=date:from:to:cc:subject:message-id; bh=tpkly/DPuHlveQsTWd+SoBYT98W/Yh8nOuDIcELP0e8=; b=jAb3K3ZWThyak+MFVvPwzH/K9rtBhoRfVWj7cWnSQBlXU0RfNoo1HsEa O2uS8YD2/b1h4mRt6NeyOFbs0+nFjG2aBybjcwuWo9f4TJTPKEY//jTx3 wmPoq61WvQCJWEP+WPvZpPSrO5Vwnf3/jPo3uwEKJprmtNOoeL3EnQaTl p/pHtoOrZi9eMzmvvIpSAyuGb+UN4TSjCRh10Mbebk2jNp+EF8nyBHKEB oAY2srxo/1rhOEGk6kunkJD54HCeVwgl/kCzJhpO/mYR+sn02pGWnCC3K iF1k6maom1OahZj+SCsvE3UsBNUGxbdvoYvSFFUh6NgZIW7KrGmCVGTPM g==; X-CSE-ConnectionGUID: vkqcsELsSYSkNnCTBU9iwA== X-CSE-MsgGUID: wrTFQVxZQwmrjhjGzGVitQ== X-IronPort-AV: E=McAfee;i="6800,10657,11903"; a="100320872" X-IronPort-AV: E=Sophos;i="6.27,99,1787036400"; d="scan'208";a="100320872" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Sep 2026 07:34:19 -0700 X-CSE-ConnectionGUID: XHiCClkTT92lB7lqNSW6rw== X-CSE-MsgGUID: w1MrZNHvSDaVJxGXCaBejA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,99,1787036400"; d="scan'208";a="272710173" Received: from lkp-server02.sh.intel.com (HELO 0a3643a6ed9d) ([10.239.97.151]) by orviesa009.jf.intel.com with ESMTP; 12 Sep 2026 07:34:19 -0700 Received: from kbuild by 0a3643a6ed9d with local (Exim 4.98.2) (envelope-from ) id 1x5Onp-000000002z5-3Li9; Sat, 12 Sep 2026 14:34:12 +0000 Date: Sat, 12 Sep 2026 22:33:15 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: drivers/gpu/drm/msm/msm_gem_vma.c:392 msm_gem_vma_new() error: we previously assumed 'obj' could be null (see line 377) Message-ID: <202609122209.bqaOqmiT-lkp@intel.com> User-Agent: s-nail v14.9.25 Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Rob Clark tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 08df884136f1c1197bab2a27814404fd329d9aac commit: c07612365087c8873f3faa2a47642ffa73b12c54 drm/msm: Disallow foreign mapping of _NO_SHARE date: 6 months ago :::::: branch date: 2 days ago :::::: commit date: 6 months ago config: arc-randconfig-r072-20260907 (https://download.01.org/0day-ci/archive/20260912/202609122209.bqaOqmiT-lkp@intel.com/config) compiler: arc-linux-gcc (GCC) 11.5.0 smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: c07612365087 ("drm/msm: Disallow foreign mapping of _NO_SHARE") | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202609122209.bqaOqmiT-lkp@intel.com/ smatch warnings: drivers/gpu/drm/msm/msm_gem_vma.c:392 msm_gem_vma_new() error: we previously assumed 'obj' could be null (see line 377) vim +/obj +392 drivers/gpu/drm/msm/msm_gem_vma.c 7ad0e8cf6317825 Jordan Crouse 2018-11-07 365 da0e1407beb3a40 Rob Clark 2025-06-29 366 /* Create a new vma and allocate an iova for it */ 37889600f58ea55 Rob Clark 2025-06-29 367 struct drm_gpuva * 37889600f58ea55 Rob Clark 2025-06-29 368 msm_gem_vma_new(struct drm_gpuvm *gpuvm, struct drm_gem_object *obj, 2c7ad9925523f64 Rob Clark 2025-06-29 369 u64 offset, u64 range_start, u64 range_end) fc2f07566a2cb19 Rob Clark 2023-03-20 370 { 37889600f58ea55 Rob Clark 2025-06-29 371 struct msm_gem_vm *vm = to_msm_vm(gpuvm); 111fdd2198e63b1 Rob Clark 2025-06-29 372 struct drm_gpuvm_bo *vm_bo; fc2f07566a2cb19 Rob Clark 2023-03-20 373 struct msm_gem_vma *vma; da0e1407beb3a40 Rob Clark 2025-06-29 374 int ret; fc2f07566a2cb19 Rob Clark 2023-03-20 375 c07612365087c88 Rob Clark 2026-03-24 376 /* _NO_SHARE objs cannot be mapped outside of their "host" vm: */ c07612365087c88 Rob Clark 2026-03-24 @377 if (obj && (to_msm_bo(obj)->flags & MSM_BO_NO_SHARE) && c07612365087c88 Rob Clark 2026-03-24 378 GEM_WARN_ON(obj->resv != drm_gpuvm_resv(gpuvm))) { c07612365087c88 Rob Clark 2026-03-24 379 return ERR_PTR(-EINVAL); c07612365087c88 Rob Clark 2026-03-24 380 } c07612365087c88 Rob Clark 2026-03-24 381 fe4952b5f27cca5 Rob Clark 2025-06-29 382 drm_gpuvm_resv_assert_held(&vm->base); fe4952b5f27cca5 Rob Clark 2025-06-29 383 fc2f07566a2cb19 Rob Clark 2023-03-20 384 vma = kzalloc(sizeof(*vma), GFP_KERNEL); fc2f07566a2cb19 Rob Clark 2023-03-20 385 if (!vma) da0e1407beb3a40 Rob Clark 2025-06-29 386 return ERR_PTR(-ENOMEM); fc2f07566a2cb19 Rob Clark 2023-03-20 387 111fdd2198e63b1 Rob Clark 2025-06-29 388 if (vm->managed) { 2c7ad9925523f64 Rob Clark 2025-06-29 389 BUG_ON(offset != 0); 2e6a8a1fe2b262a Rob Clark 2025-06-29 390 BUG_ON(!obj); /* NULL mappings not valid for kernel managed VM */ 057e55f337c5bb2 Rob Clark 2025-06-29 391 ret = drm_mm_insert_node_in_range(&vm->mm, &vma->node, da0e1407beb3a40 Rob Clark 2025-06-29 @392 obj->size, PAGE_SIZE, 0, 2ee4b5d265363f1 Rob Clark 2022-04-11 393 range_start, range_end, 0); 0e08270a1f01bce Sushmita Susheelendra 2017-06-13 394 667ce33e57d0de4 Rob Clark 2016-09-28 395 if (ret) da0e1407beb3a40 Rob Clark 2025-06-29 396 goto err_free_vma; 667ce33e57d0de4 Rob Clark 2016-09-28 397 111fdd2198e63b1 Rob Clark 2025-06-29 398 range_start = vma->node.start; 111fdd2198e63b1 Rob Clark 2025-06-29 399 range_end = range_start + obj->size; 111fdd2198e63b1 Rob Clark 2025-06-29 400 } 111fdd2198e63b1 Rob Clark 2025-06-29 401 2e6a8a1fe2b262a Rob Clark 2025-06-29 402 if (obj) 111fdd2198e63b1 Rob Clark 2025-06-29 403 GEM_WARN_ON((range_end - range_start) > obj->size); 111fdd2198e63b1 Rob Clark 2025-06-29 404 efe927b9702643a Dmitry Baryshkov 2025-08-23 405 struct drm_gpuva_op_map op_map = { efe927b9702643a Dmitry Baryshkov 2025-08-23 406 .va.addr = range_start, efe927b9702643a Dmitry Baryshkov 2025-08-23 407 .va.range = range_end - range_start, efe927b9702643a Dmitry Baryshkov 2025-08-23 408 .gem.obj = obj, efe927b9702643a Dmitry Baryshkov 2025-08-23 409 .gem.offset = offset, efe927b9702643a Dmitry Baryshkov 2025-08-23 410 }; efe927b9702643a Dmitry Baryshkov 2025-08-23 411 3309323241fbb3c Boris Brezillon 2025-08-19 412 drm_gpuva_init_from_op(&vma->base, &op_map); c0ee9794693c1ff Jordan Crouse 2018-11-07 413 vma->mapped = false; 667ce33e57d0de4 Rob Clark 2016-09-28 414 111fdd2198e63b1 Rob Clark 2025-06-29 415 ret = drm_gpuva_insert(&vm->base, &vma->base); 111fdd2198e63b1 Rob Clark 2025-06-29 416 if (ret) 111fdd2198e63b1 Rob Clark 2025-06-29 417 goto err_free_range; da0e1407beb3a40 Rob Clark 2025-06-29 418 2e6a8a1fe2b262a Rob Clark 2025-06-29 419 if (!obj) 2e6a8a1fe2b262a Rob Clark 2025-06-29 420 return &vma->base; 2e6a8a1fe2b262a Rob Clark 2025-06-29 421 111fdd2198e63b1 Rob Clark 2025-06-29 422 vm_bo = drm_gpuvm_bo_obtain(&vm->base, obj); 111fdd2198e63b1 Rob Clark 2025-06-29 423 if (IS_ERR(vm_bo)) { 111fdd2198e63b1 Rob Clark 2025-06-29 424 ret = PTR_ERR(vm_bo); 111fdd2198e63b1 Rob Clark 2025-06-29 425 goto err_va_remove; 111fdd2198e63b1 Rob Clark 2025-06-29 426 } 111fdd2198e63b1 Rob Clark 2025-06-29 427 111fdd2198e63b1 Rob Clark 2025-06-29 428 drm_gpuvm_bo_extobj_add(vm_bo); 111fdd2198e63b1 Rob Clark 2025-06-29 429 drm_gpuva_link(&vma->base, vm_bo); 111fdd2198e63b1 Rob Clark 2025-06-29 430 GEM_WARN_ON(drm_gpuvm_bo_put(vm_bo)); 667ce33e57d0de4 Rob Clark 2016-09-28 431 37889600f58ea55 Rob Clark 2025-06-29 432 return &vma->base; da0e1407beb3a40 Rob Clark 2025-06-29 433 111fdd2198e63b1 Rob Clark 2025-06-29 434 err_va_remove: 111fdd2198e63b1 Rob Clark 2025-06-29 435 drm_gpuva_remove(&vma->base); 111fdd2198e63b1 Rob Clark 2025-06-29 436 err_free_range: 111fdd2198e63b1 Rob Clark 2025-06-29 437 if (vm->managed) 111fdd2198e63b1 Rob Clark 2025-06-29 438 drm_mm_remove_node(&vma->node); da0e1407beb3a40 Rob Clark 2025-06-29 439 err_free_vma: da0e1407beb3a40 Rob Clark 2025-06-29 440 kfree(vma); da0e1407beb3a40 Rob Clark 2025-06-29 441 return ERR_PTR(ret); 667ce33e57d0de4 Rob Clark 2016-09-28 442 } 667ce33e57d0de4 Rob Clark 2016-09-28 443 :::::: The code at line 392 was first introduced by commit :::::: da0e1407beb3a40e1b78418b257b849befb24bc6 drm/msm: Collapse vma allocation and initialization :::::: TO: Rob Clark :::::: CC: Rob Clark -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki