From: sashiko-bot@kernel.org
To: "Alexey Minnekhanov" <alexeymin@minlexx.ru>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/9] dt-bindings: vendor-prefixes: Add Shenzhen Zhuohong Electronic
Date: Sun, 13 Sep 2026 06:31:07 +0000 [thread overview]
Message-ID: <20260913063107.D83681F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260913-nt36672a-panels-v1-2-ce097402c6ea@minlexx.ru>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Vendor prefix mismatch: 'shenchao' mapped to 'Shenzhen Zhuohong Electronic Technology Co., Ltd.'
--
commit 73f96d396aaa9d9d8dc1a660e32b98910c8690b8
Author: Alexey Minnekhanov <alexeymin@minlexx.ru>
dt-bindings: vendor-prefixes: Add Shenzhen Zhuohong Electronic
This commit adds a new vendor prefix to the device tree bindings. It aims
to register Shenzhen Zhuohong Electronic Technology Co., Ltd., a
manufacturer of LCD/IPS displays.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1507,6 +1507,8 @@ patternProperties:
> description: SGX Sensortech
> "^sharp,.*":
> description: Sharp Corporation
> + "^shenchao,.*":
> + description: Shenzhen Zhuohong Electronic Technology Co., Ltd.
[Severity: Low]
Is this vendor prefix mapped to the correct company description?
The patch introduces the 'shenchao' prefix, but maps it to Shenzhen Zhuohong
Electronic Technology Co., Ltd. Since 'shenchao' typically refers to a
Shenchao panel (as seen in a subsequent commit introducing the
'shenchao,fhdplus-video' panel), mapping it to Zhuohong, a different panel
manufacturer, could cause confusion for device tree authors.
Should this prefix be named something like '^zhuohong,.*' instead to match
the manufacturer, or should the description be updated to reflect the actual
Shenchao company name?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260913-nt36672a-panels-v1-0-ce097402c6ea@minlexx.ru?part=2
next prev parent reply other threads:[~2026-09-13 6:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 5:36 [PATCH 0/9] drm/panel: novatek-nt36672a: Extend with 5 new panels Alexey Minnekhanov
2026-09-13 5:36 ` [PATCH 1/9] dt-bindings: vendor-prefixes: Add Shenzhen TXD Technology Co., Ltd Alexey Minnekhanov
2026-09-13 5:36 ` [PATCH 2/9] dt-bindings: vendor-prefixes: Add Shenzhen Zhuohong Electronic Alexey Minnekhanov
2026-09-13 6:31 ` sashiko-bot [this message]
2026-09-13 5:36 ` [PATCH 3/9] dt-bindings: display: novatek,nt36672a: Add 5 new panels Alexey Minnekhanov
2026-09-13 6:32 ` sashiko-bot
2026-09-13 5:36 ` [PATCH 4/9] drm/panel: novatek-nt36672a: Set driver name to novatek for consistency Alexey Minnekhanov
2026-09-13 12:52 ` David Heidelberg
2026-09-13 5:36 ` [PATCH 5/9] drm/panel: novatek-nt36672a: Combine two init callbacks into one Alexey Minnekhanov
2026-09-13 5:36 ` [PATCH 6/9] drm/panel: novatek-nt36672a: Add 3 panels used in Xiaomi phones Alexey Minnekhanov
2026-09-13 6:34 ` sashiko-bot
2026-09-13 5:36 ` [PATCH 7/9] drm/panel: novatek-nt36672a: Add Tianma panel for Xiaomi Mi A2 Alexey Minnekhanov
2026-09-13 6:31 ` sashiko-bot
2026-09-13 5:36 ` [PATCH 8/9] drm/panel: novatek-nt36672a: Add panel for Asus Zenfone Max Pro M1 Alexey Minnekhanov
2026-09-13 12:47 ` David Heidelberg
2026-09-13 5:36 ` [PATCH 9/9] MAINTAINERS: Add Alexey Minnekhanov as maintainer for NT36672A panel Alexey Minnekhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913063107.D83681F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexeymin@minlexx.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.