Re: [PATCH] drm/panel: ilitek-ili9881c: fix panel cleanup on attach failure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing semicolon at the end of the return statement for dev_err_probe, causing a syntax error and build failure.
--

commit 4d6fd7214b6dd880b985f4f7ae888ed25d2fea1a
Author: Guangshuo Li <lgs201920130244@gmail.com>

drm/panel: ilitek-ili9881c: fix panel cleanup on attach failure

This commit replaces drm_panel_add() with devm_drm_panel_add() in
ili9881c_dsi_probe() to ensure the panel registration is correctly removed
upon probe failure or driver teardown. It also removes the redundant
drm_panel_remove() call from the remove callback.

> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index c3d5ab67121d9..1a52f92e2963b 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -2594,7 +2594,9 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
>  	if (ret)
>  		return ret;
>  
> -	drm_panel_add(&ctx->panel);
> +	ret = devm_drm_panel_add(&dsi->dev, &ctx->panel);
> +	if (ret)
> +		return dev_err_probe(&dsi->dev, ret, "Failed to add panel\n")

[Severity: Low]
Does this compile successfully? It looks like the return statement using
dev_err_probe() in ili9881c_dsi_probe() is missing a terminating semicolon,
which would cause a syntax error during the build.

>  	dsi->mode_flags = ctx->desc->mode_flags;
>  	dsi->format = MIPI_DSI_FMT_RGB888;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260913102608.1526916-1-lgs201920130244@gmail.com?part=1