Re: [PATCH bpf v2 2/3] bpftool: Keep struct_ops field offsets when skipping bitfields

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Multi-line comment does not follow the preferred BPF subsystem comment style.
--

commit 76b7f5ec797f551d88f419af56f14122daae2704
Author: Mingpei CAO <caomingpei@gmail.com>

bpftool: Keep struct_ops field offsets when skipping bitfields

This commit modifies the struct_ops skeleton generator to correctly handle
bitfields by representing unsupported bitfield storage as padding. This
prevents excessive padding generation and keeps supported fields at their
declared BTF offsets.

> diff --git a/tools/bpf/bpftool/gen.c b/tools/bpf/bpftool/gen.c
> --- a/tools/bpf/bpftool/gen.c
> +++ b/tools/bpf/bpftool/gen.c
[ ... ]
> @@ -1108,34 +1125,64 @@ static int walk_st_ops_shadow_vars(struct btf *btf, const char *ident,
[ ... ]
> +		case ST_OPS_SHADOW_OPAQUE:
> +			/* Avoid emitting named types that might conflict with
> +			 * definitions from other skeletons.
> +			 */

[Severity: Low]
This isn't a bug, but does this multi-line comment in
walk_st_ops_shadow_vars() adhere to the BPF subsystem guidelines? The
preferred style for multi-line comments under BPF-related paths requires
the opening /* to be on its own line, rather than on the same line as the
first line of text.

>  			printf("\t\t\tchar __unsupported_%d[%d];\n", i, size);
>  			break;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260913145233.1446643-1-caomingpei@gmail.com?part=2