All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [koverstreet-bcachefs:trace_sched_wakeup_backtrace 249/332] fs/bcachefs/data/reconcile/work.c:658:1: warning: the frame size of 1552 bytes is larger than 1536 bytes
Date: Sun, 13 Sep 2026 17:36:27 +0200	[thread overview]
Message-ID: <202609131723.TsG4zJGP-lkp@intel.com> (raw)

tree:   https://github.com/koverstreet/bcachefs trace_sched_wakeup_backtrace
head:   9e7cbd4ad9c7a7ba461dbba9185628c006e200cd
commit: 2df58c8935f572f91c66956583e5b764203df420 [249/332] bcachefs: Fix use-after-unlock in reconcile tracepoints
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20260913/202609131723.TsG4zJGP-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260913/202609131723.TsG4zJGP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609131723.TsG4zJGP-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/bcachefs/data/reconcile/work.c: In function 'do_reconcile_extent_phys':
>> fs/bcachefs/data/reconcile/work.c:658:1: warning: the frame size of 1552 bytes is larger than 1536 bytes [-Wframe-larger-than=]
     658 | }
         | ^


vim +658 fs/bcachefs/data/reconcile/work.c

de374d7b729620 Kent Overstreet 2026-01-19  613  
de374d7b729620 Kent Overstreet 2026-01-19  614  static int do_reconcile_extent_phys(struct moving_context *ctxt,
de374d7b729620 Kent Overstreet 2026-01-19  615  				    struct per_snapshot_io_opts *snapshot_io_opts,
de374d7b729620 Kent Overstreet 2026-01-19  616  				    struct bbpos work,
de374d7b729620 Kent Overstreet 2026-01-19  617  				    struct wb_maybe_flush *last_flushed)
de374d7b729620 Kent Overstreet 2026-01-19  618  {
de374d7b729620 Kent Overstreet 2026-01-19  619  	struct btree_trans *trans = ctxt->trans;
de374d7b729620 Kent Overstreet 2026-01-19  620  	struct bch_fs *c = trans->c;
de374d7b729620 Kent Overstreet 2026-01-19  621  
de374d7b729620 Kent Overstreet 2026-01-19  622  	CLASS(btree_iter, bp_iter)(trans, BTREE_ID_backpointers, work.pos, 0);
de374d7b729620 Kent Overstreet 2026-01-19  623  	struct bkey_s_c bp_k = bkey_try(bch2_btree_iter_peek_slot(&bp_iter));
de374d7b729620 Kent Overstreet 2026-01-19  624  	if (!bp_k.k || bp_k.k->type != KEY_TYPE_backpointer) /* write buffer race */
de374d7b729620 Kent Overstreet 2026-01-19  625  		return 0;
de374d7b729620 Kent Overstreet 2026-01-19  626  
de374d7b729620 Kent Overstreet 2026-01-19  627  	CLASS(btree_iter_uninit, iter)(trans);
de374d7b729620 Kent Overstreet 2026-01-19  628  	struct bkey_s_c_backpointer bp = bkey_s_c_to_backpointer(bp_k);
de374d7b729620 Kent Overstreet 2026-01-19  629  	struct bkey_s_c k = bkey_try(bch2_backpointer_get_key(trans, bp, &iter, 0, last_flushed));
de374d7b729620 Kent Overstreet 2026-01-19  630  	if (!k.k)
de374d7b729620 Kent Overstreet 2026-01-19  631  		return 0;
de374d7b729620 Kent Overstreet 2026-01-19  632  
2df58c8935f572 Kent Overstreet 2026-01-25  633  	struct bkey_buf stack_bp __cleanup(bch2_bkey_buf_exit);
2df58c8935f572 Kent Overstreet 2026-01-25  634  	bch2_bkey_buf_init(&stack_bp);
2df58c8935f572 Kent Overstreet 2026-01-25  635  	bch2_bkey_buf_reassemble(&stack_bp, bp_k);
2df58c8935f572 Kent Overstreet 2026-01-25  636  
2df58c8935f572 Kent Overstreet 2026-01-25  637  	struct bkey_buf stack_k __cleanup(bch2_bkey_buf_exit);
2df58c8935f572 Kent Overstreet 2026-01-25  638  	bch2_bkey_buf_init(&stack_k);
2df58c8935f572 Kent Overstreet 2026-01-25  639  	bch2_bkey_buf_reassemble(&stack_k, k);
2df58c8935f572 Kent Overstreet 2026-01-25  640  
de374d7b729620 Kent Overstreet 2026-01-19  641  	struct bch_inode_opts opts;
de374d7b729620 Kent Overstreet 2026-01-19  642  	struct data_update_opts data_opts = {
de374d7b729620 Kent Overstreet 2026-01-19  643  		.read_dev	= work.pos.inode,
de374d7b729620 Kent Overstreet 2026-01-19  644  		.read_flags	= BCH_READ_soft_require_read_device,
de374d7b729620 Kent Overstreet 2026-01-19  645  	};
de374d7b729620 Kent Overstreet 2026-01-19  646  	try(__do_reconcile_extent(ctxt, snapshot_io_opts, &opts, &data_opts, work, &iter, bp.v->level, k));
de374d7b729620 Kent Overstreet 2026-01-19  647  
de374d7b729620 Kent Overstreet 2026-01-19  648  	event_add_trace(c, reconcile_phys, k.k->size, buf, ({
de374d7b729620 Kent Overstreet 2026-01-19  649  		prt_newline(&buf);
2df58c8935f572 Kent Overstreet 2026-01-25  650  		bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(stack_bp.k));
de374d7b729620 Kent Overstreet 2026-01-19  651  		prt_newline(&buf);
2df58c8935f572 Kent Overstreet 2026-01-25  652  		bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(stack_k.k));
de374d7b729620 Kent Overstreet 2026-01-19  653  		prt_newline(&buf);
de374d7b729620 Kent Overstreet 2026-01-19  654  		bch2_data_update_opts_to_text(&buf, c, &opts, &data_opts);
de374d7b729620 Kent Overstreet 2026-01-19  655  	}));
de374d7b729620 Kent Overstreet 2026-01-19  656  
de374d7b729620 Kent Overstreet 2026-01-19  657  	return 0;
de374d7b729620 Kent Overstreet 2026-01-19 @658  }
de374d7b729620 Kent Overstreet 2026-01-19  659  

:::::: The code at line 658 was first introduced by commit
:::::: de374d7b7296203619ba70f976867051cebaf41b bcachefs: Break up reconcile.c

:::::: TO: Kent Overstreet <kent.overstreet@linux.dev>
:::::: CC: Kent Overstreet <kent.overstreet@linux.dev>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-09-13 15:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202609131723.TsG4zJGP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kent.overstreet@linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.