From: Wei Liu <wei.liu@kernel.org>
To: Jiangshan Yi <yijiangshan@kylinos.cn>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, longli@microsoft.com, tglx@kernel.org,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, linux-hyperv@vger.kernel.org,
linux-kernel@vger.kernel.org, 13667453960@163.com
Subject: Re: [PATCH] x86/hyperv: Fix stale comments after stimer message mode removal
Date: Sun, 13 Sep 2026 15:35:19 -0700 [thread overview]
Message-ID: <20260913223519.GC2219269@liuwe-devbox-debian-v2.local> (raw)
In-Reply-To: <20260901033201.167219-1-yijiangshan@kylinos.cn>
On Tue, Sep 01, 2026 at 11:32:01AM +0800, Jiangshan Yi wrote:
> The removal of stimer message mode in commit be0cfab740e5 ("clocksource:
> hyper-v: Remove support for stimer interrupts in message mode") left a
> few comments out of date. hv_stimer_setup_percpu_clockev() picked up two
> typos ("afters", "to allows"), and the hv_synic_suspend() comment still
> references the deleted hv_stimer_legacy_cleanup(), the legacy non-Direct
> Mode configuration, and clockevents_unbind_device(), which is no longer
> on the cleanup path.
>
> Update the typos and rewrite the hv_synic_suspend() comment to describe
> the current Direct Mode path: non-boot CPU stimers are cleaned up via
> the cpuhp teardown callback hv_stimer_cleanup(), and CPU0's stimer is
> left alone because it is harmless (interrupts stay disabled across the
> suspend/resume window) and is shut down later by the timekeeping code.
>
> Signed-off-by: Jiangshan Yi <yijiangshan@kylinos.cn>
Applied. Thanks.
prev parent reply other threads:[~2026-09-13 22:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 3:32 [PATCH] x86/hyperv: Fix stale comments after stimer message mode removal Jiangshan Yi
2026-09-01 21:49 ` Michael Kelley
2026-09-13 22:35 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913223519.GC2219269@liuwe-devbox-debian-v2.local \
--to=wei.liu@kernel.org \
--cc=13667453960@163.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yijiangshan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.