From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4025F40B0FE for ; Sun, 13 Sep 2026 22:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339077; cv=none; b=rM0+A4V/sb3jkXTW3sEtrudFt/4TWNmHNfoZS8l/Hv2EIu90DpH2tAbyTkF9iBWgzt9tx0qWtlRT4+vARkqG6wGC2e3fJufrHQeauGsdyQO2cv1Z4gsCU3cngEzdrKWoc1RsMxSL4QNE4pbH8nFq1Juvp9QO0OnVmu9Is8wLNws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789339077; c=relaxed/simple; bh=3yFoHeW1ePG+i4RCbEU2JofKauVW53+A/Z/TXfsz8qo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aRFR69FUsAW9yBm8l46IrhjQ/3Jzx0Mn3xr4gTgLQXXB0MCfjlt9ddyMMpJnrDGgWw64WYlUnI+GUuRJnoTa/vLblwVHQwBw1H/7IOvRSTblxsqSAhTNJGhwcjoHQeWH22HKZA6xPRl9RGdrz8sO11gcTf9memsXBntJFJoTrvg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bNghW4Jq; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bNghW4Jq" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-939f5f82829so196604185a.1 for ; Sun, 13 Sep 2026 15:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789339075; x=1789943875; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DHFmaO+kDb8wMPnqE7UfVX7wmIXcuui9FuHVD6Z8w4w=; b=bNghW4JqbzV+nmJqMj0JcEhLWNJC6XhUTI4gO2ieCIw45NBc6ZiL4eWtWx+298tzcs QMUl68yjAlapHf837bttbmeW4kCC8iwM5Zc2jLotnIK0GUAZV0jqIcx6bZq6INP3yTd4 LjoloRiXm8vQw63jLtnyTxNZv8dKj0NO4nGlZGe8AYpJkB8wf4WTsfbEcPDizLzodVzC TO2r0RbpIY7hSXvBXCFSYXJSXc7DWpHeKxHMo33jNUN/WqbBmRcKWDiG33OCkhsm/KRA d3wAcpFTU/JwdtEtoSB6Jp62CMz1KpZEMLkQvx+2ga2wjmuuB89j2JY5izfLqfTEQi+n RgjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789339075; x=1789943875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DHFmaO+kDb8wMPnqE7UfVX7wmIXcuui9FuHVD6Z8w4w=; b=rgZOCsBJonYZMoKInpdi0Rmi4d4fY83P9x95WzhIcrXljpvtph6yo2owHpYUXWuHGT 52E2wcY2ZhVvWFf56F5JAd1Mmpkpo9LbZluajSIs9FK9QrngDA5joJMj3I643GAL+45b GNlL677NmVgBOOdf+3WMERBs9C9uA/1l/3uTKvX905YDkRgLn7+BO9YMT7cV9FYnZ7t7 XNh7qV00PY1U9V/qbhAKCDlIsjmfcnp/sYEbWIZXjuCwj502dO+rDbdT9FEgLyUnBG8E KgSKdbBe2epEPBMV3Va88MhOjCpxl6lz3GGT6Kw5sXv1AmiiB4Ck7kMGp0RW34zXWf/4 IpFg== X-Forwarded-Encrypted: i=1; AKwUvBz+RwvEJfQSwOvnIeF+ChsvwGtAnvocH2+HKyAzhhZu9OADuOj2BzLR5mkILlrAxm/OykFy405mTkKmaU9ObpPcQA==@vger.kernel.org X-Gm-Message-State: AFuF++kIIoHx85DdecWwmCPcfP08eN2Wv5AEA8nUcG1iR15cjNBJCA9V iJL7cbVaSgKJ1yIIe1zDY/ywfoKXJPcyS+R+8vmPwoas7ryJeCKPV5k= X-Gm-Gg: AYBFou1mwqxvfqD7HbqgPHySVw+G+0pixkbIcod6OiVzPQfupfrw9+YJWdrmj2+UIBU aS12Cb1Um0xEXuzMVkoAoXQAzDlHJuaVtJn2vlVxY+MpBmnIM/Geb0xD3RPHu9oMyBuVzfp4QBB odGN/mNzJeCsFdCso8hLSOuqsvfQ4i4lKhU2A8WXT/I9hfzNJvIqjYgTb5c2kLaljPQI9fm8YkI QWLC4ModBRJi1laHcLlGJoKy/rO8APr/GZJblE+fhwFy0D+uaqhMHAPen2i2/kV/55IcyoZN+du o54Dkxkg5BBTe7cHjhMvrgTWF7eutxpZ+x549WT6mwefQ8xll9QjHDAwG4Xj5Au9SfgpCCwRgYg gcGJ7uNGmGsImKNlv4nlwApVyn2s9CtxoaYQNNNO73taHf9ucBLG6yE8p6iQtAUyeJBQ+ywKf15 bODIYrO1lmQspCAaL6zXloj7w0LxAOKnr0RSAKT3qzIDyFxQc0vn9KJuCNJy4MODdJKct7yj+we VAMGu2IVTl6/JWFR15JPFmh/VxC2rgyy+iSFnlxTLTkcYRVublRKjB5Ak/znO4zJoxfe8hNxteg REi1AEWdFx86qn1fRk9bjtPvFhB3Ri0Gpw== X-Received: by 2002:a05:620a:2708:b0:93a:133a:310b with SMTP id af79cd13be357-93a1870eb4amr396136385a.26.1789339075060; Sun, 13 Sep 2026 15:37:55 -0700 (PDT) Received: from localhost.localdomain ([104.39.73.78]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9120f45cbf2sm79361056d6.17.2026.09.13.15.37.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 13 Sep 2026 15:37:53 -0700 (PDT) From: Myeonghun Pak To: stern@rowland.harvard.edu Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, peter.griffin@linaro.org, alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 3/3] usb: ohci-exynos: Disable controller wakeup on removal Date: Sun, 13 Sep 2026 18:37:32 -0400 Message-ID: <20260913223732.92882-4-mhun512@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260913223732.92882-1-mhun512@gmail.com> References: <20260913223732.92882-1-mhun512@gmail.com> Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When OHCI reports remote-wakeup capability, a successful wakeup enable leaves a source attached after driver unbind: usb_remove_hcd() does not disable controller wakeup. Disable it after usb_remove_hcd() to balance the enable. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 62194244cf87 ("USB: Add Samsung Exynos OHCI diver") Assisted-by: OpenAI:GPT-5.6 Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/usb/host/ohci-exynos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index cc5cb09..86ff7a0 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -194,6 +194,7 @@ static void exynos_ohci_remove(struct platform_device *pdev) pdev->dev.of_node = exynos_ohci->of_node; usb_remove_hcd(hcd); + device_wakeup_disable(hcd->self.controller); exynos_ohci_phy_disable(&pdev->dev);