Re: [PATCH v2] dt-bindings: net: can: convert ifi_canfd to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] DT Schema Error: `additionalProperties: false` incorrectly restricts inherited properties
--

commit 762b0b1dc7188a87b810716f4344f47313aba8cb
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: net: can: convert ifi_canfd to DT schema

This patch converts the IFI CAN-FD controller binding from a free-form
text document to a YAML DT schema. It also references the common
can-controller.yaml schema to inherit standard CAN properties.

> diff --git a/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/ifi,canfd.yaml
[ ... ]
> +allOf:
> +  - $ref: can-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: ifi,canfd-1.0
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false

[Severity: Medium]
Will this strict restriction prevent inherited properties from being used?

Because this schema inherits from can-controller.yaml# using an allOf
block, using additionalProperties: false here only evaluates the local
properties block. If a standard CAN property like bitrate or
termination-gpios is added to a device tree node, dtbs_check will reject
it as an unallowed additional property.

Should this use unevaluatedProperties: false instead to properly allow the
properties defined in the referenced schema?

> +
> +examples:
> +  - |
> +    canfd0: can@ff220000 {
> +        compatible = "ifi,canfd-1.0";
> +        reg = <0xff220000 0x1000>;
> +        interrupts = <0 43 0>;
> +    };
> +...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914013636.394263-1-quchaosheng000406@163.com?part=1