Re: [PATCH] dt-bindings: net: can: holt,hi3110: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The schema omits a reference to the standard SPI peripheral properties schema, which will cause valid standard SPI properties (like `spi-max-frequency`) to be falsely rejected.
- [Low] The maximum supported clock frequency is documented in the schema text but not formally enforced as a JSON Schema constraint.
--

commit 708f7e5cdeffdf3f0881283fe507970525fe6ae2
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: net: can: holt,hi3110: Convert to DT schema

This commit converts the Holt HI-311X stand-alone CAN controller binding from
free-form text to a DT schema. It references the common can-controller schema
and explicitly models the alternative between a provided clock and a clock
frequency fallback.

> diff --git a/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
> new file mode 100644
> index 0000000000000..8c433fcac4a5a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/holt,hi311x.yaml
> @@ -0,0 +1,80 @@
[ ... ]
> +description:
> +  The Holt HI-3110 is a stand-alone CAN controller with an SPI interface.
> +
> +allOf:
> +  - $ref: can-controller.yaml#

[Severity: Low]
Does this schema need a reference to /schemas/spi/spi-peripheral-props.yaml#?

Because unevaluatedProperties is set to false at the bottom of the schema, 
and the SPI peripheral properties are not pulled in by can-controller.yaml,
valid SPI properties like spi-max-frequency will be treated as undocumented
and falsely rejected by dtbs_check.

> +
> +properties:
> +  compatible:
> +    const: holt,hi3110
[ ... ]
> +  clock-frequency:
> +    description:
> +      Frequency of the clock feeding the CAN controller, in Hz. Used when
> +      no clocks property is provided. The maximum supported frequency is
> +      40000000.
> +    $ref: /schemas/types.yaml#/definitions/uint32

[Severity: Low]
Should this property include a formal maximum: 40000000 constraint?

The description mentions the 40 MHz limit, but without the JSON Schema 
constraint, device trees configuring a higher frequency will silently pass 
schema validation even though the driver enforces the limit at runtime.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914030215.437602-3-quchaosheng000406@163.com?part=1