Re: [PATCH v15 1/6] arm64: dts: qcom: Add device tree for Nord SoC series

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] All `trip-point1` (critical threshold) thermal trip points are incorrectly configured as `type = "passive"`, disabling emergency shutdown on SoC overheat.
--

commit 064e0b2912cbdce3f68bb9c83f53cc3134182d27
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for Nord SoC series

Add base device tree include (nord.dtsi) for the Nord SoC series
describing the core hardware components:

> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi

[ ... ]

> +	thermal_zones: thermal-zones {
> +		ddr-0-0-thermal {
> +			polling-delay-passive = <0>;
> +			polling-delay = <0>;
> +			thermal-sensors = <&tsens0 0>;
> +
> +			trips {
> +				trip-point0 {
> +					temperature = <105000>;
> +					hysteresis = <10000>;
> +					type = "passive";
> +				};
> +
> +				trip-point1 {
> +					temperature = <115000>;
> +					hysteresis = <10000>;
> +					type = "passive";

[Severity: High]
Are these maximum temperature trip points intended to be passive rather than
critical?

If the SoC overheats to 115C or 125C, the Linux kernel will not trigger an
emergency shutdown because the maximum trip points are marked as passive
instead of critical.

The Qualcomm TSENS driver explicitly disables hardware-based critical thermal
interrupts on Linux, deferring shutdown entirely to the software thermal
framework. Because the framework will treat this as a passive cooling threshold
crossing, it will not initiate orderly_poweroff(), risking hardware damage.

This pattern appears to be repeated across all thermal zones in this file
(e.g., cpu-0-0-0-thermal, ddr-0-0-thermal).

> +				};
> +			};
> +		};
> +
> +		cpu-0-0-0-thermal {
> +			polling-delay-passive = <0>;
> +			polling-delay = <0>;
> +			thermal-sensors = <&tsens0 1>;
> +
> +			trips {
> +				trip-point0 {
> +					temperature = <105000>;
> +					hysteresis = <10000>;
> +					type = "passive";
> +				};
> +
> +				trip-point1 {
> +					temperature = <125000>;
> +					hysteresis = <10000>;
> +					type = "passive";
> +				};
> +			};
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914031412.140856-1-shengchao.guo@oss.qualcomm.com?part=1