From: Alex Markuze <amarkuze@redhat.com>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: ceph: acquire write lock only if snap trace has really changed
Date: Mon, 14 Sep 2026 05:33:53 +0000 [thread overview]
Message-ID: <20260914053353.132489-1-amarkuze@redhat.com> (raw)
In-Reply-To: <20260911185244.1420485-1-max.kellermann@ionos.com>
Hi Max,
NACK. Please respin.
1. fs/ceph/snap.c:963: Fast path rejects the global realm, so the write lock is never skipped
`get_snap_trace_if_unmodified()` treats a NULL `realm->parent` as
"must update".
Match `adjust_snap_realm_parent()` and compare `realm->parent_ino`
to `ri->parent`.
--
Alex Markuze
next prev parent reply other threads:[~2026-09-14 5:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 18:52 [PATCH] ceph: acquire write lock only if snap trace has really changed Max Kellermann
2026-09-14 5:33 ` Alex Markuze [this message]
2026-09-14 6:08 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914053353.132489-1-amarkuze@redhat.com \
--to=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.