Re: [PATCH 1/4] arm64: dts: st: add imx335/csi/dcmipp nodes on stm32mp257f-dk

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Using a `gpio-hog` to enable the IMX335 power line circumvents the camera driver's runtime power management.
--

commit 933d75b3c84530835787fe0315d18eced64336b3
Author: Alain Volmat <alain.volmat@foss.st.com>

arm64: dts: st: add imx335/csi/dcmipp nodes on stm32mp257f-dk

This commit adds all nodes necessary for the imx335 camera capture via CSI
and DCMIPP on the stm32mp257f discovery board.

> diff --git a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts
> index 8daf3dfd51339..39ad23d95069c 100644
> --- a/arch/arm64/boot/dts/st/stm32mp257f-dk.dts
> +++ b/arch/arm64/boot/dts/st/stm32mp257f-dk.dts

[ ... ]

> @@ -160,6 +205,16 @@ phy1_eth1: ethernet-phy@1 {
>  	};
>  };
>  
> +&gpiob {
> +	/* Enable the IMX335 power line */
> +	imx335-en-hog {
> +		gpio-hog;

[Severity: Medium]
Does using a gpio-hog to enable the IMX335 power line circumvent the camera
driver's runtime power management?

By permanently asserting the power line upon boot, the IMX335 camera sensor
remains fully powered at all times, preventing the system from reducing power
draw when the camera is not active. This wastes energy and breaks the expected
runtime power management.

> +		gpios = <11 GPIO_ACTIVE_HIGH>;
> +		output-high;
> +		line-name = "imx335_en";
> +	};
> +};
>  
>  &i2c2 {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-stm32mp2-dk-camera-v1-0-2f2bd719bb63@foss.st.com?part=1