Re: [PATCH 02/31] arm64: dts: qcom: sm8750: Add domain idle state names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `idle-state-name` for the system-level domain state `domain_ss3` is incorrectly set to "cluster-ss3", likely due to a copy-paste error.
--

commit c0d5e2b0b54be493530a7796453fb58e77c73a2c
Author: Maulik Shah <maulik.shah@oss.qualcomm.com>

arm64: dts: qcom: sm8750: Add domain idle state names

This commit adds the idle-state-name property to the domain idle states for
the SM8750 device tree. This allows low power modes to be described
consistently and exposed cleanly in pmdomain debugfs.

> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index 28cf22da854d0..897790a3a4921 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
[ ... ]
> @@ -208,6 +209,7 @@ cluster_cl5: cluster-sleep-0 {
>  
>  			domain_ss3: domain-sleep-0 {
>  				compatible = "domain-idle-state";
> +				idle-state-name = "cluster-ss3";

[Severity: Low]
Is this intended to be named "cluster-ss3" rather than a domain-level name?

This defines the idle state name exposed to userspace via debugfs for
domain_ss3, which is a system/domain-level state (level 2, indicated by its
psci-suspend-param 0x0200c354). Applying the "cluster-" prefix here seems
like a typo that might be misleading and confuse debugging of power
management on this platform.

>  				arm,psci-suspend-param = <0x0200c354>;
>  				entry-latency-us = <2800>;
>  				exit-latency-us = <4400>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-b4-idle-state-name-v1-0-660c31187819@oss.qualcomm.com?part=2