Re: [PATCH 2/2] arm64: dts: st: add dcmi node on stm32mp23x

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing unconditionally required 'port' property in the newly added 'dcmi' node, causing a dtbs_check warning.
--

commit 42a2863a4d17c3ffce4549b0b100b843b4aeb937
Author: Alain Volmat <alain.volmat@foss.st.com>

arm64: dts: st: add dcmi node on stm32mp23x

This commit adds the devicetree node for the DCMI controller in the
stm32mp231.dtsi include file.

> diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> index 0feb8943efae6..ad008049384b7 100644
> --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> @@ -646,6 +646,20 @@ uart7: serial@40370000 {
>  				status = "disabled";
>  			};
>  
> +			dcmi: dcmi@404a0000 {
> +				compatible = "st,stm32-dcmi";
> +				reg = <0x404a0000 0x400>;
> +				interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>;
> +				resets = <&rcc CCI_R>;
> +				clocks = <&rcc CK_BUS_CCI>;
> +				clock-names = "mclk";
> +				dmas = <&hpdma 137 0x60 0x00003012>;
> +				dma-names = "tx";
> +				access-controllers = <&rifsc 88>;
> +				power-domains = <&cluster_pd>;
> +				status = "disabled";
> +			};

[Severity: Low]
Does this node need a 'port' property to satisfy the st,stm32-dcmi.yaml
dt-binding?

While the driver safely handles a missing endpoint in dcmi_probe() by
returning -ENODEV:

drivers/media/platform/st/stm32/stm32-dcmi.c:dcmi_probe() {
	...
	np = of_graph_get_endpoint_by_regs(np, 0, -1);
	if (!np) {
		dev_err(&pdev->dev, "Could not find the endpoint\n");
		return -ENODEV;
	}
	...
}

the binding schema unconditionally requires the port property, which will
trigger a dtbs_check warning when omitted.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-stm32mp2x-dcmi-v1-0-c594e081d21b@foss.st.com?part=2