From: Simon Horman <horms@kernel.org>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: Jiawen Wu <jiawenwu@trustnetic.com>,
Mengyuan Lou <mengyuanlou@net-swift.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ae878000@gmail.com
Subject: Re: [PATCH net] net: txgbe: free the fixed-rate clock on cleanup
Date: Mon, 14 Sep 2026 09:30:53 +0100 [thread overview]
Message-ID: <20260914083053.GM48209@horms.kernel.org> (raw)
In-Reply-To: <20260911155318.88857-1-mhun512@gmail.com>
On Fri, Sep 11, 2026 at 11:53:18AM -0400, Myeonghun Pak wrote:
> The fixed-rate clock is registered with clk_register_fixed_rate(), but
> its error and removal paths use clk_unregister(). That unregisters the
> clock without freeing the fixed-rate provider allocation.
>
> Use clk_unregister_fixed_rate() on lookup creation failure, later PHY
> initialization failure and removal to release the provider allocation as
> well. Keep the existing clock registration and lookup cleanup ordering.
>
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
>
> Fixes: b63f20485e43 ("net: txgbe: Register fixed rate clock")
> Assisted-by: OpenAI:GPT-5.6
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-09-14 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 15:53 [PATCH net] net: txgbe: free the fixed-rate clock on cleanup Myeonghun Pak
2026-09-14 8:30 ` Simon Horman [this message]
2026-09-16 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914083053.GM48209@horms.kernel.org \
--to=horms@kernel.org \
--cc=ae878000@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=mhun512@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.