Re: [PATCH RFC v2 04/10] cacheinfo: Expose the code to generate a cache-id from a device_node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly exported `cache_of_calculate_id()` API is conditionally declared without providing a static inline fallback, forcing callers to use preprocessor `#ifdef` guards rather than `IS_ENABLED()`.
--

commit 8b22a5b7c500764e08eb7b259467554e27f1adfe
Author: James Morse <james.morse@arm.com>

cacheinfo: Expose the code to generate a cache-id from a device_node

This commit exposes the cache_of_calculate_id() function to allow early
parts of the MPAM driver to set up resctrl structures before cacheinfo
is ready. It extracts the calculation logic and adds a declaration
guarded by CONFIG_OF in the cacheinfo header.

> diff --git a/include/linux/cacheinfo.h b/include/linux/cacheinfo.h
> index fc879ac4cc4f2..c33bb3c8bd633 100644
> --- a/include/linux/cacheinfo.h
> +++ b/include/linux/cacheinfo.h
> @@ -113,6 +113,9 @@ int acpi_get_cache_info(unsigned int cpu,
>  #endif
>  
>  const struct attribute_group *cache_get_priv_group(struct cacheinfo *this_leaf);
> +#ifdef CONFIG_OF
> +u32 cache_of_calculate_id(struct device_node *np);
> +#endif

[Severity: Low]
Does this conditionally exported API need a static inline fallback for when
CONFIG_OF is disabled?

Without a stub for the !CONFIG_OF case in include/linux/cacheinfo.h, any
future caller using if (IS_ENABLED(CONFIG_OF)) to guard a call to
cache_of_calculate_id() will fail to compile due to an implicit function
declaration error. Should a static inline fallback be added to avoid forcing
callers to use preprocessor #ifdef guards?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-mpam-resctrl-dt-knp-support-v2-0-bf6645bb2f65@oss.qualcomm.com?part=4