Re: [PATCH 1/1] arm64: dts: qcom: sdm845-sony-tama: Enable UFS host controller and PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Enabling the UFS controller on the Sony Xperia Tama platform without the required driver workaround risks erasing the bootloader and permanently hard-bricking the device.
--

commit 91d507f63b9143b3c7a96ab7389c84dca2784cd5
Author: Shujath Mohd <shujath@outlook.in>
Subject: arm64: dts: qcom: sdm845-sony-tama: Enable UFS host controller and PHY

This commit enables the UFS host controller and PHY on Sony Xperia Tama
devices. It removes the previous status disabled guard and configures the
necessary regulators and reset GPIOs.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
[ ... ]
> @@ -774,9 +774,21 @@ &uart9 {
>  	status = "okay";
>  };
>  
> -/* BIG WARNING! DO NOT TOUCH UFS, YOUR DEVICE WILL DIE! */
> -&ufs_mem_hc { status = "disabled"; };
> -&ufs_mem_phy { status = "disabled"; };
> +&ufs_mem_hc {
> +	status = "okay";
> +
> +	reset-gpios = <&tlmm 150 GPIO_ACTIVE_LOW>;

[Severity: Critical]
Does enabling the UFS controller here on the Sony Xperia Tama platform
without the required driver workaround risk erasing the bootloader and
permanently hard-bricking the device?

The original commit (30a7f99befc6) that introduced the platform explicitly
documented that sending a specific UFS command on these devices effectively
erases the bootloader. If the system or a user issues that UFS command,
such as via block discard, secure erase, firmware upgrade, or during
specific error-recovery paths, the device becomes unbootable. Userspace
operations such as fstrim or background kernel maintenance tasks can trigger
these commands.

Is the required downstream UFS driver workaround (kholk/kernel@2e7a9ee)
ported to the mainline drivers/ufs/ core? Removing the status="disabled"
protection without the driver-level mitigation active appears to expose
users of this device to a known hardware brick, even if normal boot and
reboot cycles appear stable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/PUZPR01MB514158F5EDA660AC85FA8D5BC3BB2@PUZPR01MB5141.apcprd01.prod.exchangelabs.com?part=1