From: sashiko-bot@kernel.org
To: "Jann Horn" <jannh@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf: Fix refcount leak on perf_cgroup_ensure_storage error
Date: Mon, 14 Sep 2026 10:47:34 +0000 [thread overview]
Message-ID: <20260914104734.ADD681F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260914-perf-cgroup-refleak-v1-1-eac12ba28be6@google.com>
> If perf_cgroup_ensure_storage() fails, perf_cgroup_connect() has already
> acquired a reference on the cgroup_subsys_state.
> Drop that reference before returning.
>
> This probably doesn't matter in practice - it only makes a difference if
> a kmalloc allocation fails, with allocation size depending on the cgroup
> nesting depth.
>
> Fixes: c2283c9368d4 ("perf/cgroup: Grow per perf_cpu_context heap storage")
> Signed-off-by: Jann Horn <jannh@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-perf-cgroup-refleak-v1-1-eac12ba28be6@google.com?part=1
next prev parent reply other threads:[~2026-09-14 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 10:37 [PATCH] perf: Fix refcount leak on perf_cgroup_ensure_storage error Jann Horn
2026-09-14 10:47 ` sashiko-bot [this message]
2026-09-15 19:18 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914104734.ADD681F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jannh@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.