From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/5] min_dio_alignment: add a -r option to query read alignment
Date: Mon, 14 Sep 2026 13:44:18 +0200 [thread overview]
Message-ID: <20260914114418.GB23111@lst.de> (raw)
In-Reply-To: <aqfAZC5O21fYmVNP@zlang-mailbox>
On Mon, Sep 14, 2026 at 05:44:07PM +0800, Zorro Lang wrote:
> > I couldn't find any mention in the statx doc that STATX_DIO_READ_ALIGN is
> > added by default, explicitly specifying it seems more aligned with how
> > the mask parameter is intended to work. Would you like me to fold this in
> > when merging? or did you omit it due to other concerns?
> >
> > This is the only open point left for the patchset, once we reach consensus,
> > I'm good to merge it :)
>
> Hi Christoph, friendly ping, I'm still waiting on your confirmation before
> merging this patchset. Would you prefer I keep it as is, or should I add
> STATX_DIO_READ_ALIGN?
Hi Zorro,
as I wrote in my last mail, passing STATX_DIO_READ_ALIGN is required
by the interface, but on XFS, the only current implementation, it
actually works without that. So yeah, please add it, or wait for me
to resend the series as I've already added it locally.
next prev parent reply other threads:[~2026-09-14 11:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 6:51 actually exercise sub-block direct I/O reads Christoph Hellwig
2026-08-31 6:51 ` [PATCH 1/5] statx.h: update to latest kernel UAPI Christoph Hellwig
2026-08-31 17:12 ` Darrick J. Wong
2026-09-02 15:31 ` Zorro Lang
2026-08-31 6:51 ` [PATCH 2/5] min_dio_alignment: add a -r option to query read alignment Christoph Hellwig
2026-08-31 17:16 ` Darrick J. Wong
2026-09-02 16:26 ` Zorro Lang
2026-09-03 5:34 ` Christoph Hellwig
2026-09-03 13:39 ` Zorro Lang
2026-09-14 9:44 ` Zorro Lang
2026-09-14 11:44 ` Christoph Hellwig [this message]
2026-09-02 16:31 ` Zorro Lang
2026-08-31 6:51 ` [PATCH 3/5] generic/091: enable sub-block reads Christoph Hellwig
2026-08-31 17:19 ` Darrick J. Wong
2026-09-02 16:46 ` Zorro Lang
2026-09-03 5:34 ` Christoph Hellwig
2026-09-03 13:33 ` Zorro Lang
2026-09-02 16:39 ` Zorro Lang
2026-08-31 6:51 ` [PATCH 4/5] generic/263: " Christoph Hellwig
2026-08-31 17:19 ` Darrick J. Wong
2026-09-02 16:48 ` Zorro Lang
2026-08-31 6:51 ` [PATCH 5/5] generic/760: " Christoph Hellwig
2026-08-31 17:19 ` Darrick J. Wong
2026-09-02 16:49 ` Zorro Lang
-- strict thread matches above, loose matches on Subject: below --
2026-09-14 11:45 actually exercise sub-block direct I/O reads v2 Christoph Hellwig
2026-09-14 11:45 ` [PATCH 2/5] min_dio_alignment: add a -r option to query read alignment Christoph Hellwig
2026-09-14 17:43 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914114418.GB23111@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.