From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C521EC88E66 for ; Mon, 14 Sep 2026 12:21:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CPnZV5I0f6XF4YXo90u5rTY2jeDn/HllhUNQ+oAbUPM=; b=nNmdXLgmkj5KrT i6zSPCq5pIgm8x0+p383lqr0Xu2hSUMOeMFsH7enJRk49P4cpxjLT+m4bPe66+9y18KJlpX97Zi3I 7u/2hhHR03ffEd+gOr8f3O3CPKFq4b3GLMyfbGKOz6WfxUHoSvT4hEr/QM/fj2PIkcP+stUgtiWnb gbAsM6nKJhEpe2Gu1BDjrDDMTd1Xf8StKw90x9170DuEY23FHKukIdPveDtUWqfetgz2Jlr5o+XYU glFKK134amX4zlOPW9Y3197Ipz6pEiDmRBSL+kjoz/jAaUXDcXlIbuE+tXloqlipOPsn3mXRy3luQ Vbi57cTYIE9ggjsr4AOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x65gc-00000003WtT-0Ah7; Mon, 14 Sep 2026 12:21:26 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x65gb-00000003WtG-1mRI for linux-phy@lists.infradead.org; Mon, 14 Sep 2026 12:21:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 2FF4140322; Mon, 14 Sep 2026 12:21:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B80631F000FF; Mon, 14 Sep 2026 12:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789388485; bh=RBJbzxmO+Vl6+bOBg4GNP5t1gGxwYu+KqDZ/3fHyHIk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=G0N4iX5TmB2lNBpvlydl6JqxmM1AKpVtLAjDNL1i6Yt1L8PK0xv+HrewAcKU2ytwu OyKy2AmZ03In+nGG45APhb9RHUSpPMGSJKIqNy+QDz4YbSxj+96Z/uTrOZQ9XLzrH/ Eb8TpDpnHX86KNhk99Speuzuf2skEP/NqRb2+I1weadNw6BSgjH9LEVg0roNOlZ9D/ cmxzzc8+xssCqPMkaMXcnQhfjdwJDv3YM8dZlos6BzptRevYt8JTTcuMdg65yk2GpX R5ZV8zojq26gKlvdLRQiPabtgD9T4tFNv8Y6WzUhFSfvy1mktjDzx/Kgt8u70QM20s i47R1fV5NMvtQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 08/24] scsi: ufs: mediatek: Add dual 0.9V supply support To: "Louis-Alexis Eyraud" Cc: linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, linux-scsi@vger.kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260914-mt8196-ufs-v12-8-9279d7ef814d@collabora.com> References: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> <20260914-mt8196-ufs-v12-8-9279d7ef814d@collabora.com> Date: Mon, 14 Sep 2026 12:21:24 +0000 Message-Id: <20260914122124.B80631F000FF@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFVuY2hlY2tlZCBOVUxM IHBvaW50ZXIgZGVyZWZlcmVuY2Ugb2Ygb3B0aW9uYWwgcmVndWxhdG9yIGBob3N0LT5yZWdfYXZk ZDA5YCBpbiBlcnJvciByZWNvdmVyeSBwYXRocy4KLS0KCmNvbW1pdCBjNjliMTE4OTEyNWNkNTEw NjMxOGQ4NzdmZmY3ZDFiZjgyZGZkMDEyCkF1dGhvcjogTG91aXMtQWxleGlzIEV5cmF1ZCA8bG91 aXNhbGV4aXMuZXlyYXVkQGNvbGxhYm9yYS5jb20+CgpzY3NpOiB1ZnM6IG1lZGlhdGVrOiBBZGQg ZHVhbCAwLjlWIHN1cHBseSBzdXBwb3J0CgpUaGlzIGNvbW1pdCBhZGRzIHN1cHBvcnQgZm9yIGFu IGFkZGl0aW9uYWwgMC45ViBzdXBwbHkgb24gdGhlIE1UODE5NiBTb0MuCkl0IGludHJvZHVjZXMg YSBzZWNvbmQgb3B0aW9uYWwgMC45ViByZWd1bGF0b3IgbmFtZWQgImF2ZGQwOS0xIiB0byB0aGUK cGxhdGZvcm0gZGF0YSBhbmQgbWFuYWdlcyBpdHMgZW5hYmxpbmcgYW5kIGRpc2FibGluZyBhbG9u Z3NpZGUgdGhlIHByaW1hcnkKc3VwcGx5LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91ZnMvaG9z dC91ZnMtbWVkaWF0ZWsuYyBiL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlhdGVrLmMKPiBpbmRl eCBmNDNiZWU1MGFkYjI4Li40NjdmYzc3YzkwZTEyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdWZz L2hvc3QvdWZzLW1lZGlhdGVrLmMKPiArKysgYi9kcml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRl ay5jCgpbIC4uLiBdCgo+IEBAIC01MTMsMTggKzUxNCwzNyBAQCBzdGF0aWMgaW50IHVmc19tdGtf d2FpdF9saW5rX3N0YXRlKHN0cnVjdCB1ZnNfaGJhICpoYmEsIHUzMiBzdGF0ZSwKPiAgc3RhdGlj IGludCB1ZnNfbXRrXzA5dl9vZmYoc3RydWN0IHVmc19tdGtfaG9zdCAqaG9zdCkKPiAgewo+ICAJ c3RydWN0IGFybV9zbWNjY19yZXMgcmVzOwo+IC0JaW50IHJldDsKPiArCWludCByZXQsIHJldDI7 Cj4gIAo+IC0JaWYgKCFob3N0LT5yZWdfYXZkZDA5KQo+ICsJaWYgKCFob3N0LT5yZWdfYXZkZDA5 ICYmICFob3N0LT5yZWdfYXZkZDA5XzEpCj4gIAkJcmV0dXJuIDA7Cj4gIAo+ICAJdWZzX210a192 YTA5X3B3cl9jdHJsKHJlcywgMCk7Cj4gLQlyZXQgPSByZWd1bGF0b3JfZGlzYWJsZShob3N0LT5y ZWdfYXZkZDA5KTsKPiAtCWlmIChyZXQpIHsKPiAtCQlkZXZfZXJyKGhvc3QtPmhiYS0+ZGV2LCAi RmFpbGVkIHRvIGRpc2FibGUgYXZkZDA5LXN1cHBseTogJXBlXG4iLAo+IC0JCQlFUlJfUFRSKHJl dCkpOwo+IC0JCXVmc19tdGtfdmEwOV9wd3JfY3RybChyZXMsIDEpOwo+IC0JCXJldHVybiByZXQ7 Cj4gKwo+ICsJaWYgKGhvc3QtPnJlZ19hdmRkMDkpIHsKPiArCQlyZXQgPSByZWd1bGF0b3JfZGlz YWJsZShob3N0LT5yZWdfYXZkZDA5KTsKPiArCQlpZiAocmV0KSB7Cj4gKwkJCWRldl9lcnIoaG9z dC0+aGJhLT5kZXYsICJGYWlsZWQgdG8gZGlzYWJsZSBhdmRkMDktc3VwcGx5OiAlcGVcbiIsCj4g KwkJCQlFUlJfUFRSKHJldCkpOwo+ICsJCQl1ZnNfbXRrX3ZhMDlfcHdyX2N0cmwocmVzLCAxKTsK PiArCQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJaWYgKGhvc3QtPnJlZ19hdmRk MDlfMSkgewo+ICsJCXJldCA9IHJlZ3VsYXRvcl9kaXNhYmxlKGhvc3QtPnJlZ19hdmRkMDlfMSk7 Cj4gKwkJaWYgKHJldCkgewo+ICsJCQlkZXZfZXJyKGhvc3QtPmhiYS0+ZGV2LCAiRmFpbGVkIHRv IGRpc2FibGUgYXZkZDA5LTEtc3VwcGx5OiAlcGVcbiIsCj4gKwkJCQlFUlJfUFRSKHJldCkpOwo+ ICsKPiArCQkJcmV0MiA9IHJlZ3VsYXRvcl9lbmFibGUoaG9zdC0+cmVnX2F2ZGQwOSk7CgpbU2V2 ZXJpdHk6IEhpZ2hdCkNhbiB0aGlzIGNhdXNlIGEgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlPwoK U2luY2UgaG9zdC0+cmVnX2F2ZGQwOSBpcyBmZXRjaGVkIHVzaW5nIGRldm1fcmVndWxhdG9yX2dl dF9vcHRpb25hbCgpLCBpdApjYW4gYmUgTlVMTCBpZiBpdCBpcyBhYnNlbnQgZnJvbSB0aGUgZGV2 aWNlIHRyZWUuIElmIGEgc3lzdGVtIG9ubHkgaGFzIHRoZQphdmRkMDktMSBzdXBwbHkgY29uZmln dXJlZCBhbmQgZGlzYWJsaW5nIGl0IGZhaWxzLCB0aGlzIGVycm9yIHBhdGggd2lsbAp1bmNvbmRp dGlvbmFsbHkgY2FsbCByZWd1bGF0b3JfZW5hYmxlKCkgd2l0aCBhIE5VTEwgcG9pbnRlciwgd2hp Y2ggd2lsbApjYXVzZSBhIGNyYXNoIHdoZW4gdGhlIGNvcmUgQVBJIGRlcmVmZXJlbmNlcyBpdC4K Cj4gKwkJCWlmIChyZXQyKQo+ICsJCQkJZGV2X2Vycihob3N0LT5oYmEtPmRldiwgIkZhaWxlZCB0 byByZS1lbmFibGUgYXZkZDA5LXN1cHBseTogJXBlXG4iLAo+ICsJCQkJCUVSUl9QVFIocmV0Mikp Owo+ICsKPiArCQkJdWZzX210a192YTA5X3B3cl9jdHJsKHJlcywgMSk7Cj4gKwkJCXJldHVybiBy ZXQ7Cj4gKwkJfQo+ICAJfQo+ICAKPiAgCXJldHVybiAwOwo+IEBAIC01MzUsMTQgKzU1NSwyNiBA QCBzdGF0aWMgaW50IHVmc19tdGtfMDl2X29uKHN0cnVjdCB1ZnNfbXRrX2hvc3QgKmhvc3QpCj4g IAlzdHJ1Y3QgYXJtX3NtY2NjX3JlcyByZXM7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCWlmICghaG9z dC0+cmVnX2F2ZGQwOSkKPiArCWlmICghaG9zdC0+cmVnX2F2ZGQwOSAmJiAhaG9zdC0+cmVnX2F2 ZGQwOV8xKQo+ICAJCXJldHVybiAwOwo+ICAKPiAtCXJldCA9IHJlZ3VsYXRvcl9lbmFibGUoaG9z dC0+cmVnX2F2ZGQwOSk7Cj4gLQlpZiAocmV0KSB7Cj4gLQkJZGV2X2Vycihob3N0LT5oYmEtPmRl diwgIkZhaWxlZCB0byBlbmFibGUgYXZkZDA5LXN1cHBseTogJXBlXG4iLAo+IC0JCQlFUlJfUFRS KHJldCkpOwo+IC0JCXJldHVybiByZXQ7Cj4gKwlpZiAoaG9zdC0+cmVnX2F2ZGQwOSkgewo+ICsJ CXJldCA9IHJlZ3VsYXRvcl9lbmFibGUoaG9zdC0+cmVnX2F2ZGQwOSk7Cj4gKwkJaWYgKHJldCkg ewo+ICsJCQlkZXZfZXJyKGhvc3QtPmhiYS0+ZGV2LCAiRmFpbGVkIHRvIGVuYWJsZSBhdmRkMDkt c3VwcGx5OiAlcGVcbiIsCj4gKwkJCQlFUlJfUFRSKHJldCkpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ ICsJCX0KPiArCX0KPiArCj4gKwlpZiAoaG9zdC0+cmVnX2F2ZGQwOV8xKSB7Cj4gKwkJcmV0ID0g cmVndWxhdG9yX2VuYWJsZShob3N0LT5yZWdfYXZkZDA5XzEpOwo+ICsJCWlmIChyZXQpIHsKPiAr CQkJZGV2X2Vycihob3N0LT5oYmEtPmRldiwgIkZhaWxlZCB0byBlbmFibGUgYXZkZDA5LTEtc3Vw cGx5OiAlcGVcbiIsCj4gKwkJCQlFUlJfUFRSKHJldCkpOwo+ICsJCQlyZWd1bGF0b3JfZGlzYWJs ZShob3N0LT5yZWdfYXZkZDA5KTsKCltTZXZlcml0eTogSGlnaF0KQ291bGQgdGhpcyBsZWFkIHRv IGEga2VybmVsIHBhbmljIGlmIGF2ZGQwOSBpcyBtaXNzaW5nIGZyb20gdGhlIGRldmljZSB0cmVl PwoKU2ltaWxhciB0byB0aGUgb2ZmIHBhdGgsIGlmIGhvc3QtPnJlZ19hdmRkMDkgaXMgTlVMTCBh bmQgZW5hYmxpbmcKcmVnX2F2ZGQwOV8xIGZhaWxzIGR1cmluZyBydW50aW1lLCBjYWxsaW5nIHJl Z3VsYXRvcl9kaXNhYmxlKCkgb24gYSBOVUxMCnBvaW50ZXIgd2lsbCByZXN1bHQgaW4gYW4gaW1t ZWRpYXRlIGNyYXNoLgoKU2hvdWxkIHRoZXJlIGJlIGEgY2hlY2sgdG8gZW5zdXJlIGhvc3QtPnJl Z19hdmRkMDkgaXMgbm90IE5VTEwgYmVmb3JlCmF0dGVtcHRpbmcgdG8gZGlzYWJsZSBvciBlbmFi bGUgaXQgaW4gdGhlc2UgZXJyb3IgcGF0aHM/Cgo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiAg CX0KPiAgCj4gIAl1ZnNfbXRrX3ZhMDlfcHdyX2N0cmwocmVzLCAxKTsKClsgLi4uIF0KCi0tIApT YXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA5 MTQtbXQ4MTk2LXVmcy12MTItMC05Mjc5ZDdlZjgxNGRAY29sbGFib3JhLmNvbT9wYXJ0PTgKCi0t IApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746B34499B0; Mon, 14 Sep 2026 12:21:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789388486; cv=none; b=b9Od9Yyhj51gSf3A0LEpnzNs00AD7n0IPfEW2pvCVEL0njQ8ZuQ3hmqdjfELpBL6tJCLOentbvyhvBSPwj4dlRy+KjIIkZkaFYovYafinqX01T5C5ykSgpNupreKhKrlPYoQBS5IPtJxSIF4egxPCW0T4o3a4QFy99BRXm1Wd1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789388486; c=relaxed/simple; bh=ApsZGKuPi3IwisuXYR4uVlRDKwOUYJO7HSStNuLCH7w=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=T55oHDPerPFIY6bh0+DllMlVcziF4OxBlSiaYdhkj7fd1n92xPphGRt0LmzXZ7rXHNueNowwo1VNm6uLw6LCTaydr9nyWkQowbDrz7OX3UXot4UjC531efKooAR8+5t2SGCfERiAwEtPYBF4yNNei263mahdB34xnpusNoGWlXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G0N4iX5T; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G0N4iX5T" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B80631F000FF; Mon, 14 Sep 2026 12:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789388485; bh=RBJbzxmO+Vl6+bOBg4GNP5t1gGxwYu+KqDZ/3fHyHIk=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=G0N4iX5TmB2lNBpvlydl6JqxmM1AKpVtLAjDNL1i6Yt1L8PK0xv+HrewAcKU2ytwu OyKy2AmZ03In+nGG45APhb9RHUSpPMGSJKIqNy+QDz4YbSxj+96Z/uTrOZQ9XLzrH/ Eb8TpDpnHX86KNhk99Speuzuf2skEP/NqRb2+I1weadNw6BSgjH9LEVg0roNOlZ9D/ cmxzzc8+xssCqPMkaMXcnQhfjdwJDv3YM8dZlos6BzptRevYt8JTTcuMdg65yk2GpX R5ZV8zojq26gKlvdLRQiPabtgD9T4tFNv8Y6WzUhFSfvy1mktjDzx/Kgt8u70QM20s i47R1fV5NMvtQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 08/24] scsi: ufs: mediatek: Add dual 0.9V supply support Reply-To: sashiko-reviews@lists.linux.dev To: "Louis-Alexis Eyraud" Cc: linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, linux-scsi@vger.kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260914-mt8196-ufs-v12-8-9279d7ef814d@collabora.com> References: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> <20260914-mt8196-ufs-v12-8-9279d7ef814d@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 14 Sep 2026 12:21:24 +0000 Message-Id: <20260914122124.B80631F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Unchecked NULL pointer dereference of optional regulator `host->re= g_avdd09` in error recovery paths. -- commit c69b1189125cd5106318d877fff7d1bf82dfd012 Author: Louis-Alexis Eyraud scsi: ufs: mediatek: Add dual 0.9V supply support This commit adds support for an additional 0.9V supply on the MT8196 SoC. It introduces a second optional 0.9V regulator named "avdd09-1" to the platform data and manages its enabling and disabling alongside the primary supply. > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-media= tek.c > index f43bee50adb28..467fc77c90e12 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c [ ... ] > @@ -513,18 +514,37 @@ static int ufs_mtk_wait_link_state(struct ufs_hba *= hba, u32 state, > static int ufs_mtk_09v_off(struct ufs_mtk_host *host) > { > struct arm_smccc_res res; > - int ret; > + int ret, ret2; > =20 > - if (!host->reg_avdd09) > + if (!host->reg_avdd09 && !host->reg_avdd09_1) > return 0; > =20 > ufs_mtk_va09_pwr_ctrl(res, 0); > - ret =3D regulator_disable(host->reg_avdd09); > - if (ret) { > - dev_err(host->hba->dev, "Failed to disable avdd09-supply: %pe\n", > - ERR_PTR(ret)); > - ufs_mtk_va09_pwr_ctrl(res, 1); > - return ret; > + > + if (host->reg_avdd09) { > + ret =3D regulator_disable(host->reg_avdd09); > + if (ret) { > + dev_err(host->hba->dev, "Failed to disable avdd09-supply: %pe\n", > + ERR_PTR(ret)); > + ufs_mtk_va09_pwr_ctrl(res, 1); > + return ret; > + } > + } > + > + if (host->reg_avdd09_1) { > + ret =3D regulator_disable(host->reg_avdd09_1); > + if (ret) { > + dev_err(host->hba->dev, "Failed to disable avdd09-1-supply: %pe\n", > + ERR_PTR(ret)); > + > + ret2 =3D regulator_enable(host->reg_avdd09); [Severity: High] Can this cause a NULL pointer dereference? Since host->reg_avdd09 is fetched using devm_regulator_get_optional(), it can be NULL if it is absent from the device tree. If a system only has the avdd09-1 supply configured and disabling it fails, this error path will unconditionally call regulator_enable() with a NULL pointer, which will cause a crash when the core API dereferences it. > + if (ret2) > + dev_err(host->hba->dev, "Failed to re-enable avdd09-supply: %pe\n", > + ERR_PTR(ret2)); > + > + ufs_mtk_va09_pwr_ctrl(res, 1); > + return ret; > + } > } > =20 > return 0; > @@ -535,14 +555,26 @@ static int ufs_mtk_09v_on(struct ufs_mtk_host *host) > struct arm_smccc_res res; > int ret; > =20 > - if (!host->reg_avdd09) > + if (!host->reg_avdd09 && !host->reg_avdd09_1) > return 0; > =20 > - ret =3D regulator_enable(host->reg_avdd09); > - if (ret) { > - dev_err(host->hba->dev, "Failed to enable avdd09-supply: %pe\n", > - ERR_PTR(ret)); > - return ret; > + if (host->reg_avdd09) { > + ret =3D regulator_enable(host->reg_avdd09); > + if (ret) { > + dev_err(host->hba->dev, "Failed to enable avdd09-supply: %pe\n", > + ERR_PTR(ret)); > + return ret; > + } > + } > + > + if (host->reg_avdd09_1) { > + ret =3D regulator_enable(host->reg_avdd09_1); > + if (ret) { > + dev_err(host->hba->dev, "Failed to enable avdd09-1-supply: %pe\n", > + ERR_PTR(ret)); > + regulator_disable(host->reg_avdd09); [Severity: High] Could this lead to a kernel panic if avdd09 is missing from the device tree? Similar to the off path, if host->reg_avdd09 is NULL and enabling reg_avdd09_1 fails during runtime, calling regulator_disable() on a NULL pointer will result in an immediate crash. Should there be a check to ensure host->reg_avdd09 is not NULL before attempting to disable or enable it in these error paths? > + return ret; > + } > } > =20 > ufs_mtk_va09_pwr_ctrl(res, 1); [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260914-mt8196-ufs= -v12-0-9279d7ef814d@collabora.com?part=3D8