From: Kumar Kartikeya Dwivedi <memxor@gmail.com>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Eduard Zingerman <eddyz87@gmail.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
Nicholas Carlini <npc@anthropic.com>,
kkd@meta.com, kernel-team@meta.com
Subject: [PATCH bpf v3 0/2] Fix global subprog verification context
Date: Mon, 14 Sep 2026 15:19:19 +0200 [thread overview]
Message-ID: <20260914131923.2544250-1-memxor@gmail.com> (raw)
Global subprogs can be invoked in both sleepable and non-sleepable
contexts, but are verified based on context assumptions for the program
type as a whole and not the precise context in which they are invoked.
Nicholas identified that this can violate verifier safety assumptions.
Verify global subprogs once for each observed sleepability context and add
workqueue callback regression tests.
Changelog:
----------
v2 -> v3
v2: https://lore.kernel.org/bpf/20260905051224.2325381-1-memxor@gmail.com
* Clarify that globals are checked only in contexts from which they are
reached, with two passes only when both contexts occur. (Alexei)
* Implement in_sleepable_context() as !in_rcu_cs(). (Alexei, Eduard)
* Keep the original subprogram traversal order and repeat until all
called contexts have been verified. (Eduard)
* Explain why instruction accounting needs the saved total and why the
exception callback uses the main program's context. (Eduard)
* Rename the do_check_common() parameter to is_sleepable. (BPF CI)
* Preserve the harmless global calls with __weak __noinline and check
their instruction totals across both contexts. Drop the redundant
task-work global RCU test and retain the review acknowledgment. (Eduard)
v1 -> v2
v1: https://lore.kernel.org/bpf/20260905034018.2095649-1-memxor@gmail.com
* Preserve the harmless global subprog calls in the positive test with
barrier() so LLVM cannot eliminate the intended coverage.
* Return zero explicitly from workqueue callbacks after global subprog calls.
* Document cumulative instruction accounting across verification contexts.
* Fix BPF multi-line comment formatting.
Kumar Kartikeya Dwivedi (2):
bpf: Verify global subprogs in each sleepability context
selftests/bpf: Test global subprog callback contexts
include/linux/bpf.h | 5 +-
kernel/bpf/verifier.c | 71 ++++++------
.../bpf/progs/verifier_async_cb_context.c | 106 ++++++++++++++++++
3 files changed, 146 insertions(+), 36 deletions(-)
base-commit: 29fcf9ce4bbdf4cc339def776860e1c0095bca98
--
2.53.0
next reply other threads:[~2026-09-14 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 13:19 Kumar Kartikeya Dwivedi [this message]
2026-09-14 13:19 ` [PATCH bpf v3 1/2] bpf: Verify global subprogs in each sleepability context Kumar Kartikeya Dwivedi
2026-09-15 7:50 ` Eduard Zingerman
2026-09-14 13:19 ` [PATCH bpf v3 2/2] selftests/bpf: Test global subprog callback contexts Kumar Kartikeya Dwivedi
2026-09-14 13:27 ` [PATCH bpf v3 0/2] Fix global subprog verification context Kumar Kartikeya Dwivedi
2026-09-15 7:51 ` Eduard Zingerman
2026-09-16 17:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914131923.2544250-1-memxor@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=kernel-team@meta.com \
--cc=kkd@meta.com \
--cc=npc@anthropic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.