From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C32FC88E50 for ; Mon, 14 Sep 2026 13:25:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0g9xvZBH1i4Juob1r18OTkXx1VnrIoCMrbldmNoLL1c=; b=O6NJreJsTrC1/9 FJitAb5eNt+y7jkOa1dq+UfJohNsRZuJ88V/GB2EUPCvKgsDycTDqhIhynQhuPtPwhKjhgEIMS5k9 Ex34WpScEDBJTFD/AFXxV3atQ69zFz5Sfrf9G8Gu/6ojsrSOUbB2fvFkq3qHqGiN+u/2nNeC4rCS6 AtEbNzT54ZVSPUpd+nsPYkbMVAXxQ92z1rFBpVn6dH80pgcGDlc7B8zHX76Am5CVle5b+jjq9FE7I RxbJj3H/IibUufbAVnxsrFa4vL2w3fMm5umqxHatq7K7qf21NKNyfokCTEFc+G+5Ag5GYZWak3BgI eZJfKnfCxatDa2e5sinQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x66gf-00000003kds-0lQV; Mon, 14 Sep 2026 13:25:33 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x66ge-00000003kdV-1PfS for linux-phy@lists.infradead.org; Mon, 14 Sep 2026 13:25:32 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 71320601DE; Mon, 14 Sep 2026 13:25:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2E761F000FF; Mon, 14 Sep 2026 13:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789392331; bh=Rry/0ntt2y+SFc/0AThu1SLgcoTiaKx70bKXtE6pHoA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KFeULYDdlytz8FK+lGByfjXmtWTj7607kz7hGP9ZR48PcA0vhNkw7FwF84G2OkRhU JaFzn7vGRC2g77EezEWnbU6mS7HWp7H3S+Y5MouoG+D0VcWRD00qpO96ShHqXRriNd 7BLjuz/WO8GeVioXuxFz7PWnkmz8WM6oSZ51wZK4jwKpfSz6BgIGAJPR2mNrmvfbb4 EToefo2A1HbQJDnEveRG1PhAitidgId5V+00EFXQDc3GjRQ801ywdYF6522EV6ANBi Ntoen1b6w00TZrbIeN5uZneTc7u70lLgtpauxzNXtM8TlBRnKHdoFAS3mldd+v/qZj Jq8hmQIs9cdjQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 23/24] scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" To: "Louis-Alexis Eyraud" Cc: vkoul@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org In-Reply-To: <20260914-mt8196-ufs-v12-23-9279d7ef814d@collabora.com> References: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> <20260914-mt8196-ufs-v12-23-9279d7ef814d@collabora.com> Date: Mon, 14 Sep 2026 13:25:30 +0000 Message-Id: <20260914132530.A2E761F000FF@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBDbG9jayBzY2FsaW5nIHN0YXRlIGlzIHVwZGF0ZWQgdW5jb25kaXRpb25hbGx5IGV2 ZW4gaWYgY2xvY2sgb3BlcmF0aW9ucyBmYWlsLCBhbmQgcGFydGlhbCByZXBhcmVudGluZyBpcyBu b3QgcmV2ZXJ0ZWQuCi0tCgpjb21taXQgNDJhYWFhODFkNTliNWYxMzhiYjYwYzBlODEzMDY4NDUy MzZmMzI1OQpBdXRob3I6IE5pY29sYXMgRnJhdHRhcm9saSA8bmljb2xhcy5mcmF0dGFyb2xpQGNv bGxhYm9yYS5jb20+CgpzY3NpOiB1ZnM6IG1lZGlhdGVrOiBSZW1vdmUgdW5kb2N1bWVudGVkICJj bGstc2NhbGUtdXAtdmNvcmUtbWluIgoKVGhlIE1lZGlhVGVrIFVGUyBkcml2ZXIgY29udGFpbnMg c3VwcG9ydCBmb3IgYW4gdW5kb2N1bWVudGVkLApub24tdmVuZG9yLXByZWZpeGVkIHUzMiBwcm9w ZXJ0eSBuYW1lZCAiY2xrLXNjYWxlLXVwLXZjb3JlLW1pbiIuClNpbmNlIGl0IGlzIG5vdCBwYXJ0 IG9mIGFueSBiaW5kaW5nLCB0aGlzIHBhdGNoIHJlbW92ZXMgaXQuCgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5jIGIvZHJpdmVycy91ZnMvaG9zdC91ZnMtbWVk aWF0ZWsuYwo+IGluZGV4IDJlYmY3YTMxMThkYWIuLmVmODkyNDcwNGM5MDIgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy91ZnMvaG9zdC91ZnMtbWVkaWF0ZWsuYwo+ICsrKyBiL2RyaXZlcnMvdWZzL2hv c3QvdWZzLW1lZGlhdGVrLmMKWyAuLi4gXQo+IEBAIC0yMDAwLDE0ICsxOTc2LDYgQEAgc3RhdGlj IHZvaWQgX3Vmc19tdGtfY2xrX3NjYWxlKHN0cnVjdCB1ZnNfaGJhICpoYmEsIGJvb2wgc2NhbGVf dXApCj4gIAl9Cj4gIAo+ICAJaWYgKHNjYWxlX3VwKSB7Cj4gLQkJaWYgKGNsa19iaW5kX3Zjb3Jl KSB7Cj4gLQkJCXJldCA9IHJlZ3VsYXRvcl9zZXRfdm9sdGFnZShob3N0LT5yZWdfdmNvcmUsIHZv bHQsIElOVF9NQVgpOwo+IC0JCQlpZiAocmV0KSB7Cj4gLQkJCQlkZXZfZXJyKGhiYS0+ZGV2LCAi RmFpbGVkIHRvIHNldCB2Y29yZSB0byAlZFxuIiwgdm9sdCk7Cj4gLQkJCQlnb3RvIG91dDsKPiAt CQkJfQo+IC0JCX0KPiAtCj4gIAkJcmV0ID0gY2xrX3NldF9wYXJlbnQoY2xraS0+Y2xrLCBtY2xr LT51ZnNfc2VsX21heF9jbGtpLT5jbGspOwo+ICAJCWlmIChyZXQpIHsKPiAgCQkJZGV2X2Vyciho YmEtPmRldiwgIiVzOiBGYWlsZWQgdG8gc2V0IGNsb2NrIG11eDogJXBlXG4iLAo+ICAJCQkJX19m dW5jX18sIEVSUl9QVFIocmV0KSk7Cj4gIAkJCWdvdG8gb3V0Owo+ICAJCX0KCltTZXZlcml0eTog SGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IEkgbm90aWNlZCB0aGF0IGlm IGNsa19zZXRfcGFyZW50KCkgc3VjY2VlZHMKaGVyZSwgYnV0IHRoZSBzdWJzZXF1ZW50IHJlcGFy ZW50aW5nIGZvciBmZGVfY2xraS0+Y2xrIGZhaWxzLCB0aGUgZnVuY3Rpb24KanVtcHMgdG8gdGhl IGNsZWFudXAgYmxvY2sgd2l0aG91dCByZXZlcnRpbmcgdGhpcyBzdWNjZXNzZnVsIHBhcmVudCBz d2l0Y2g6CgoJCWlmIChjbGtfZmRlX3NjYWxlKSB7CgkJCXJldCA9IGNsa19zZXRfcGFyZW50KGZk ZV9jbGtpLT5jbGssIG1jbGstPnVmc19mZGVfbWF4X2Nsa2ktPmNsayk7CgkJCWlmIChyZXQpIHsK CQkJCWRldl9lcnIoaGJhLT5kZXYsICIlczogRmFpbGVkIHRvIHNldCBmZGUgY2xvY2sgbXV4OiAl cGVcbiIsCgkJCQkJX19mdW5jX18sIEVSUl9QVFIocmV0KSk7CgkJCQlnb3RvIG91dDsKCQkJfQoJ CX0KCkJlY2F1c2UgX3Vmc19tdGtfY2xrX3NjYWxlKCkgcmV0dXJucyB2b2lkLCB0aGUgY2FsbGVy IHVmc19tdGtfY2xrX3NjYWxlKCkgaGFzCm5vIHdheSB0byBrbm93IHRoYXQgdGhlIGhhcmR3YXJl IG9wZXJhdGlvbnMgcGFydGlhbGx5IGZhaWxlZCwgYW5kIGl0CnVuY29uZGl0aW9uYWxseSB1cGRh dGVzIHRoZSBzb2Z0d2FyZSBzdGF0ZSBhbnl3YXk6Cgpkcml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRp YXRlay5jOnVmc19tdGtfY2xrX3NjYWxlKCkgewogICAgLi4uCglfdWZzX210a19jbGtfc2NhbGUo aGJhLCBzY2FsZV91cCk7CgoJaG9zdC0+Y2xrX3NjYWxlX3VwID0gc2NhbGVfdXA7CgoJLyogTXVz dCBhbHdheXMgc2V0IGJlZm9yZSBjbGtfc2V0X3JhdGUoKSAqLwoJaWYgKHNjYWxlX3VwKQoJCWNs a2ktPmN1cnJfZnJlcSA9IGNsa2ktPm1heF9mcmVxOwoJZWxzZQoJCWNsa2ktPmN1cnJfZnJlcSA9 IGNsa2ktPm1pbl9mcmVxOwogICAgLi4uCn0KCldpbGwgdGhpcyBwZXJtYW5lbnRseSBkZXN5bmNo cm9uaXplIHRoZSBoYXJkd2FyZSBhbmQgc29mdHdhcmUgc3RhdGVzIGlmIGNsb2NrCnJlcGFyZW50 aW5nIGZhaWxzLCBsZWF2aW5nIHRoZSBVRlMgY29udHJvbGxlciBpbiBhIGJyb2tlbiBtaXhlZC1j bG9jayBzdGF0ZQp3aGVyZSBmdXR1cmUgc2NhbGluZyByZXF1ZXN0cyBhcmUgaWdub3JlZD8KCi0t IApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAy NjA5MTQtbXQ4MTk2LXVmcy12MTItMC05Mjc5ZDdlZjgxNGRAY29sbGFib3JhLmNvbT9wYXJ0PTIz CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0EB45198E; Mon, 14 Sep 2026 13:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789392333; cv=none; b=YcsTk117EKT1iB6Sz1Id2rbDL/0ThGfDSFypK2qu5AKaVDVcPSsMb2512X7URF85GYSK5UYFF0nKZU83uokYhik0LWQaDulpr9oD3O6OS4bR0T5tn5Bl/MJDxp1BL725so5a3W1PU8S8fZ9NzUFDSi9bvrEWliIgt/3bYS5Aia0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789392333; c=relaxed/simple; bh=5zPQx9oSaj57aNTmom7FrNbh88NFxTRzMOMkSFLR2jk=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=UgE9bd6FlqqNC6aOFKlz7cPJF8YM1vSo40UNX3igP8C/qUY+XuuP2y4CxANu6WiTD3MaAMuENXJN+tI/OisujxtZFi38Tlf5v7MuRgMz5V7kV7gInILaILsBy5NHV6zvGBorYoZVdpJpw1f0Z+Pl5F2Bfv1IHpG+j6JmoNZwhZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KFeULYDd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KFeULYDd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2E761F000FF; Mon, 14 Sep 2026 13:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789392331; bh=Rry/0ntt2y+SFc/0AThu1SLgcoTiaKx70bKXtE6pHoA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KFeULYDdlytz8FK+lGByfjXmtWTj7607kz7hGP9ZR48PcA0vhNkw7FwF84G2OkRhU JaFzn7vGRC2g77EezEWnbU6mS7HWp7H3S+Y5MouoG+D0VcWRD00qpO96ShHqXRriNd 7BLjuz/WO8GeVioXuxFz7PWnkmz8WM6oSZ51wZK4jwKpfSz6BgIGAJPR2mNrmvfbb4 EToefo2A1HbQJDnEveRG1PhAitidgId5V+00EFXQDc3GjRQ801ywdYF6522EV6ANBi Ntoen1b6w00TZrbIeN5uZneTc7u70lLgtpauxzNXtM8TlBRnKHdoFAS3mldd+v/qZj Jq8hmQIs9cdjQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 23/24] scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" Reply-To: sashiko-reviews@lists.linux.dev To: "Louis-Alexis Eyraud" Cc: vkoul@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, linux-scsi@vger.kernel.org, linux-phy@lists.infradead.org In-Reply-To: <20260914-mt8196-ufs-v12-23-9279d7ef814d@collabora.com> References: <20260914-mt8196-ufs-v12-0-9279d7ef814d@collabora.com> <20260914-mt8196-ufs-v12-23-9279d7ef814d@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 14 Sep 2026 13:25:30 +0000 Message-Id: <20260914132530.A2E761F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Clock scaling state is updated unconditionally even if clock opera= tions fail, and partial reparenting is not reverted. -- commit 42aaaa81d59b5f138bb60c0e81306845236f3259 Author: Nicolas Frattaroli scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" The MediaTek UFS driver contains support for an undocumented, non-vendor-prefixed u32 property named "clk-scale-up-vcore-min". Since it is not part of any binding, this patch removes it. > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-media= tek.c > index 2ebf7a3118dab..ef8924704c902 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c [ ... ] > @@ -2000,14 +1976,6 @@ static void _ufs_mtk_clk_scale(struct ufs_hba *hba= , bool scale_up) > } > =20 > if (scale_up) { > - if (clk_bind_vcore) { > - ret =3D regulator_set_voltage(host->reg_vcore, volt, INT_MAX); > - if (ret) { > - dev_err(hba->dev, "Failed to set vcore to %d\n", volt); > - goto out; > - } > - } > - > ret =3D clk_set_parent(clki->clk, mclk->ufs_sel_max_clki->clk); > if (ret) { > dev_err(hba->dev, "%s: Failed to set clock mux: %pe\n", > __func__, ERR_PTR(ret)); > goto out; > } [Severity: High] This is a pre-existing issue, but I noticed that if clk_set_parent() succee= ds here, but the subsequent reparenting for fde_clki->clk fails, the function jumps to the cleanup block without reverting this successful parent switch: if (clk_fde_scale) { ret =3D clk_set_parent(fde_clki->clk, mclk->ufs_fde_max_clki->clk); if (ret) { dev_err(hba->dev, "%s: Failed to set fde clock mux: %pe\n", __func__, ERR_PTR(ret)); goto out; } } Because _ufs_mtk_clk_scale() returns void, the caller ufs_mtk_clk_scale() h= as no way to know that the hardware operations partially failed, and it unconditionally updates the software state anyway: drivers/ufs/host/ufs-mediatek.c:ufs_mtk_clk_scale() { ... _ufs_mtk_clk_scale(hba, scale_up); host->clk_scale_up =3D scale_up; /* Must always set before clk_set_rate() */ if (scale_up) clki->curr_freq =3D clki->max_freq; else clki->curr_freq =3D clki->min_freq; ... } Will this permanently desynchronize the hardware and software states if clo= ck reparenting fails, leaving the UFS controller in a broken mixed-clock state where future scaling requests are ignored? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260914-mt8196-ufs= -v12-0-9279d7ef814d@collabora.com?part=3D23