All of lore.kernel.org
 help / color / mirror / Atom feed
From: Navon John Lukose <navonjohnlukose@gmail.com>
To: hansg@kernel.org, ikepanhc@gmail.com, ilpo.jarvinen@linux.intel.com
Cc: Navon John Lukose <navonjohnlukose@gmail.com>,
	mpearson-lenovo@squebb.ca, derekjohn.clark@gmail.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: ideapad-laptop: Add Yoga Pro 7 14IAH10 Mode key
Date: Mon, 14 Sep 2026 19:12:02 +0530	[thread overview]
Message-ID: <20260914134202.1295307-1-navonjohnlukose@gmail.com> (raw)
In-Reply-To: <2eab84cb-6d2f-4ec3-9869-e2aa9c1d75da@kernel.org>

On 14-Sep-26 2:40 PM, Hans de Goede wrote:
> So I guess that you maybe also have Fn + Q or something which already
> directly switches profile ?  If you do then KEY_PROG4 seems fine.

Fn+Q does, by a different path than the Mode key:

  Mode key (F9)  WMI fn-key 0x46, platform_profile unchanged
  Fn+Q           VPC special button, platform_profile_cycle() from
                 ideapad_acpi_notify(), no WMI event

(Used LLMs to hunt the Fn+Q path down.)

So cycling on 0x46 would duplicate Fn+Q. Keeping KEY_PROG4, and added
a comment in v2 saying why.

      reply	other threads:[~2026-09-14 13:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 22:47 [PATCH] platform/x86: ideapad-laptop: Add Yoga Pro 7 14IAH10 Mode key Navon John Lukose
2026-09-14 12:40 ` Hans de Goede
2026-09-14 13:42   ` Navon John Lukose [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914134202.1295307-1-navonjohnlukose@gmail.com \
    --to=navonjohnlukose@gmail.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.