Re: [PATCH 3/6] selftests/damon: add script dir to sys.path for PYTHONSAFEPATH compatibility

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch incompletely fixes PYTHONSAFEPATH compatibility by omitting 3 out of 10 DAMON Python selftests, creating an inconsistent state and a commit message mismatch.
--

commit da82d013622fc33202048b811231e1ede806c92f
Author: Eva Kurchatova <eva.kurchatova@virtuozzo.com>

selftests/damon: add script dir to sys.path for PYTHONSAFEPATH compatibility

This commit adds the script's directory to sys.path for seven DAMON Python
selftests to ensure they can import the _damon_sysfs helper module when
run under Python's safe path mode.

> This breaks all 7 DAMON Python selftests that import the _damon_sysfs
> helper module located in the same directory:

[Severity: Medium]
Are there additional DAMON Python selftests that also need this fix?

The commit message states there are 7 tests, but it appears 3 additional
tests in the same directory also import _damon_sysfs and were omitted
from this patch.

For example, in tools/testing/selftests/damon/sysfs.py:
    import _damon_sysfs

And in tools/testing/selftests/damon/sysfs_refresh.py:
    import _damon_sysfs

And in tools/testing/selftests/damon/sysfs_no_op_commit_break.py:
    import _damon_sysfs

Will these scripts still fail with a ModuleNotFoundError when run in
environments that enforce PYTHONSAFEPATH=1?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914141952.91465-1-sj@kernel.org?part=3