From: Stanley Jhu <stanleyjhu@google.com>
To: beanhuo@iokpp.de, jenswi@kernel.org, mkp@kernel.org
Cc: gregkh@linuxfoundation.org, arnd@arndb.de, bvanassche@acm.org,
avri.altman@sandisk.com, alim.akhtar@samsung.com,
beanhuo@micron.com, can.guo@oss.qualcomm.com, ulfh@kernel.org,
linusw@kernel.org, shyamsaini@linux.microsoft.com,
alex.bennee@linaro.org, James.Bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Stanley Jhu <stanleyjhu@google.com>
Subject: Re: [PATCH v4 3/3] scsi: ufs: rpmb: Drop the unregistered ufs_rpmb bus
Date: Mon, 14 Sep 2026 22:48:54 +0800 [thread overview]
Message-ID: <20260914144854.931149-1-stanleyjhu@google.com> (raw)
In-Reply-To: <b07b648dd0e914e2f6d10fcfd90225c1ae83a8cb.camel@iokpp.de>
On Mon, 2026-09-14 at 12:05 +0200, Bean Huo wrote:
> "has always failed" is not correct, bus_add_device() only started rejecting
> devices on an unregistered bus after this commit:
> 36f35b8df697 ("driver core: reject devices with unregistered buses").
> Before that, device_register() succeeded and the device was just not added to
> the bus, so UFS RPMB did register until that commit 36f35b8df697.
You are right, and the consequence is larger than the wording. I built
two kernels from the same base with the same config, the only difference
being a revert of 36f35b8df697, with none of this series applied:
base: /sys/class/rpmb empty, one "cannot add device"
36f35b8df697 reverted: rpmb0..rpmb3, four regions registered
After unbinding the host, the reverted kernel still has all four devices
in /sys/class/rpmb while /sys/class/scsi_device is empty.
So the leak that patch 2 fixes is real on v6.19 through v7.1, and this
patch re-enables what v7.2-rc1 disabled.
v5 restores Cc: stable on both UFS patches. The cover letter cites
36f35b8df697 with the measurement above, and notes that a backport
needs all three patches in order.
prev parent reply other threads:[~2026-09-14 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 3:36 [PATCH v4 0/3] rpmb: Fix request serialisation and teardown races Stanley Jhu
2026-09-13 3:36 ` [PATCH v4 1/3] rpmb: core: Guard frame requests and teardown with mutex Stanley Jhu
2026-09-13 17:43 ` Bean Huo
2026-09-13 3:36 ` [PATCH v4 2/3] scsi: ufs: rpmb: Decouple device lifecycle from devres to avoid UAF Stanley Jhu
2026-09-13 3:47 ` sashiko-bot
2026-09-13 5:07 ` Stanley Jhu
2026-09-14 9:55 ` Bean Huo
2026-09-14 14:48 ` Stanley Jhu
2026-09-13 3:36 ` [PATCH v4 3/3] scsi: ufs: rpmb: Drop the unregistered ufs_rpmb bus Stanley Jhu
2026-09-14 10:05 ` Bean Huo
2026-09-14 14:48 ` Stanley Jhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914144854.931149-1-stanleyjhu@google.com \
--to=stanleyjhu@google.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alex.bennee@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=avri.altman@sandisk.com \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=can.guo@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jenswi@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
--cc=shyamsaini@linux.microsoft.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.