From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f12.google.com (mail-wm2-f12.google.com [74.125.225.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 946CC463B9C for ; Mon, 14 Sep 2026 12:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789390426; cv=none; b=QFMDADufhZBoS7suZBC6y4ImWVEwVQQk7abib8cDEKUDTrdGbzvHiurEBD/RdPYip/KXPMPggdYXcuPEePPwmOxVHjsqgeNeRL+DStplNUTpuvV32SSrcdWeAAFuXh12r9L4MNa5VhLvZwBRCUNg3+7xOhQ5kjPl7yQOc7vO45Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789390426; c=relaxed/simple; bh=QFR4oJCQoT55aHU4M/DQq6HQtEWMLxoilJJqgI/UOQI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kHa2VFwT52m/JgUNQGnbRuvOWKj/LeUkYkC5syRA/9L+QGm0ixt0lBE8IHrUFVkXCxiR7y492cXXMy8F4v0Wx5av/R2hAGeNEHrmDhUr4e1WzM1Hfkdgd/v/JqNBPjlp2whjqdi5LbycH1cnmZz1nRdjkRlHEbJTTLrbKx8xCgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qdWL0Jbn; arc=none smtp.client-ip=74.125.225.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qdWL0Jbn" Received: by mail-wm2-f12.google.com with SMTP id 5b1f17b1804b1-49ce364488dso6018635e9.0 for ; Mon, 14 Sep 2026 05:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789390422; x=1789995222; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=UNtSulrcCSblkD0zfddb8JAGFbCKZWTczcGLRiEHaKU=; b=qdWL0JbnDozphQNdlP1muH1HnmyszbEu4UE9OHf6KlfTAqiYdLyrLYWyxQx1KHbqu2 oZBFmUkXmJIlGwRz43T4Yj1JoPT/bZFNxd2cDsf4YrDmOZ1HcUAJkkJ3qpyWP4SZpvCx M/K5hDW64yoCoseFLbn0DIbGqmLJ6M0Cl6kFL3hYt1vIqt36GWk1KWrA899UpCOUMdfj i8HWUyIDh272zW7xFEfqXbZkMrsv+8TOSJqLECp0PUZH9GJ850+ldv1pUmv04L0m70U4 PxP9lNmJuc1tvBYHKNEDAiF/fHFfXJ7ABjkLRWlhXSZKiRupQ2gnRpPiy5DRShHNSeV+ UYqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789390422; x=1789995222; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UNtSulrcCSblkD0zfddb8JAGFbCKZWTczcGLRiEHaKU=; b=E72jUwAmiStlSk0jCupgcU+KQWsMVVYasMVF2RzrgF1AgXPDlXzqf5ujLCoBfFSqCU dbLi/AzUXpVMuUJp86FZyrCUv71Fm70lM8QBzAqrnq1NqTFgxv3XnafSG5geUk0NjcTl YxLwnF+tgihDCppa1l/hLFOeasdUS7+oqMD34y7xqxKrs5sA+4WmeljRh+kwgrbQk1U5 ZFr0iEjZDRkkBpse0ZaZkubYKdZwUoUT5PhM2L4ilSam6178MQZchLz8xLa4zE/g0vhR vdxJ/ETdBNwfjPpsvXviUccWF88JIklMpPwnvX7vKzOZ1JDET/qTmJNMDu1nl+vjnMvw KobQ== X-Forwarded-Encrypted: i=1; AKwUvBwkuWavkryhGU7D8cmBVwXzUn40h0m0RwEj6qnrrUzvKYv+SvFT+bCBwm6jw0jTFNExfUAvffPgDC4=@vger.kernel.org X-Gm-Message-State: AFuF++lAoZ0lwUVk/oOXt5Zd7oi/r8e7QfSiqK2k3DbJhpvxSlDM7+xN NYNxIh060UvXpCaXBVCA/R/XRCwlEslsaWhNC7bQyG+agKZ6CcSIszJ6 X-Gm-Gg: AYBFou25UnLQH81Bdao6QOENkybik5PDnFwZU2i8jkIkOYrNMNVTxM7kP+BRfbAldbe jz11KJXBTt+tMm0Xjw/7IhOwE7TaEYmMQYz0drEpcRJRLuAfJBhctIT3LenXZXigyNcGo8zkupL HiyoFEiDow+iD8Pur0hyhemZZayY5o9Gl9HF01VmS8x4fkfo+qlsYFrc/Myyel2skqODbS/SXdk koGVQWSaTh2rtaVF0THO4Ia/2gWykDeqlYtDK0vDqJ2DxNF3EWko0gZLweVyywlHxyCv53V4Awm yW2UWIcfPwrWHCUsbehK3JQv2voLv/IfsBp3sF13XZmx+DW7Gt1LU6fyXLbwk+pTj5srMtV/siH ji07CKHQOoFfsHhpZrkr+REy3G3/oYa5iEyLzft8snIQXMPGQQTWYsv/724FqDyszRRPek8HI6h SVaP1/qm5auOISdvg5vwYJzaPRccyqbFG1JYgqw4WdGrPJrQQls9mBD/d8LbbPrInSc/YLtxpfc 95ZXhiD/SqOdurJcl6kWyroCXsDC52C0RO+xQcwGKElUl7J7SLngUsdTT/GdJGose22rhbUWu1T R7G95p+xkF2J82RjLqyMYLXGUA5C5A4V5u3djLYmrOPy+BfIm+jRg/yiodzmWG0a2E8HboPeyEo siffoyCJ8hqNJfEgxvJ3NU4VK8zSRYdUTahwCpjEW55F9KeN8chHcmp/gT6HgPPr5Vte/8+CyAg HH4z42 X-Received: by 2002:a05:600d:8490:10b0:49d:1e79:35d6 with SMTP id 5b1f17b1804b1-49e7cf551e6mr4118455e9.14.1789390422542; Mon, 14 Sep 2026 05:53:42 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49e62231360sm218704995e9.4.2026.09.14.05.53.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 05:53:42 -0700 (PDT) Date: Mon, 14 Sep 2026 14:53:39 +0200 From: Joshua Crofts To: Guangshuo Li Cc: Eugen Hristev , Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] iio: adc: at91-sama5d2: disable autosuspend on remove Message-ID: <20260914145339.00002f0b@gmail.com> In-Reply-To: <20260914113422.1689331-1-lgs201920130244@gmail.com> References: <20260914113422.1689331-1-lgs201920130244@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 14 Sep 2026 19:34:22 +0800 Guangshuo Li wrote: > at91_adc_probe() enables runtime PM autosuspend with > pm_runtime_use_autosuspend(). The probe error path correctly undoes > this setting with pm_runtime_dont_use_autosuspend(), but the normal > remove path only disables runtime PM. > > The runtime PM API requires pm_runtime_use_autosuspend() to be undone > with pm_runtime_dont_use_autosuspend() at driver exit unless runtime PM > was enabled with devm_pm_runtime_enable(). Leaving the autosuspend flag > set therefore leaves the runtime PM state incompletely cleaned up after > the driver is unbound. > > Add the missing pm_runtime_dont_use_autosuspend() call to the remove > path. > > This issue was found by manual code inspection. > > Fixes: 75d7556ac0e4 ("iio: adc: at91-sama5d2_adc: add runtime pm support") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > drivers/iio/adc/at91-sama5d2_adc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index e8a5285bb6d4..e68632e628c7 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -2487,6 +2487,7 @@ static void at91_adc_remove(struct platform_device *pdev) > > pm_runtime_disable(st->dev); > pm_runtime_set_suspended(st->dev); > + pm_runtime_dont_use_autosuspend(st->dev); > clk_disable_unprepare(st->per_clk); > > regulator_disable(st->vref); Reviewed-by: Joshua Crofts -- Kind regards, Joshua Crofts