Re: [PATCH v51 6/7] arm64: dts: imx8ulp: add secure enclave node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately states that a label was added for `sram@2201f000`, when in fact the label was added to the parent `sram@22010000` node.
--

commit 54e1057c5cc05f686747858b82632103c75a6b80
Author: Pankaj Gupta <pankaj.gupta@nxp.com>

arm64: dts: imx8ulp: add secure enclave node

This commit adds the EdgeLock Enclave secure-enclave node to the i.MX8ULP
SoC dtsi. It also provides a label to the SRAM node so it can be referenced
by the secure enclave.

>     Add the EdgeLock Enclave (ELE) secure-enclave node to the i.MX8ULP SoC
>     dtsi, together with a label for sram@2201f000 that the node references.

[Severity: Medium]
Could this commit message be updated to reflect the actual node modified?

The message states a label was added for sram@2201f000, but the diff shows
the sram0 label is actually added to the parent node at sram@22010000.

> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index 777b89ed68490..ac8293f81c6b2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi

[ ... ]

> @@ -154,7 +154,7 @@ sosc: clock-sosc {
>  		#clock-cells = <0>;
>  	};
>  
> -	sram@22010000 {
> +	sram0: sram@22010000 {
>  		compatible = "mmio-sram";
>  		reg = <0x0 0x22010000 0x0 0x10000>;
>  

The address 0x2201f000 corresponds to the scmi-sram-section@f000 child node
instead. The code itself appears to be functionally correct since the driver
expects the parent mmio-sram node for its gen_pool, but the commit message
description of the address is misleading.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-imx-se-if-v51-0-4a7dac612cb5@nxp.com?part=6