From: Michal Pecio <michal.pecio@gmail.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: 胡连勤 <hulianqin@vivo.com>,
"Selvarasu Ganesan" <selvarasu.g@samsung.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"quic_wcheng@quicinc.com" <quic_wcheng@quicinc.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cpgs@samsung.com" <cpgs@samsung.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"thiagu.r@samsung.com" <thiagu.r@samsung.com>,
"Niklas Neronin" <niklas.neronin@linux.intel.com>
Subject: Re: [PATCH] xhci: sideband: check vdev liveness before removing endpoints on unregister
Date: Mon, 14 Sep 2026 17:34:03 +0200 [thread overview]
Message-ID: <20260914173403.05d1bca1.michal.pecio@gmail.com> (raw)
In-Reply-To: <9d326c6e-f033-495c-a5e1-dacb46ea7b73@linux.intel.com>
On Mon, 14 Sep 2026 17:06:35 +0300, Mathias Nyman wrote:
> > Selvarasu Ganesan pointed out that xhci 'core' in fact doesn't
> > include xhci-sideband.h yet. If possible I'd like to keep it that
> > way.
> >
> > Setting xhci->sideband->vdev to NULL, or calling a callback here
> > changes this and is the first time we then intertwine xhci core
> > with sideband.
>
> Disregard the above, I forgot about the
> xhci_sideband_notify_ep_ring_free() call in
> xhci_discover_or_reset_device().
You aren't entirely wrong, xhci_sideband_notify_ep_ring_free() isn't
useful to sideband clients so it could be declared in "xhci.h" instead
of <xhci-sideband.h>. Then xhci.c won't need the public API header.
This function is also exported unnecessarily. Another unused export is
xhci_stop_endpoint_sync(), because sideband hasn't become new module.
Regards,
Michal
next prev parent reply other threads:[~2026-09-14 15:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:24 [PATCH] xhci: sideband: check vdev liveness before removing endpoints on unregister 胡连勤
2026-09-10 9:34 ` Mathias Nyman
2026-09-10 11:10 ` Selvarasu Ganesan
2026-09-10 12:11 ` 答复: " 胡连勤
2026-09-10 13:50 ` Mathias Nyman
2026-09-11 5:10 ` Selvarasu Ganesan
2026-09-11 7:29 ` 答复: " 胡连勤
2026-09-11 8:41 ` Selvarasu Ganesan
2026-09-11 13:10 ` Mathias Nyman
2026-09-11 14:49 ` 答复: " 胡连勤
2026-09-12 12:18 ` Michal Pecio
2026-09-14 7:04 ` 答复: " 胡连勤
2026-09-14 9:09 ` Michal Pecio
2026-09-14 12:24 ` 答复: " 胡连勤
2026-09-14 13:09 ` Mathias Nyman
2026-09-14 14:06 ` Mathias Nyman
2026-09-14 15:34 ` Michal Pecio [this message]
2026-09-15 2:57 ` 答复: " 胡连勤
2026-10-02 10:12 ` 胡连勤
2026-10-06 19:07 ` Mathias Nyman
2026-10-08 3:23 ` 答复: " 胡连勤
2026-09-14 12:26 ` Mathias Nyman
2026-09-14 13:00 ` 答复: " 胡连勤
2026-09-14 13:40 ` Mathias Nyman
2026-09-15 3:26 ` 答复: " 胡连勤
2026-09-14 13:46 ` Michal Pecio
2026-09-15 7:45 ` 答复: " 胡连勤
2026-09-15 8:01 ` Michal Pecio
2026-09-15 8:35 ` 答复: " 胡连勤
2026-09-15 9:38 ` Michal Pecio
2026-09-15 10:11 ` 答复: " 胡连勤
2026-09-21 21:50 ` Wesley Cheng
2026-09-22 3:40 ` 答复: " 胡连勤
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914173403.05d1bca1.michal.pecio@gmail.com \
--to=michal.pecio@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=broonie@kernel.org \
--cc=cpgs@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hulianqin@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=niklas.neronin@linux.intel.com \
--cc=quic_wcheng@quicinc.com \
--cc=selvarasu.g@samsung.com \
--cc=thiagu.r@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.