From: Jakub Kicinski <kuba@kernel.org>
To: Victor Nogueira <victor@mojatatu.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
jhs@mojatatu.com, jiri@resnulli.us, horms@kernel.org,
vega@nebusec.ai, netdev@vger.kernel.org
Subject: Re: [PATCH net] net/sched: Avoid quadratic handle scan in qdisc_alloc_handle
Date: Mon, 14 Sep 2026 19:11:08 -0700 [thread overview]
Message-ID: <20260914191108.55a1a4f1@kernel.org> (raw)
In-Reply-To: <20260911133146.3440982-1-victor@mojatatu.com>
On Fri, 11 Sep 2026 10:31:46 -0300 Victor Nogueira wrote:
> This is a less intrusive fix meant for backporting; a cleaner approach that
> uses a per-device IDA over all qdisc handles is planned for net-next.
I don't think this is net-worthy in the first place.
We have a ton of code under rtnl_lock.
We cannot provide any protection from malicious netns admin from
overloading the machine.
Nothing against the patch itself, but if you plan to do something
else in net-next let's just go with that from the start..
--
pw-bot: cr
next prev parent reply other threads:[~2026-09-15 2:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 13:31 [PATCH net] net/sched: Avoid quadratic handle scan in qdisc_alloc_handle Victor Nogueira
2026-09-14 8:22 ` Simon Horman
2026-09-15 2:11 ` Jakub Kicinski [this message]
2026-09-15 11:50 ` Jamal Hadi Salim
2026-09-15 12:28 ` Eric Dumazet
2026-09-15 14:01 ` Jamal Hadi Salim
2026-09-15 15:53 ` Jakub Kicinski
2026-09-16 10:34 ` Jamal Hadi Salim
2026-09-17 0:04 ` Jakub Kicinski
2026-09-17 11:24 ` Jamal Hadi Salim
2026-09-18 0:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914191108.55a1a4f1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vega@nebusec.ai \
--cc=victor@mojatatu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.