All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vas Zayarskiy <contact@vasily.cc>
To: sashiko-reviews@lists.linux.dev
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Add AMPINEL support
Date: Tue, 15 Sep 2026 00:59:17 +0300	[thread overview]
Message-ID: <20260914215917.285155-1-contact@vasily.cc> (raw)
In-Reply-To: <20260914200831.5642E1F000FF@smtp.kernel.org>

> Would it be better to add a hid_is_usb(hdev) check before attempting this
> cast?

Thanks for catching this. HID_USB_DEVICE() only matches the advertised bus;
UHID can supply BUS_USB while using a different low-level transport and a
non-USB parent. The cast therefore needs an actual transport check.

I have prepared v2 with hid_is_usb(hdev) checked before to_usb_interface(),
returning -ENODEV for other transports. A probe-prefix userspace harness
reaches the invalid-parent cast with v1 and rejects it before the cast with
v2. The real-USB telemetry and keyboard paths also pass the harness checks.

The revised module builds on 7.2.5; x86_64 and i386 object builds, sparse and
the 995-report parser replay pass. No crashing UHID device was created on
the host during testing.

Thanks,
Vas

      reply	other threads:[~2026-09-14 21:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 19:57 [PATCH] hwmon: (aquacomputer_d5next) Add AMPINEL support Vas Zayarskiy
2026-09-14 20:08 ` sashiko-bot
2026-09-14 21:59   ` Vas Zayarskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914215917.285155-1-contact@vasily.cc \
    --to=contact@vasily.cc \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.