From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ED32438473; Mon, 14 Sep 2026 23:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789427794; cv=none; b=CoazFJgv1T2tF5pba25GSuo+XR4Ovcy1EnTIVQS80gY65x36iQi8bNTuHSikza5pSSydXKKK9Uq558R2dVG7vczRcRB75KEEDcl1ljQVqnOjwI2FZDa8arJSpfd/QM3YsxxnuYqxs7euVi+jb30gQaU6HxVrW6gJ1EX9OV83r0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789427794; c=relaxed/simple; bh=a9OoLxlbgryrlLKAmEGZIJMmuk4Mh04+3SkjLyPClyw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i1DsTFiJVlY7zS4sSOBrORFdAfR4zvZIANlwbcjquy/RcwEHKdDW0x+13OHiRs1pfdcYyapJ8OQjT0MpFyd7/neCmMts45ocm+FcmlOqwrKmie65miWV4uYTj5mFDp5EcoM7w5uh16gpg2BrX0vmBXCDIDNlKIw8kgN/92FFbBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z0MKwixY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z0MKwixY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 586901F000FF; Mon, 14 Sep 2026 23:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789427776; bh=tIIjh/Uf6BNc6qFW23Fkd03LNzbGrXqGSgv6kpFBBBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z0MKwixYFejC9aXB2ou9gDyVgw+IXUfla6yha+G1h+pdjyd9O2GMLR6rfbmVCIqRh qnCgaS96Y5zdrUGXyZHeCOvJUyELkRb+9fGwuS5j2u7zwvM0KNnIOldogKIDh75OXI UU1X49g4kycw28XdTtqVEurHf9Wwkc//rViLO6ZtoDml0qlU8ptCINWW4hrt54jJG2 hAPr0WuTs5yk74shR3GBcrH+k1Xa8WmdEfWKZAyL5keV+wX4e0ljXisLoEP1cRbpgh 4LO1uDw+LaWAO/9Fcz1VWy59hEVIdQMtiu7jS8LG28h+tTb8lnAcVAxnFEOPTpkgHm sgjmnSADR5CMg== From: Jakub Kicinski To: bartosz.golaszewski@oss.qualcomm.com Cc: Jakub Kicinski , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, vkoul@kernel.org, peppe.cavallaro@st.com, wens@kernel.org, jernej.skrabec@gmail.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, shawnguo@kernel.org, festevam@gmail.com, jan.petrous@oss.nxp.com, s32@nxp.com, mohd.anwar@oss.qualcomm.com, romain.gantois@bootlin.com, geert+renesas@glider.be, magnus.damm@gmail.com, mripard@kernel.org, christophe.roullier@foss.st.com, brgl@kernel.org, radu@rendec.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dfustini@tenstorrent.com, linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, bartosz.golaszewski@linaro.org Subject: Re: [PATCH net-next v14 07/10] net: stmmac: qcom-ethqos: fix SGMII loopback not set on resume after speed change Date: Mon, 14 Sep 2026 16:16:13 -0700 Message-ID: <20260914231614.704318-1-kuba@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. --- net: stmmac: qcom-ethqos: fix SGMII loopback not set on resume after speed change This extends the guard in qcom_ethqos_set_sgmii_loopback() so that the MAC wrapper TX-to-RX loopback is also armed when ethqos->phy_mode holds PHY_INTERFACE_MODE_SGMII, not only PHY_INTERFACE_MODE_2500BASEX. Without the loopback, dwmac4_dma_reset() polls an RX clock that never toggles and times out. No Link: tags were present in the commit header. > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index fd7414a50eb4e..e067ceee01621 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -190,7 +190,8 @@ static void > qcom_ethqos_set_sgmii_loopback(struct qcom_ethqos *ethqos, bool enable) > { > if (!ethqos->needs_sgmii_loopback || > - ethqos->phy_mode != PHY_INTERFACE_MODE_2500BASEX) > + (ethqos->phy_mode != PHY_INTERFACE_MODE_2500BASEX && > + ethqos->phy_mode != PHY_INTERFACE_MODE_SGMII)) > return; [Severity: Medium] Should this hunk be squashed into the preceding patch of the series, or at least carry a Fixes: tag naming it? The commit message says "mac_finish() now updates phy_mode to the runtime-resolved interface", which is the change made one patch earlier in this same series: f40e72d57bcb38 ("net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish()") git blame at this commit shows the assignment in ethqos_mac_finish_serdes(): ethqos->phy_mode = interface; came from f40e72d57bcb38. Before that, ethqos->phy_mode was written only once, in qcom_ethqos_probe() from the DT phy-mode property, so the 2500BASEX-only guard could not go stale at runtime and the DMA reset timeout described here did not exist. Does that leave f40e72d57bcb38 broken on its own, e.g. as a bisect point or a stable backport? On a needs_sgmii_loopback platform (emac_v4_0_0_data) with DT phy-mode "2500base-x" whose link resolves to 1G SGMII: ethqos_mac_finish_serdes() -> ethqos->phy_mode = PHY_INTERFACE_MODE_SGMII suspend / ifdown resume / ifup ethqos_clks_config(ethqos, true) qcom_ethqos_set_sgmii_loopback(ethqos, true) if (... ethqos->phy_mode != PHY_INTERFACE_MODE_2500BASEX) return; /* loopback never enabled */ dwmac4_dma_reset() /* polls a non-toggling clock, times out */ Also, the subject line reads as a standalone fix for a pre-existing problem, which hides the dependency on the previous patch. Would either squashing the guard change into f40e72d57bcb38, or adding Fixes: f40e72d57bcb38 ("net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish()") make the ordering requirement explicit? One more note on the commit message wording: the second paragraph reads "qcom_ethqos_set_sgmii_loopback() gates this on phy_mode being 2500BASEX. mac_finish() now updates phy_mode to the runtime-resolved interface, any subsequent resume with a 1G SGMII link skips the loopback setup" — the sentence joining is missing a connector such as "so that" or "and since", which makes the causal relationship hard to follow. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4F36C88E72 for ; Mon, 14 Sep 2026 23:16:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=znj8U/0HpZ2Cgekdll9XNZDMKF2UiP6/YPo5EaTY3CU=; b=s2m0Hbxic2Lck9 9PSkM3sHHfp6B3cwQXLpbVX0XqMAkot5mPgmS7JRD6+QIsK78rQPAvo6grhLRWIW/g4TFVe/WI5DG bPQ2zbh9V2lGFpDq7fZaYjWpl1N4fplB20EwFh8OLAXLhnnUTqEqpPTi5bUCsGm1kK+Wu6ZRrpLyk CF+/i6LNgEgxMd9NbqEJ008G/QUPOCCup9r2cV5bWK59/16TX1NSOubAMlk4CIrlEWTyWK+fzvCIM TsurCTp/27hpDaKy8gUsRYXBKZ1GprRre6CGepYTg+5XVeOGpiqb1xcixIgJlqggeJodvxoH0wEki G41WsG7XBDmNQz4NmxvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6Fuj-00000004qXN-0urh; Mon, 14 Sep 2026 23:16:41 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6FuL-00000004q9c-0Ulu; Mon, 14 Sep 2026 23:16:17 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D4F6942A28; Mon, 14 Sep 2026 23:16:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 586901F000FF; Mon, 14 Sep 2026 23:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789427776; bh=tIIjh/Uf6BNc6qFW23Fkd03LNzbGrXqGSgv6kpFBBBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z0MKwixYFejC9aXB2ou9gDyVgw+IXUfla6yha+G1h+pdjyd9O2GMLR6rfbmVCIqRh qnCgaS96Y5zdrUGXyZHeCOvJUyELkRb+9fGwuS5j2u7zwvM0KNnIOldogKIDh75OXI UU1X49g4kycw28XdTtqVEurHf9Wwkc//rViLO6ZtoDml0qlU8ptCINWW4hrt54jJG2 hAPr0WuTs5yk74shR3GBcrH+k1Xa8WmdEfWKZAyL5keV+wX4e0ljXisLoEP1cRbpgh 4LO1uDw+LaWAO/9Fcz1VWy59hEVIdQMtiu7jS8LG28h+tTb8lnAcVAxnFEOPTpkgHm sgjmnSADR5CMg== From: Jakub Kicinski To: bartosz.golaszewski@oss.qualcomm.com Cc: Jakub Kicinski , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, vkoul@kernel.org, peppe.cavallaro@st.com, wens@kernel.org, jernej.skrabec@gmail.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, shawnguo@kernel.org, festevam@gmail.com, jan.petrous@oss.nxp.com, s32@nxp.com, mohd.anwar@oss.qualcomm.com, romain.gantois@bootlin.com, geert+renesas@glider.be, magnus.damm@gmail.com, mripard@kernel.org, christophe.roullier@foss.st.com, brgl@kernel.org, radu@rendec.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dfustini@tenstorrent.com, linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, bartosz.golaszewski@linaro.org Subject: Re: [PATCH net-next v14 07/10] net: stmmac: qcom-ethqos: fix SGMII loopback not set on resume after speed change Date: Mon, 14 Sep 2026 16:16:13 -0700 Message-ID: <20260914231614.704318-1-kuba@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org VGhpcyBpcyBhbiBBSS1nZW5lcmF0ZWQgcmV2aWV3IG9mIHlvdXIgcGF0Y2guIFRoZSBodW1hbiBz ZW5kaW5nIHRoaXMKZW1haWwgaGFzIGNvbnNpZGVyZWQgdGhlIEFJIHJldmlldyB2YWxpZCwgb3Ig YXQgbGVhc3QgcGxhdXNpYmxlLgotLS0KbmV0OiBzdG1tYWM6IHFjb20tZXRocW9zOiBmaXggU0dN SUkgbG9vcGJhY2sgbm90IHNldCBvbiByZXN1bWUgYWZ0ZXIgc3BlZWQgY2hhbmdlCgpUaGlzIGV4 dGVuZHMgdGhlIGd1YXJkIGluIHFjb21fZXRocW9zX3NldF9zZ21paV9sb29wYmFjaygpIHNvIHRo YXQgdGhlIE1BQwp3cmFwcGVyIFRYLXRvLVJYIGxvb3BiYWNrIGlzIGFsc28gYXJtZWQgd2hlbiBl dGhxb3MtPnBoeV9tb2RlIGhvbGRzClBIWV9JTlRFUkZBQ0VfTU9ERV9TR01JSSwgbm90IG9ubHkg UEhZX0lOVEVSRkFDRV9NT0RFXzI1MDBCQVNFWC4gV2l0aG91dAp0aGUgbG9vcGJhY2ssIGR3bWFj NF9kbWFfcmVzZXQoKSBwb2xscyBhbiBSWCBjbG9jayB0aGF0IG5ldmVyIHRvZ2dsZXMgYW5kCnRp bWVzIG91dC4KCk5vIExpbms6IHRhZ3Mgd2VyZSBwcmVzZW50IGluIHRoZSBjb21taXQgaGVhZGVy LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvZHdt YWMtcWNvbS1ldGhxb3MuYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3 bWFjLXFjb20tZXRocW9zLmMKPiBpbmRleCBmZDc0MTRhNTBlYjRlLi5lMDY3Y2VlZTAxNjIxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3bWFjLXFj b20tZXRocW9zLmMKPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9k d21hYy1xY29tLWV0aHFvcy5jCj4gQEAgLTE5MCw3ICsxOTAsOCBAQCBzdGF0aWMgdm9pZAo+ICBx Y29tX2V0aHFvc19zZXRfc2dtaWlfbG9vcGJhY2soc3RydWN0IHFjb21fZXRocW9zICpldGhxb3Ms IGJvb2wgZW5hYmxlKQo+ICB7Cj4gIAlpZiAoIWV0aHFvcy0+bmVlZHNfc2dtaWlfbG9vcGJhY2sg fHwKPiAtCSAgICBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV8yNTAwQkFT RVgpCj4gKwkgICAgKGV0aHFvcy0+cGh5X21vZGUgIT0gUEhZX0lOVEVSRkFDRV9NT0RFXzI1MDBC QVNFWCAmJgo+ICsJICAgICBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV9T R01JSSkpCj4gIAkJcmV0dXJuOwoKW1NldmVyaXR5OiBNZWRpdW1dClNob3VsZCB0aGlzIGh1bmsg YmUgc3F1YXNoZWQgaW50byB0aGUgcHJlY2VkaW5nIHBhdGNoIG9mIHRoZSBzZXJpZXMsIG9yIGF0 CmxlYXN0IGNhcnJ5IGEgRml4ZXM6IHRhZyBuYW1pbmcgaXQ/CgpUaGUgY29tbWl0IG1lc3NhZ2Ug c2F5cyAibWFjX2ZpbmlzaCgpIG5vdyB1cGRhdGVzIHBoeV9tb2RlIHRvIHRoZQpydW50aW1lLXJl c29sdmVkIGludGVyZmFjZSIsIHdoaWNoIGlzIHRoZSBjaGFuZ2UgbWFkZSBvbmUgcGF0Y2ggZWFy bGllciBpbgp0aGlzIHNhbWUgc2VyaWVzOgoKICBmNDBlNzJkNTdiY2IzOCAoIm5ldDogc3RtbWFj OiBxY29tLWV0aHFvczogdXBkYXRlIHBoeV9tb2RlIHRvIHRoZQogIHJlc29sdmVkIGludGVyZmFj ZSBpbiBtYWNfZmluaXNoKCkiKQoKZ2l0IGJsYW1lIGF0IHRoaXMgY29tbWl0IHNob3dzIHRoZSBh c3NpZ25tZW50IGluIGV0aHFvc19tYWNfZmluaXNoX3NlcmRlcygpOgoKCWV0aHFvcy0+cGh5X21v ZGUgPSBpbnRlcmZhY2U7CgpjYW1lIGZyb20gZjQwZTcyZDU3YmNiMzguIEJlZm9yZSB0aGF0LCBl dGhxb3MtPnBoeV9tb2RlIHdhcyB3cml0dGVuIG9ubHkKb25jZSwgaW4gcWNvbV9ldGhxb3NfcHJv YmUoKSBmcm9tIHRoZSBEVCBwaHktbW9kZSBwcm9wZXJ0eSwgc28gdGhlCjI1MDBCQVNFWC1vbmx5 IGd1YXJkIGNvdWxkIG5vdCBnbyBzdGFsZSBhdCBydW50aW1lIGFuZCB0aGUgRE1BIHJlc2V0CnRp bWVvdXQgZGVzY3JpYmVkIGhlcmUgZGlkIG5vdCBleGlzdC4KCkRvZXMgdGhhdCBsZWF2ZSBmNDBl NzJkNTdiY2IzOCBicm9rZW4gb24gaXRzIG93biwgZS5nLiBhcyBhIGJpc2VjdCBwb2ludCBvcgph IHN0YWJsZSBiYWNrcG9ydD8gT24gYSBuZWVkc19zZ21paV9sb29wYmFjayBwbGF0Zm9ybSAoZW1h Y192NF8wXzBfZGF0YSkKd2l0aCBEVCBwaHktbW9kZSAiMjUwMGJhc2UteCIgd2hvc2UgbGluayBy ZXNvbHZlcyB0byAxRyBTR01JSToKCiAgZXRocW9zX21hY19maW5pc2hfc2VyZGVzKCkgICAgICAt PiBldGhxb3MtPnBoeV9tb2RlID0gUEhZX0lOVEVSRkFDRV9NT0RFX1NHTUlJCiAgc3VzcGVuZCAv IGlmZG93bgogIHJlc3VtZSAvIGlmdXAKICBldGhxb3NfY2xrc19jb25maWcoZXRocW9zLCB0cnVl KQogICAgcWNvbV9ldGhxb3Nfc2V0X3NnbWlpX2xvb3BiYWNrKGV0aHFvcywgdHJ1ZSkKICAgICAg aWYgKC4uLiBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV8yNTAwQkFTRVgp CiAgICAgICAgICAgICAgcmV0dXJuOyAgICAgICAgICAgICAgICAgLyogbG9vcGJhY2sgbmV2ZXIg ZW5hYmxlZCAqLwogIGR3bWFjNF9kbWFfcmVzZXQoKSAgICAgICAgICAgICAgICAgIC8qIHBvbGxz IGEgbm9uLXRvZ2dsaW5nIGNsb2NrLCB0aW1lcyBvdXQgKi8KCkFsc28sIHRoZSBzdWJqZWN0IGxp bmUgcmVhZHMgYXMgYSBzdGFuZGFsb25lIGZpeCBmb3IgYSBwcmUtZXhpc3RpbmcKcHJvYmxlbSwg d2hpY2ggaGlkZXMgdGhlIGRlcGVuZGVuY3kgb24gdGhlIHByZXZpb3VzIHBhdGNoLiBXb3VsZCBl aXRoZXIKc3F1YXNoaW5nIHRoZSBndWFyZCBjaGFuZ2UgaW50byBmNDBlNzJkNTdiY2IzOCwgb3Ig YWRkaW5nCgogIEZpeGVzOiBmNDBlNzJkNTdiY2IzOCAoIm5ldDogc3RtbWFjOiBxY29tLWV0aHFv czogdXBkYXRlIHBoeV9tb2RlIHRvIHRoZSByZXNvbHZlZCBpbnRlcmZhY2UgaW4gbWFjX2Zpbmlz aCgpIikKCm1ha2UgdGhlIG9yZGVyaW5nIHJlcXVpcmVtZW50IGV4cGxpY2l0PwoKT25lIG1vcmUg bm90ZSBvbiB0aGUgY29tbWl0IG1lc3NhZ2Ugd29yZGluZzogdGhlIHNlY29uZCBwYXJhZ3JhcGgg cmVhZHMKInFjb21fZXRocW9zX3NldF9zZ21paV9sb29wYmFjaygpIGdhdGVzIHRoaXMgb24gcGh5 X21vZGUgYmVpbmcgMjUwMEJBU0VYLgptYWNfZmluaXNoKCkgbm93IHVwZGF0ZXMgcGh5X21vZGUg dG8gdGhlIHJ1bnRpbWUtcmVzb2x2ZWQgaW50ZXJmYWNlLCBhbnkKc3Vic2VxdWVudCByZXN1bWUg d2l0aCBhIDFHIFNHTUlJIGxpbmsgc2tpcHMgdGhlIGxvb3BiYWNrIHNldHVwIiDigJQgdGhlCnNl bnRlbmNlIGpvaW5pbmcgaXMgbWlzc2luZyBhIGNvbm5lY3RvciBzdWNoIGFzICJzbyB0aGF0IiBv ciAiYW5kIHNpbmNlIiwKd2hpY2ggbWFrZXMgdGhlIGNhdXNhbCByZWxhdGlvbnNoaXAgaGFyZCB0 byBmb2xsb3cuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1E9CC88E72 for ; Mon, 14 Sep 2026 23:16:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I07hqcg8CjgXRA7bZRXszdWueCAtAxzCLdEIt9bGMCY=; b=biN0LCaPs7IFp0 WlDHqOeCwFigygKfkTd/15ZwSeJ6jpYyqCCC3WauEAvY4vvO47xS3wC7nzPmUVn1MTOcc7Z/tJl/d 62lcrT7Adb0sEmFkUdBf7ea2VWpLVYf+84XPwOtHYAWR2ALehW/VDNklKvLogyQ9u6FkrvgBe1xMx YQoOETY8FK+dF5mCGvnj05uBPXdZ9WKA33EcrPNglh2HjNOMLnoaJ3jSzyWU9O4lwZaIBJBVphD5z x41zmGe75PONo0pndj9oHXLLSAfCx1mefOZDEAzBIBsT4l61nZObpUfXa6Su6L6DSoHIAMfSo9Baz CBxhzuuMvHoKy/eT4Q3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6Fuh-00000004qUn-2uyo; Mon, 14 Sep 2026 23:16:39 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6FuL-00000004q9c-0Ulu; Mon, 14 Sep 2026 23:16:17 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D4F6942A28; Mon, 14 Sep 2026 23:16:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 586901F000FF; Mon, 14 Sep 2026 23:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789427776; bh=tIIjh/Uf6BNc6qFW23Fkd03LNzbGrXqGSgv6kpFBBBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z0MKwixYFejC9aXB2ou9gDyVgw+IXUfla6yha+G1h+pdjyd9O2GMLR6rfbmVCIqRh qnCgaS96Y5zdrUGXyZHeCOvJUyELkRb+9fGwuS5j2u7zwvM0KNnIOldogKIDh75OXI UU1X49g4kycw28XdTtqVEurHf9Wwkc//rViLO6ZtoDml0qlU8ptCINWW4hrt54jJG2 hAPr0WuTs5yk74shR3GBcrH+k1Xa8WmdEfWKZAyL5keV+wX4e0ljXisLoEP1cRbpgh 4LO1uDw+LaWAO/9Fcz1VWy59hEVIdQMtiu7jS8LG28h+tTb8lnAcVAxnFEOPTpkgHm sgjmnSADR5CMg== From: Jakub Kicinski To: bartosz.golaszewski@oss.qualcomm.com Cc: Jakub Kicinski , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, vkoul@kernel.org, peppe.cavallaro@st.com, wens@kernel.org, jernej.skrabec@gmail.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, shawnguo@kernel.org, festevam@gmail.com, jan.petrous@oss.nxp.com, s32@nxp.com, mohd.anwar@oss.qualcomm.com, romain.gantois@bootlin.com, geert+renesas@glider.be, magnus.damm@gmail.com, mripard@kernel.org, christophe.roullier@foss.st.com, brgl@kernel.org, radu@rendec.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dfustini@tenstorrent.com, linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, bartosz.golaszewski@linaro.org Subject: Re: [PATCH net-next v14 07/10] net: stmmac: qcom-ethqos: fix SGMII loopback not set on resume after speed change Date: Mon, 14 Sep 2026 16:16:13 -0700 Message-ID: <20260914231614.704318-1-kuba@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> MIME-Version: 1.0 X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org VGhpcyBpcyBhbiBBSS1nZW5lcmF0ZWQgcmV2aWV3IG9mIHlvdXIgcGF0Y2guIFRoZSBodW1hbiBz ZW5kaW5nIHRoaXMKZW1haWwgaGFzIGNvbnNpZGVyZWQgdGhlIEFJIHJldmlldyB2YWxpZCwgb3Ig YXQgbGVhc3QgcGxhdXNpYmxlLgotLS0KbmV0OiBzdG1tYWM6IHFjb20tZXRocW9zOiBmaXggU0dN SUkgbG9vcGJhY2sgbm90IHNldCBvbiByZXN1bWUgYWZ0ZXIgc3BlZWQgY2hhbmdlCgpUaGlzIGV4 dGVuZHMgdGhlIGd1YXJkIGluIHFjb21fZXRocW9zX3NldF9zZ21paV9sb29wYmFjaygpIHNvIHRo YXQgdGhlIE1BQwp3cmFwcGVyIFRYLXRvLVJYIGxvb3BiYWNrIGlzIGFsc28gYXJtZWQgd2hlbiBl dGhxb3MtPnBoeV9tb2RlIGhvbGRzClBIWV9JTlRFUkZBQ0VfTU9ERV9TR01JSSwgbm90IG9ubHkg UEhZX0lOVEVSRkFDRV9NT0RFXzI1MDBCQVNFWC4gV2l0aG91dAp0aGUgbG9vcGJhY2ssIGR3bWFj NF9kbWFfcmVzZXQoKSBwb2xscyBhbiBSWCBjbG9jayB0aGF0IG5ldmVyIHRvZ2dsZXMgYW5kCnRp bWVzIG91dC4KCk5vIExpbms6IHRhZ3Mgd2VyZSBwcmVzZW50IGluIHRoZSBjb21taXQgaGVhZGVy LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvZHdt YWMtcWNvbS1ldGhxb3MuYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3 bWFjLXFjb20tZXRocW9zLmMKPiBpbmRleCBmZDc0MTRhNTBlYjRlLi5lMDY3Y2VlZTAxNjIxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3bWFjLXFj b20tZXRocW9zLmMKPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9k d21hYy1xY29tLWV0aHFvcy5jCj4gQEAgLTE5MCw3ICsxOTAsOCBAQCBzdGF0aWMgdm9pZAo+ICBx Y29tX2V0aHFvc19zZXRfc2dtaWlfbG9vcGJhY2soc3RydWN0IHFjb21fZXRocW9zICpldGhxb3Ms IGJvb2wgZW5hYmxlKQo+ICB7Cj4gIAlpZiAoIWV0aHFvcy0+bmVlZHNfc2dtaWlfbG9vcGJhY2sg fHwKPiAtCSAgICBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV8yNTAwQkFT RVgpCj4gKwkgICAgKGV0aHFvcy0+cGh5X21vZGUgIT0gUEhZX0lOVEVSRkFDRV9NT0RFXzI1MDBC QVNFWCAmJgo+ICsJICAgICBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV9T R01JSSkpCj4gIAkJcmV0dXJuOwoKW1NldmVyaXR5OiBNZWRpdW1dClNob3VsZCB0aGlzIGh1bmsg YmUgc3F1YXNoZWQgaW50byB0aGUgcHJlY2VkaW5nIHBhdGNoIG9mIHRoZSBzZXJpZXMsIG9yIGF0 CmxlYXN0IGNhcnJ5IGEgRml4ZXM6IHRhZyBuYW1pbmcgaXQ/CgpUaGUgY29tbWl0IG1lc3NhZ2Ug c2F5cyAibWFjX2ZpbmlzaCgpIG5vdyB1cGRhdGVzIHBoeV9tb2RlIHRvIHRoZQpydW50aW1lLXJl c29sdmVkIGludGVyZmFjZSIsIHdoaWNoIGlzIHRoZSBjaGFuZ2UgbWFkZSBvbmUgcGF0Y2ggZWFy bGllciBpbgp0aGlzIHNhbWUgc2VyaWVzOgoKICBmNDBlNzJkNTdiY2IzOCAoIm5ldDogc3RtbWFj OiBxY29tLWV0aHFvczogdXBkYXRlIHBoeV9tb2RlIHRvIHRoZQogIHJlc29sdmVkIGludGVyZmFj ZSBpbiBtYWNfZmluaXNoKCkiKQoKZ2l0IGJsYW1lIGF0IHRoaXMgY29tbWl0IHNob3dzIHRoZSBh c3NpZ25tZW50IGluIGV0aHFvc19tYWNfZmluaXNoX3NlcmRlcygpOgoKCWV0aHFvcy0+cGh5X21v ZGUgPSBpbnRlcmZhY2U7CgpjYW1lIGZyb20gZjQwZTcyZDU3YmNiMzguIEJlZm9yZSB0aGF0LCBl dGhxb3MtPnBoeV9tb2RlIHdhcyB3cml0dGVuIG9ubHkKb25jZSwgaW4gcWNvbV9ldGhxb3NfcHJv YmUoKSBmcm9tIHRoZSBEVCBwaHktbW9kZSBwcm9wZXJ0eSwgc28gdGhlCjI1MDBCQVNFWC1vbmx5 IGd1YXJkIGNvdWxkIG5vdCBnbyBzdGFsZSBhdCBydW50aW1lIGFuZCB0aGUgRE1BIHJlc2V0CnRp bWVvdXQgZGVzY3JpYmVkIGhlcmUgZGlkIG5vdCBleGlzdC4KCkRvZXMgdGhhdCBsZWF2ZSBmNDBl NzJkNTdiY2IzOCBicm9rZW4gb24gaXRzIG93biwgZS5nLiBhcyBhIGJpc2VjdCBwb2ludCBvcgph IHN0YWJsZSBiYWNrcG9ydD8gT24gYSBuZWVkc19zZ21paV9sb29wYmFjayBwbGF0Zm9ybSAoZW1h Y192NF8wXzBfZGF0YSkKd2l0aCBEVCBwaHktbW9kZSAiMjUwMGJhc2UteCIgd2hvc2UgbGluayBy ZXNvbHZlcyB0byAxRyBTR01JSToKCiAgZXRocW9zX21hY19maW5pc2hfc2VyZGVzKCkgICAgICAt PiBldGhxb3MtPnBoeV9tb2RlID0gUEhZX0lOVEVSRkFDRV9NT0RFX1NHTUlJCiAgc3VzcGVuZCAv IGlmZG93bgogIHJlc3VtZSAvIGlmdXAKICBldGhxb3NfY2xrc19jb25maWcoZXRocW9zLCB0cnVl KQogICAgcWNvbV9ldGhxb3Nfc2V0X3NnbWlpX2xvb3BiYWNrKGV0aHFvcywgdHJ1ZSkKICAgICAg aWYgKC4uLiBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV8yNTAwQkFTRVgp CiAgICAgICAgICAgICAgcmV0dXJuOyAgICAgICAgICAgICAgICAgLyogbG9vcGJhY2sgbmV2ZXIg ZW5hYmxlZCAqLwogIGR3bWFjNF9kbWFfcmVzZXQoKSAgICAgICAgICAgICAgICAgIC8qIHBvbGxz IGEgbm9uLXRvZ2dsaW5nIGNsb2NrLCB0aW1lcyBvdXQgKi8KCkFsc28sIHRoZSBzdWJqZWN0IGxp bmUgcmVhZHMgYXMgYSBzdGFuZGFsb25lIGZpeCBmb3IgYSBwcmUtZXhpc3RpbmcKcHJvYmxlbSwg d2hpY2ggaGlkZXMgdGhlIGRlcGVuZGVuY3kgb24gdGhlIHByZXZpb3VzIHBhdGNoLiBXb3VsZCBl aXRoZXIKc3F1YXNoaW5nIHRoZSBndWFyZCBjaGFuZ2UgaW50byBmNDBlNzJkNTdiY2IzOCwgb3Ig YWRkaW5nCgogIEZpeGVzOiBmNDBlNzJkNTdiY2IzOCAoIm5ldDogc3RtbWFjOiBxY29tLWV0aHFv czogdXBkYXRlIHBoeV9tb2RlIHRvIHRoZSByZXNvbHZlZCBpbnRlcmZhY2UgaW4gbWFjX2Zpbmlz aCgpIikKCm1ha2UgdGhlIG9yZGVyaW5nIHJlcXVpcmVtZW50IGV4cGxpY2l0PwoKT25lIG1vcmUg bm90ZSBvbiB0aGUgY29tbWl0IG1lc3NhZ2Ugd29yZGluZzogdGhlIHNlY29uZCBwYXJhZ3JhcGgg cmVhZHMKInFjb21fZXRocW9zX3NldF9zZ21paV9sb29wYmFjaygpIGdhdGVzIHRoaXMgb24gcGh5 X21vZGUgYmVpbmcgMjUwMEJBU0VYLgptYWNfZmluaXNoKCkgbm93IHVwZGF0ZXMgcGh5X21vZGUg dG8gdGhlIHJ1bnRpbWUtcmVzb2x2ZWQgaW50ZXJmYWNlLCBhbnkKc3Vic2VxdWVudCByZXN1bWUg d2l0aCBhIDFHIFNHTUlJIGxpbmsgc2tpcHMgdGhlIGxvb3BiYWNrIHNldHVwIiDigJQgdGhlCnNl bnRlbmNlIGpvaW5pbmcgaXMgbWlzc2luZyBhIGNvbm5lY3RvciBzdWNoIGFzICJzbyB0aGF0IiBv ciAiYW5kIHNpbmNlIiwKd2hpY2ggbWFrZXMgdGhlIGNhdXNhbCByZWxhdGlvbnNoaXAgaGFyZCB0 byBmb2xsb3cuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A60BAC88E75 for ; Mon, 14 Sep 2026 23:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YtLfKoS6w7XeKiyYbGVwWfBJ+CKpHMacOZHA6PZCHug=; b=MvQwtrK4p+hYy4 jOQqs5pXP+r8Ik7RJtkDSgRwSUCz1OfbyZRKWA3Msf/ICiECPICbgvJNB2qQgau3h+JDT8Zx/qK/w JV+7XEQssSWZ/neHITJWIOvR5684zQzJCMAB51dNs2j6Qt8ByNhKyYky9Xw2iLY/CMF5Sl0PWwZn4 4xCvFULDcClrDwLbOcJSy1YZqoGmrO2OQcVhLm1y5Wx7qRKSx3ZwSRpvyFbwSQla4juNmBRax6BKG VORiwt6U+AoSFc94oYOWP+6/78ZSfC+DfyDI/UFEODPjNZW7R8MicZwH9lkp+aIyJFmRJ7UX29TQs PNtgevEdtSp2liUn7Kpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6FuW-00000004qKa-2XHx; Mon, 14 Sep 2026 23:16:28 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6FuL-00000004q9c-0Ulu; Mon, 14 Sep 2026 23:16:17 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D4F6942A28; Mon, 14 Sep 2026 23:16:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 586901F000FF; Mon, 14 Sep 2026 23:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789427776; bh=tIIjh/Uf6BNc6qFW23Fkd03LNzbGrXqGSgv6kpFBBBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z0MKwixYFejC9aXB2ou9gDyVgw+IXUfla6yha+G1h+pdjyd9O2GMLR6rfbmVCIqRh qnCgaS96Y5zdrUGXyZHeCOvJUyELkRb+9fGwuS5j2u7zwvM0KNnIOldogKIDh75OXI UU1X49g4kycw28XdTtqVEurHf9Wwkc//rViLO6ZtoDml0qlU8ptCINWW4hrt54jJG2 hAPr0WuTs5yk74shR3GBcrH+k1Xa8WmdEfWKZAyL5keV+wX4e0ljXisLoEP1cRbpgh 4LO1uDw+LaWAO/9Fcz1VWy59hEVIdQMtiu7jS8LG28h+tTb8lnAcVAxnFEOPTpkgHm sgjmnSADR5CMg== From: Jakub Kicinski To: bartosz.golaszewski@oss.qualcomm.com Cc: Jakub Kicinski , andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, vkoul@kernel.org, peppe.cavallaro@st.com, wens@kernel.org, jernej.skrabec@gmail.com, neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, shawnguo@kernel.org, festevam@gmail.com, jan.petrous@oss.nxp.com, s32@nxp.com, mohd.anwar@oss.qualcomm.com, romain.gantois@bootlin.com, geert+renesas@glider.be, magnus.damm@gmail.com, mripard@kernel.org, christophe.roullier@foss.st.com, brgl@kernel.org, radu@rendec.net, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dfustini@tenstorrent.com, linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, bartosz.golaszewski@linaro.org Subject: Re: [PATCH net-next v14 07/10] net: stmmac: qcom-ethqos: fix SGMII loopback not set on resume after speed change Date: Mon, 14 Sep 2026 16:16:13 -0700 Message-ID: <20260914231614.704318-1-kuba@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> References: <20260908-qcom-sa8255p-emac-v14-7-ec212b747a7d@oss.qualcomm.com> MIME-Version: 1.0 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhpcyBpcyBhbiBBSS1nZW5lcmF0ZWQgcmV2aWV3IG9mIHlvdXIgcGF0Y2guIFRoZSBodW1hbiBz ZW5kaW5nIHRoaXMKZW1haWwgaGFzIGNvbnNpZGVyZWQgdGhlIEFJIHJldmlldyB2YWxpZCwgb3Ig YXQgbGVhc3QgcGxhdXNpYmxlLgotLS0KbmV0OiBzdG1tYWM6IHFjb20tZXRocW9zOiBmaXggU0dN SUkgbG9vcGJhY2sgbm90IHNldCBvbiByZXN1bWUgYWZ0ZXIgc3BlZWQgY2hhbmdlCgpUaGlzIGV4 dGVuZHMgdGhlIGd1YXJkIGluIHFjb21fZXRocW9zX3NldF9zZ21paV9sb29wYmFjaygpIHNvIHRo YXQgdGhlIE1BQwp3cmFwcGVyIFRYLXRvLVJYIGxvb3BiYWNrIGlzIGFsc28gYXJtZWQgd2hlbiBl dGhxb3MtPnBoeV9tb2RlIGhvbGRzClBIWV9JTlRFUkZBQ0VfTU9ERV9TR01JSSwgbm90IG9ubHkg UEhZX0lOVEVSRkFDRV9NT0RFXzI1MDBCQVNFWC4gV2l0aG91dAp0aGUgbG9vcGJhY2ssIGR3bWFj NF9kbWFfcmVzZXQoKSBwb2xscyBhbiBSWCBjbG9jayB0aGF0IG5ldmVyIHRvZ2dsZXMgYW5kCnRp bWVzIG91dC4KCk5vIExpbms6IHRhZ3Mgd2VyZSBwcmVzZW50IGluIHRoZSBjb21taXQgaGVhZGVy LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvZHdt YWMtcWNvbS1ldGhxb3MuYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3 bWFjLXFjb20tZXRocW9zLmMKPiBpbmRleCBmZDc0MTRhNTBlYjRlLi5lMDY3Y2VlZTAxNjIxIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL2R3bWFjLXFj b20tZXRocW9zLmMKPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9k d21hYy1xY29tLWV0aHFvcy5jCj4gQEAgLTE5MCw3ICsxOTAsOCBAQCBzdGF0aWMgdm9pZAo+ICBx Y29tX2V0aHFvc19zZXRfc2dtaWlfbG9vcGJhY2soc3RydWN0IHFjb21fZXRocW9zICpldGhxb3Ms IGJvb2wgZW5hYmxlKQo+ICB7Cj4gIAlpZiAoIWV0aHFvcy0+bmVlZHNfc2dtaWlfbG9vcGJhY2sg fHwKPiAtCSAgICBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV8yNTAwQkFT RVgpCj4gKwkgICAgKGV0aHFvcy0+cGh5X21vZGUgIT0gUEhZX0lOVEVSRkFDRV9NT0RFXzI1MDBC QVNFWCAmJgo+ICsJICAgICBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV9T R01JSSkpCj4gIAkJcmV0dXJuOwoKW1NldmVyaXR5OiBNZWRpdW1dClNob3VsZCB0aGlzIGh1bmsg YmUgc3F1YXNoZWQgaW50byB0aGUgcHJlY2VkaW5nIHBhdGNoIG9mIHRoZSBzZXJpZXMsIG9yIGF0 CmxlYXN0IGNhcnJ5IGEgRml4ZXM6IHRhZyBuYW1pbmcgaXQ/CgpUaGUgY29tbWl0IG1lc3NhZ2Ug c2F5cyAibWFjX2ZpbmlzaCgpIG5vdyB1cGRhdGVzIHBoeV9tb2RlIHRvIHRoZQpydW50aW1lLXJl c29sdmVkIGludGVyZmFjZSIsIHdoaWNoIGlzIHRoZSBjaGFuZ2UgbWFkZSBvbmUgcGF0Y2ggZWFy bGllciBpbgp0aGlzIHNhbWUgc2VyaWVzOgoKICBmNDBlNzJkNTdiY2IzOCAoIm5ldDogc3RtbWFj OiBxY29tLWV0aHFvczogdXBkYXRlIHBoeV9tb2RlIHRvIHRoZQogIHJlc29sdmVkIGludGVyZmFj ZSBpbiBtYWNfZmluaXNoKCkiKQoKZ2l0IGJsYW1lIGF0IHRoaXMgY29tbWl0IHNob3dzIHRoZSBh c3NpZ25tZW50IGluIGV0aHFvc19tYWNfZmluaXNoX3NlcmRlcygpOgoKCWV0aHFvcy0+cGh5X21v ZGUgPSBpbnRlcmZhY2U7CgpjYW1lIGZyb20gZjQwZTcyZDU3YmNiMzguIEJlZm9yZSB0aGF0LCBl dGhxb3MtPnBoeV9tb2RlIHdhcyB3cml0dGVuIG9ubHkKb25jZSwgaW4gcWNvbV9ldGhxb3NfcHJv YmUoKSBmcm9tIHRoZSBEVCBwaHktbW9kZSBwcm9wZXJ0eSwgc28gdGhlCjI1MDBCQVNFWC1vbmx5 IGd1YXJkIGNvdWxkIG5vdCBnbyBzdGFsZSBhdCBydW50aW1lIGFuZCB0aGUgRE1BIHJlc2V0CnRp bWVvdXQgZGVzY3JpYmVkIGhlcmUgZGlkIG5vdCBleGlzdC4KCkRvZXMgdGhhdCBsZWF2ZSBmNDBl NzJkNTdiY2IzOCBicm9rZW4gb24gaXRzIG93biwgZS5nLiBhcyBhIGJpc2VjdCBwb2ludCBvcgph IHN0YWJsZSBiYWNrcG9ydD8gT24gYSBuZWVkc19zZ21paV9sb29wYmFjayBwbGF0Zm9ybSAoZW1h Y192NF8wXzBfZGF0YSkKd2l0aCBEVCBwaHktbW9kZSAiMjUwMGJhc2UteCIgd2hvc2UgbGluayBy ZXNvbHZlcyB0byAxRyBTR01JSToKCiAgZXRocW9zX21hY19maW5pc2hfc2VyZGVzKCkgICAgICAt PiBldGhxb3MtPnBoeV9tb2RlID0gUEhZX0lOVEVSRkFDRV9NT0RFX1NHTUlJCiAgc3VzcGVuZCAv IGlmZG93bgogIHJlc3VtZSAvIGlmdXAKICBldGhxb3NfY2xrc19jb25maWcoZXRocW9zLCB0cnVl KQogICAgcWNvbV9ldGhxb3Nfc2V0X3NnbWlpX2xvb3BiYWNrKGV0aHFvcywgdHJ1ZSkKICAgICAg aWYgKC4uLiBldGhxb3MtPnBoeV9tb2RlICE9IFBIWV9JTlRFUkZBQ0VfTU9ERV8yNTAwQkFTRVgp CiAgICAgICAgICAgICAgcmV0dXJuOyAgICAgICAgICAgICAgICAgLyogbG9vcGJhY2sgbmV2ZXIg ZW5hYmxlZCAqLwogIGR3bWFjNF9kbWFfcmVzZXQoKSAgICAgICAgICAgICAgICAgIC8qIHBvbGxz IGEgbm9uLXRvZ2dsaW5nIGNsb2NrLCB0aW1lcyBvdXQgKi8KCkFsc28sIHRoZSBzdWJqZWN0IGxp bmUgcmVhZHMgYXMgYSBzdGFuZGFsb25lIGZpeCBmb3IgYSBwcmUtZXhpc3RpbmcKcHJvYmxlbSwg d2hpY2ggaGlkZXMgdGhlIGRlcGVuZGVuY3kgb24gdGhlIHByZXZpb3VzIHBhdGNoLiBXb3VsZCBl aXRoZXIKc3F1YXNoaW5nIHRoZSBndWFyZCBjaGFuZ2UgaW50byBmNDBlNzJkNTdiY2IzOCwgb3Ig YWRkaW5nCgogIEZpeGVzOiBmNDBlNzJkNTdiY2IzOCAoIm5ldDogc3RtbWFjOiBxY29tLWV0aHFv czogdXBkYXRlIHBoeV9tb2RlIHRvIHRoZSByZXNvbHZlZCBpbnRlcmZhY2UgaW4gbWFjX2Zpbmlz aCgpIikKCm1ha2UgdGhlIG9yZGVyaW5nIHJlcXVpcmVtZW50IGV4cGxpY2l0PwoKT25lIG1vcmUg bm90ZSBvbiB0aGUgY29tbWl0IG1lc3NhZ2Ugd29yZGluZzogdGhlIHNlY29uZCBwYXJhZ3JhcGgg cmVhZHMKInFjb21fZXRocW9zX3NldF9zZ21paV9sb29wYmFjaygpIGdhdGVzIHRoaXMgb24gcGh5 X21vZGUgYmVpbmcgMjUwMEJBU0VYLgptYWNfZmluaXNoKCkgbm93IHVwZGF0ZXMgcGh5X21vZGUg dG8gdGhlIHJ1bnRpbWUtcmVzb2x2ZWQgaW50ZXJmYWNlLCBhbnkKc3Vic2VxdWVudCByZXN1bWUg d2l0aCBhIDFHIFNHTUlJIGxpbmsgc2tpcHMgdGhlIGxvb3BiYWNrIHNldHVwIiDigJQgdGhlCnNl bnRlbmNlIGpvaW5pbmcgaXMgbWlzc2luZyBhIGNvbm5lY3RvciBzdWNoIGFzICJzbyB0aGF0IiBv ciAiYW5kIHNpbmNlIiwKd2hpY2ggbWFrZXMgdGhlIGNhdXNhbCByZWxhdGlvbnNoaXAgaGFyZCB0 byBmb2xsb3cuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h bWxvZ2ljCg==