Re: [PATCH 8/8] mm/damon/core-kunit: test invalid damos filter commits

[SJ Park <sj@kernel.org>]

On Mon, 14 Sep 2026 15:44:58 +0000 sashiko-bot@kernel.org wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Missing test coverage for invalid DAMOS_FILTER_TYPE_PROBE_HITS_WSUM filter commits.
> --
> 
> commit 3dd853ee9735627ad90ea3f3d15874f043b5bdb4
> Author: SJ Park <sj@kernel.org>
> 
> mm/damon/core-kunit: test invalid damos filter commits
>     
> This commit adds test cases to verify the validation of damos filter arguments
> at commit time.
> 
> > diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> > index 2b0931cf6fb32..527abc2570616 100644
> > --- a/mm/damon/tests/core-kunit.h
> > +++ b/mm/damon/tests/core-kunit.h
> > @@ -1184,6 +1184,13 @@ static void damos_test_commit_filter(struct kunit *test)
> >  			.allow = false,
> >  			.sz_range = {.min = 234, .max = 345},
> >  			}, false);
> > +	damos_test_commit_filter_for(test, &dst,
> > +			&(struct damos_filter){
> > +			.type = DAMOS_FILTER_TYPE_HUGEPAGE_SIZE,
> > +			.matching = false,
> > +			.allow = false,
> > +			.sz_range = {.min = 456, .max = 123},
> > +			}, true);
> 
> [ ... ]
> 
> > @@ -1197,6 +1204,13 @@ static void damos_test_commit_filter(struct kunit *test)
> >  			.allow = false,
> >  			.addr_range = {.start = 456, .end = 567},
> >  			}, false);
> > +	damos_test_commit_filter_for(test, &dst,
> > +			&(struct damos_filter){
> > +			.type = DAMOS_FILTER_TYPE_ADDR,
> > +			.matching = false,
> > +			.allow = false,
> > +			.addr_range = {.start = 567, .end = 456},
> > +			}, true);
> 
> [Severity: Low]
> This isn't a bug, but is a test needed here for
> DAMOS_FILTER_TYPE_PROBE_HITS_WSUM?
> 
> This patch adds negative tests expecting failure for invalid filter arguments
> using DAMOS_FILTER_TYPE_HUGEPAGE_SIZE and DAMOS_FILTER_TYPE_ADDR.
> 
> Because DAMOS_FILTER_TYPE_PROBE_HITS_WSUM uses identical validation logic in
> damos_commit_filter_arg() that rejects arguments when range_max is less than
> range_min, should a similar test be added to provide equivalent coverage?
> 
> Also, earlier in this file, damos_test_commit_filter_for() validates
> successful copies for other types, but lacks a case to check range_min and
> range_max for PROBE_HITS_WSUM. Would it make sense to add validation for this
> filter type there as well?

It makes sense to add the test.  But not necessarily a blocker of this patch.
I will separately work on the test.

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260914142327.92510-1-sj@kernel.org?part=8


Thanks,
SJ