From: sashiko-bot@kernel.org
To: "Vas Zayarskiy" <contact@vasily.cc>
Cc: linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH v3 1/4] HID: generic: Respect specialized drivers match callbacks
Date: Mon, 14 Sep 2026 23:45:32 +0000 [thread overview]
Message-ID: <20260914234533.20A531F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260914233728.22725-2-contact@vasily.cc>
> A driver can reject an interface in its match callback even when its ID
> table matches. hid-generic currently yields based on the ID table alone,
> leaving such an interface without a driver.
>
> Consult the callback after matching the ID table so hid-generic can keep
> interfaces declined by specialized drivers. This allows the AMPINEL
> hwmon driver to leave the separate keyboard interface to hid-generic.
>
> The same callback check was proposed previously for Logitech devices:
>
> Link: https://lkml.iu.edu/hypermail/linux/kernel/2212.0/06724.html
>
> Assisted-by: LLM sparse
> Signed-off-by: Vas Zayarskiy <contact@vasily.cc>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260914233728.22725-1-contact@vasily.cc?part=1
next prev parent reply other threads:[~2026-09-14 23:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 23:37 [PATCH v3 0/4] hwmon: AMPINEL support and shared fixes Vas Zayarskiy
2026-09-14 23:37 ` [PATCH v3 1/4] HID: generic: Respect specialized drivers match callbacks Vas Zayarskiy
2026-09-14 23:45 ` sashiko-bot [this message]
2026-09-15 4:31 ` Guenter Roeck
2026-09-15 5:22 ` Vas Zayarskiy
2026-09-14 23:37 ` [PATCH v3 2/4] hwmon: (aquacomputer_d5next) Avoid truncating scaled sensor readings Vas Zayarskiy
2026-09-14 23:44 ` sashiko-bot
2026-09-15 4:38 ` Guenter Roeck
2026-09-14 23:37 ` [PATCH v3 3/4] hwmon: (aquacomputer_d5next) Expire the initial sensor cache Vas Zayarskiy
2026-09-14 23:52 ` sashiko-bot
2026-09-14 23:37 ` [PATCH v3 4/4] hwmon: (aquacomputer_d5next) Add AMPINEL support Vas Zayarskiy
2026-09-14 23:47 ` sashiko-bot
2026-09-15 4:30 ` Guenter Roeck
2026-09-15 5:29 ` Vas Zayarskiy
2026-09-15 17:09 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914234533.20A531F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=contact@vasily.cc \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.