All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alex Elder" <elder@riscstar.com>
Cc: robh@kernel.org, linux-pci@vger.kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: misc: introduce pci1179,0220.yaml
Date: Tue, 15 Sep 2026 03:15:51 +0000	[thread overview]
Message-ID: <20260915031552.179121F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915031038.1087264-2-elder@riscstar.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: typo in compatible comment (TC9654 vs TC9564)
--

commit 8118db85b05b7b5ac32fd5abc0d4c0b807fa8de2
Author: Alex Elder <elder@riscstar.com>

dt-bindings: misc: introduce pci1179,0220.yaml

This commit introduces a new devicetree binding for the Toshiba TC9564
internal PCI endpoint function device. It uses the pci-ep-bus model to
represent sub-devices accessed via the function's BARs.

> diff --git a/Documentation/devicetree/bindings/misc/pci1179,0220.yaml b/Documentation/devicetree/bindings/misc/pci1179,0220.yaml
> new file mode 100644
> index 0000000000000..fca3d331097de
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/pci1179,0220.yaml

[ ... ]

> +allOf:
> +  - $ref: /schemas/pci/pci-ep-bus.yaml
> +
> +properties:
> +  compatible:
> +    const: pci1179,0220         # Toshiba TC9654 (a.k.a. Qualcomm QPS615)

[Severity: Low]
Is TC9654 a typo in this properties.compatible comment? The device is
referred to as TC9564 in the commit message, the file title, and the
MAINTAINERS file.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915031038.1087264-1-elder@riscstar.com?part=1

  reply	other threads:[~2026-09-15  3:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15  3:10 [PATCH v2 0/3] PCI: introduce TC9564 misc driver Alex Elder
2026-09-15  3:10 ` [PATCH v2 1/3] dt-bindings: misc: introduce pci1179,0220.yaml Alex Elder
2026-09-15  3:15   ` sashiko-bot [this message]
2026-09-15 12:49     ` Alex Elder
2026-09-15  3:10 ` [PATCH v2 2/3] misc: tc9564: introduce base PCI driver Alex Elder
2026-09-15  3:20   ` sashiko-bot
2026-09-15 12:49     ` Alex Elder
2026-09-15  3:10 ` [PATCH v2 3/3] arm64: dts: qcom: qcs6490-rb3gen2: add endpoint buses Alex Elder
2026-09-15  3:20   ` sashiko-bot
2026-09-15 12:49     ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915031552.179121F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@riscstar.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.