From: sashiko-bot@kernel.org
To: "Guanglei Zhu" <zhugl3@xiaopeng.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext2: reject xattr value overlapping the entry area
Date: Tue, 15 Sep 2026 06:52:57 +0000 [thread overview]
Message-ID: <20260915065258.327441F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915064453.249419-1-zhugl3@xiaopeng.com>
> ext2_xattr_entry_valid() checks that a value ends within the block but
> not that it starts after the entry area, so a corrupted block can place
> a value inside the entries. ext2_xattr_set() then underflows the free
> space calculation:
>
> free = min_offs - ((char*)last - (char*)header) - sizeof(__u32);
>
> and writes the new value before the start of the block:
>
> val = (char *)header + min_offs - size;
>
> Check that the value area does not overlap the entry area and refuse
> such a block instead.
>
> Signed-off-by: Guanglei Zhu <zhugl3@xiaopeng.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915064453.249419-1-zhugl3@xiaopeng.com?part=1
prev parent reply other threads:[~2026-09-15 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 6:44 [PATCH] ext2: reject xattr value overlapping the entry area Guanglei Zhu
2026-09-15 6:52 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915065258.327441F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
--cc=zhugl3@xiaopeng.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.