All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: lirongqing <lirongqing@baidu.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Yishai Hadas <yishaih@mellanox.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/uverbs: Reject WQ creation without a completion queue
Date: Tue, 15 Sep 2026 11:02:34 +0300	[thread overview]
Message-ID: <20260915080234.GG13683@unreal> (raw)
In-Reply-To: <20260910123318.GQ13683@unreal>

On Thu, Sep 10, 2026 at 03:33:18PM +0300, Leon Romanovsky wrote:
> On Mon, Sep 07, 2026 at 07:39:18PM +0800, lirongqing wrote:
> > From: Li RongQing <lirongqing@baidu.com>
> > 
> > UVERBS_ATTR_CREATE_WQ_CQ_HANDLE is declared UA_OPTIONAL in the ioctl
> > method definition, so the mandatory attribute bitmap does not enforce
> > its presence.  When userspace omits it, uverbs_attr_get_obj() returns
> > ERR_PTR(-ENOENT) and the handler stores that error pointer into
> > wq_init_attr.cq without validation.
> 
> That handle should be mandatory, declare it as UA_MANDATORY.

ok, I applied it and fixed this patch locally.

Thanks

> 
> Thanks
> 

  reply	other threads:[~2026-09-15  8:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 11:39 [PATCH] RDMA/uverbs: Reject WQ creation without a completion queue lirongqing
2026-09-10 12:33 ` Leon Romanovsky
2026-09-15  8:02   ` Leon Romanovsky [this message]
2026-09-15  8:02 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915080234.GG13683@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=yishaih@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.